~itachi-san/telegram-desktop/breakpad

  • Committer: Mark Mentovai
  • Author(s): Mirko Bonadei
  • Date: 2022-08-12 17:14:46 UTC
  • Revision ID: git-v1:e085b3b50bde862d0cf3ce4594e3f391bcf5faec
Fix -Wdeprecated-declarations when macOS 13 SDK is used.

This CL fixes the following error detected on a WebRTC bot:

FAILED: obj/third_party/breakpad/utilities/ConfigFile.o
/opt/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/breakpad/utilities/ConfigFile.o.d -DCR_XCODE_VERSION=1400 -DCR_CLANG_REVISION=\"llvmorg-16-init-907-g8b740747-1\" -D_LIBCPP_ABI_NAMESPACE=Cr -D_LIBCPP_ABI_VERSION=2 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_NODISCARD -DCR_LIBCXX_REVISION=9f503bebdb9a89f5ee82b82142109b26d688f40c -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../.. -Igen -I../../buildtools/third_party/libc++ -I../../third_party/breakpad/breakpad/src  -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -femit-dwarf-unwind=no-compact-unwind -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -ffp-contract=off -fcomplete-member-pointers -arch x86_64 -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -ffile-compilation-dir=. -no-canonical-prefixes -ftrivial-auto-var-init=pattern -O2 -fno-omit-frame-pointer -g2 -gdwarf-aranges -Xclang -debug-info-kind=limited -isysroot sdk/xcode_links/MacOSX13.0.sdk -mmacos-version-min=10.13 -fvisibility=hidden -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang raw-ref-template-as-trivial-member -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Werror -Wall -Wno-unused-variable -Wno-c++11-narrowing -Wno-unused-but-set-variable -Wno-misleading-indentation -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wloop-analysis -Wno-unneeded-internal-declaration -Wenum-compare-conditional -Wno-psabi -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -std=c++17 -Wno-trigraphs -fobjc-call-cxx-cdtors -fno-exceptions -fno-rtti -nostdinc++ -isystem../../buildtools/third_party/libc++/trunk/include -isystem../../buildtools/third_party/libc++abi/trunk/include -fvisibility-inlines-hidden -c ../../third_party/breakpad/breakpad/src/client/mac/crash_generation/ConfigFile.mm -o obj/third_party/breakpad/utilities/ConfigFile.o
../../third_party/breakpad/breakpad/src/client/mac/crash_generation/ConfigFile.mm:108:5: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
    sprintf(processUptimeString, "%llu",
    ^
sdk/xcode_links/MacOSX13.0.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
__deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
^
sdk/xcode_links/MacOSX13.0.sdk/usr/include/sys/cdefs.h:214:48: note: expanded from macro '__deprecated_msg'
        #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))
                                                      ^
../../third_party/breakpad/breakpad/src/client/mac/crash_generation/ConfigFile.mm:114:3: error: 'sprintf' is deprecated: This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead. [-Werror,-Wdeprecated-declarations]
  sprintf(processCrashtimeString, "%zd", tv.tv_sec);
  ^
sdk/xcode_links/MacOSX13.0.sdk/usr/include/stdio.h:188:1: note: 'sprintf' has been explicitly marked deprecated here
__deprecated_msg("This function is provided for compatibility reasons only.  Due to security concerns inherent in the design of sprintf(3), it is highly recommended that you use snprintf(3) instead.")
^
sdk/xcode_links/MacOSX13.0.sdk/usr/include/sys/cdefs.h:214:48: note: expanded from macro '__deprecated_msg'
        #define __deprecated_msg(_msg) __attribute__((__deprecated__(_msg)))

Bug: webrtc:14342
Change-Id: I923ab3f9155eb36aa2edf9b1d38c123e3e6ad029
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3829529
Reviewed-by: Mark Mentovai <mark@chromium.org>
Filename Latest Rev Last Changed Committer Comment Size
..
.github 1737 5 years ago Mike Frysinger support mistaken-pull-closer for automatically cle Diff
android 882 11 years ago digit@chromium.org Add Android NDK module definition + sample applica Diff
autotools 8 17 years ago mmentovai Make build system less annoying (#8) r=bryner - P Diff
docs 1379 8 years ago Mark Mentovai [Docs] add markdown docs (converted from Wiki) BU Diff
m4 472 14 years ago nealsid ARM support, with some build system changes to sup Diff
src 4 17 years ago bryner Initial import, which includes the Windows client- Diff
.clang-format 1868 3 years ago Mike Frysinger Add a .clang-format file to give us local control 422 bytes Diff Download File
.gitignore 1895 3 years ago Mike Frysinger Add core_handler and pid2md into git ignore `core 2.6 KB Diff Download File
aclocal.m4 2019 1 year ago Mike Frysinger regen autotools Previous updates to these were pa 46.8 KB Diff Download File
appveyor.yml 1589 7 years ago Mike Frysinger Appveyor CI for Windows MSVS build Add a .gyp fil 1.1 KB Diff Download File
AUTHORS 8 17 years ago mmentovai Make build system less annoying (#8) r=bryner - P 22 bytes Diff Download File
breakpad-client.pc.in 1246 9 years ago vapier@chromium.org make "make install" also install headers and pkgco 312 bytes Diff Download File
breakpad.pc.in 1246 9 years ago vapier@chromium.org make "make install" also install headers and pkgco 298 bytes Diff Download File
ChangeLog 4 17 years ago bryner Initial import, which includes the Windows client- Empty Diff Download File
codereview.settings 1796 4 years ago Mike Frysinger codereview.settings: do not force squashing behavi 135 bytes Diff Download File
File configure 2022 1 year ago Mike Frysinger configure: support rustc-demangle installations in 266 KB Diff Download File
configure.ac 2022 1 year ago Mike Frysinger configure: support rustc-demangle installations in 8.6 KB Diff Download File
default.xml 1952 2 years ago Mike Frysinger gtest: update to 1.11 release Keeps us in sync wi 1.2 KB Diff Download File
DEPS 1952 2 years ago Mike Frysinger gtest: update to 1.11 release Keeps us in sync wi 3.2 KB Diff Download File
DIR_METADATA 1964 2 years ago Mike Frysinger add DIR_METADATA settings Change-Id: I104e667a354 451 bytes Diff Download File
INSTALL 1137 10 years ago ted.mielczarek@gmail.com autoreconf -f -i git-svn-id: http://google-breakp 15.3 KB Diff Download File
LICENSE 1856 3 years ago Sterling Augustine There are source files with APSL-2.0 as well. Cha 6.2 KB Diff Download File
Makefile.am 2030 1 year ago George Burgess {static_,}range_map: fix overflows under ubsan Ex 61.1 KB Diff Download File
Makefile.in 2030 1 year ago George Burgess {static_,}range_map: fix overflows under ubsan Ex 0.9 MB Diff Download File
NEWS 4 17 years ago bryner Initial import, which includes the Windows client- Empty Diff Download File
OWNERS 1918 2 years ago Mike Frysinger add OWNERS settings Since the entire Chromium GoB 270 bytes Diff Download File
README.ANDROID 1504 7 years ago Ted Mielczarek Update symbol file documentation links. These loc 4.6 KB Diff Download File
README.md 1951 2 years ago Mike Frysinger CI: convert Travis to GH actions With Travis shut 3 KB Diff Download File