~itachi-san/telegram-desktop/breakpad

  • Committer: Ivan Penkov
  • Author(s): Greg Thompson
  • Date: 2024-07-12 18:37:06 UTC
  • Revision ID: git-v1:7f3ccb77337bc9d35b252fcddc4f6a983f80dd6b
[Windows] PDBSourceLineWriter improvements

COM calls that return a BSTR via an out param pass ownership of the
string's underlying memory to the caller. It is the caller's
responsibility to free the memory via SysFreeString. Be sure to use
CComBSTR in all such cases, so that this happens upon destruction of the
CComBSTR. This CL fixes three BSTR memory leaks.

The inline_origins_ member maps an inline origin's name to a unique
numerical identifier. Simplify the container by mapping a name only to
an id rather than a name to a struct holding the name and id.

These origins are printed ordered by id. Rather than using a std::set to
create a container sorted by id, leverage the fact that ids are ints
that are assigned sequentially to create the reverse mapping in a
std::vector. This greatly reduces heap usage, and reduces complexity to
O(N).

Combined, these changes reduce commit charge by 26% and runtime by 10%
when processing chrome.dll for a 32-bit win-dcheck build.

Change-Id: Ib8d6540c74622500989f1dc06f705d6846be303f
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/5682242
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
Filename Latest Rev Last Changed Committer Comment Size
..
dia_util.cc 2100 2 years ago Ian Barkley-Yeung Add #include <config.h> to the beginning of all cc 3.2 KB Diff Download File
dia_util.h 2046 2 years ago Mark Mentovai Update copyright boilerplate, 2022 edition (Breakp 2.8 KB Diff Download File
guid_string.cc 2100 2 years ago Ian Barkley-Yeung Add #include <config.h> to the beginning of all cc 2.9 KB Diff Download File
guid_string.h 2046 2 years ago Mark Mentovai Update copyright boilerplate, 2022 edition (Breakp 2.2 KB Diff Download File
http_upload.cc 2189 8 months ago Ivan Penkov [symupload] Upload compressed symbol files on Wind 19.9 KB Diff Download File
http_upload.h 2189 8 months ago Ivan Penkov [symupload] Upload compressed symbol files on Wind 5 KB Diff Download File
module_info.h 2046 2 years ago Mark Mentovai Update copyright boilerplate, 2022 edition (Breakp 3.1 KB Diff Download File
omap.cc 2100 2 years ago Ian Barkley-Yeung Add #include <config.h> to the beginning of all cc 26.1 KB Diff Download File
omap.h 2046 2 years ago Mark Mentovai Update copyright boilerplate, 2022 edition (Breakp 3.5 KB Diff Download File
omap_internal.h 2046 2 years ago Mark Mentovai Update copyright boilerplate, 2022 edition (Breakp 5.3 KB Diff Download File
omap_unittest.cc 2100 2 years ago Ian Barkley-Yeung Add #include <config.h> to the beginning of all cc 12 KB Diff Download File
pdb_source_line_writer.cc 2190 8 months ago Ivan Penkov [Windows] PDBSourceLineWriter improvements COM ca 51.5 KB Diff Download File
pdb_source_line_writer.h 2190 8 months ago Ivan Penkov [Windows] PDBSourceLineWriter improvements COM ca 13.8 KB Diff Download File
pe_source_line_writer.cc 2100 2 years ago Ian Barkley-Yeung Add #include <config.h> to the beginning of all cc 2.8 KB Diff Download File
pe_source_line_writer.h 2128 1 year ago Lei Zhang Modernize code - Replace DISALLOW_COPY_AND_ASSIGN 2.5 KB Diff Download File
pe_util.cc 2100 2 years ago Ian Barkley-Yeung Add #include <config.h> to the beginning of all cc 13 KB Diff Download File
pe_util.h 2046 2 years ago Mark Mentovai Update copyright boilerplate, 2022 edition (Breakp 3 KB Diff Download File
string_utils-inl.h 2046 2 years ago Mark Mentovai Update copyright boilerplate, 2022 edition (Breakp 5.7 KB Diff Download File
string_utils.cc 2100 2 years ago Ian Barkley-Yeung Add #include <config.h> to the beginning of all cc 4 KB Diff Download File
sym_upload_v2_protocol.cc 2100 2 years ago Ian Barkley-Yeung Add #include <config.h> to the beginning of all cc 4.7 KB Diff Download File
sym_upload_v2_protocol.h 2046 2 years ago Mark Mentovai Update copyright boilerplate, 2022 edition (Breakp 2.8 KB Diff Download File
symbol_collector_client.cc 2187 8 months ago Ivan Penkov [symupload] Fix malformed Content-Type header Sen 4.9 KB Diff Download File
symbol_collector_client.h 2046 2 years ago Mark Mentovai Update copyright boilerplate, 2022 edition (Breakp 3.5 KB Diff Download File