~itachi-san/telegram-desktop/breakpad

Viewing all changes in revision 1762.

  • Committer: Mark Mentovai
  • Date: 2019-04-26 18:44:49 UTC
  • Revision ID: git-v1:9f90ceb904b776d194863af218e8bce26d95ce8f
Linux MinidumpWriter: fix stack-use-after-scope violation

One form of google_breakpad::WriteMinidump() passed MappingList and
AppMemoryList objects by reference to a MinidumpWriter object,
instantiating them directly as constructor parameters. The
MinidumpWriter stored these objects internally as references, and the
underlying objects went out of scope after MinidumpWriter construction.
The MinidumpWriter outlived them, causing a violation on any attempt to
access them following construction.

This bug was detected by AddressSanitizer at
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8915150848087289472/+/steps/breakpad_unittests__with_patch_/0/stdout

Bug: chromium:949098
Change-Id: I072ea9f1b64e1eae3e89d4a2b158764ff7970db5
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1585946
Reviewed-by: Robert Sesek <rsesek@chromium.org>

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: