~jameinel/juju-core/api-facade-registry : changes

~jameinel/juju-core/api-facade-registry » Changes to environs/jujutest/livetests.go from revision 2729

From Revision 2729 to 2187

Rev	Summary	Authors	Date
2728	Merged api-rpc-reflect-version into api-facade-registry. Merged api-rpc-reflect-version into api-facade-registry.	John Arbash Meinel	10 years ago
2727	merge api-rpc-reflect-version including trunk and update to merge api-rpc-reflect-version including trunk and update to github.com/juju/errors	John Arbash Meinel	10 years ago
2720	Merge trunk r2730 Merge trunk r2730	John Arbash Meinel	10 years ago
2674	[r=axwalk],[bug=1237709] Support placement directives on boo... [r=axwalk],[bug=1237709] Support placement directives on bootstrap juju bootstrap will accept a single, optional positional argument that will be parsed as a placement directive. We currently only allow unscoped placement directives at bootstrap. https://codereview.appspot.com/91740043/	Andrew Wilkins	10 years ago
2666	[r=axwalk],[bug=1237709] Introduce instance.Placement [r=axwalk],[bug=1237709] Introduce instance.Placement This change introduces a new Placement structure in the instance package that encapsulates machine-id, container, and (new) environment-specific placement directives. The add-machine subcommand is modified to pass this new Placement structure through the AddMachine client API, which calls a new state method AddMachineWithPlacement. Machine-id and container placement do the same thing as before, while new environment- specific placement structures are stored in state. A new state policy is added to allow an Environ to validate placement. The provisioner API and worker are updated to pass Placement through to StartInstance. https://codereview.appspot.com/85040046/	Andrew Wilkins	10 years ago
2659	[r=wallyworld] Add constraints validation to providers [r=wallyworld] Add constraints validation to providers Each provider has a constraints validator which is used when setting constraints on a machine or service, as well as when constraints are merged. The validation step allows conflicting constraints like instance-type and mem to be rejected, and also unsupported constraints to be logged with a warning. The merge step allows things like instance-type to mask other incompatible constraints like mem or arch, and visa versa. https://codereview.appspot.com/88780043/	Ian Booth	10 years ago
2648	[r=dimitern] errors: Improve tests, unify interfaces, wrappi... [r=dimitern] errors: Improve tests, unify interfaces, wrapping The errors package is refactored so that for all errors defined there are 3 functions with consistent names: * Is<type>(error) bool Returns true if the error satifies <type> (i.e. it was created with one of the two constructors below for <type>. * New<type>(error, string) error Creates an error of <type> wrapping the given error and adding the prefix to the message. * <type>f(string, ...interface{}) error Creates an error of <type> with a message, formatted like fmt.Sprintf. Dropped "Error" from type and function names (as they already are in the "errors" package). Moved utils.ErrorContextf in here, renaming it to Maskf. A new helper called Contextf is added, which works similarly to Maskf, but preserves the original error when wrapping (if it's one of the known types), so that the Is<type>() satifiers will work on the wrapped error as well. Added automatic exhaustive testing for each error type in a way that makes it easier to add new types. Few drive-by fixes made while fixing the rest of the code base to use the new function names. I realize we should use errgo for such things, but we can easily change the errors package to use errgo internally later. https://codereview.appspot.com/87560043/ R=rogpeppe	Dimiter Naydenov	10 years ago
2595	[r=jameinel] Merge 1.18 into trunk to get the fix for bug #1... [r=jameinel] Merge 1.18 into trunk to get the fix for bug #1299802 Refuse to downgrade when DesiredVersion returns a version number < version.Current.	Curtis Hovey	10 years ago
2577	[r=dimitern] environs: Add []NetworkInfo to StartInstance [r=dimitern] environs: Add []NetworkInfo to StartInstance This does not introduce new logic, just changes the StartInstance() return values (across all providers) to include a slice of NetworkInfo, which will be used in a follow-up by the MAAS provider to report what networks and network interfaces will be configured for the instance. https://codereview.appspot.com/84470044/ R=fwereade, gz	Dimiter Naydenov	10 years ago
2559	[r=cmars],[bug=1290824] Resolve series with charm store in j... [r=cmars],[bug=1290824] Resolve series with charm store in juju client. For the deploy and upgradecharm commands, when a series is not provided, and a default-series is not set in the environment config, the client will resolve the series with the charm store, through the state server. If the client is working with a 1.16 state server, it will resolve the series directly with the charm store. Existing environments will have a default-series, so they should have no change in series selection. New environments will continue to support the default-series config setting, but it can be omitted, and is not set by default. https://codereview.appspot.com/80280043/	Casey Marshall	10 years ago
2551	[r=axwalk] Add DistributionGroup to StartInstanceParams [r=axwalk] Add DistributionGroup to StartInstanceParams DistributionGroup returns instances that StartInstance should consider when provisioning for high availability (i.e. the new instance + those in DistributionGroup should be distributed for high availability.) DistributionGroup is implemented in terms of a new provisioner API method of the same name. This API returns different instances depending on the machine passed in. For an environ manager, all other environ manager instances are returned; for a non-environ manager, all other instances with services in common are returned. This is in preparation for modifying the Azure provider to group instances into the same cloud service when in availability-sets-enabled mode. https://codereview.appspot.com/75250043/	Andrew Wilkins	10 years ago
2540	[r=dimitern] provisioner: Start instances with networks [r=dimitern] provisioner: Start instances with networks Provisioner worker is made aware of networks specified for a machine and passes them to the providers when starting instances. This involves a few extra things: * cloudinit.MachineConfig now has IncludeNetworks and ExcludeNetworks params and they can be set using NewMachineConfig(); * StartInstanceParams.Networks dropped and now networks are specified via SIP.MachineConfig; * provisioner gets specified machine networks and passes them through StartInstanceParams.MachineConfig to the providers; * all providers except maas changed to return an error in StartInstance() when networks are specified (using MachineConfig.HasNetworks()). All changes are unit-tested and live-tested on MaaS. Next steps: get list of networks from the provider, setup cloudinit scripts to configure the networks (failing with unknown ones) and update the machine with the actually installed networks, so they can be shown in status. https://codereview.appspot.com/83200043/ R=fwereade	Dimiter Naydenov	10 years ago
2477	[r=gz] Add networks params to AddService [r=gz] Add networks params to AddService Append includeNetworks and excludeNetworks to AddService function parameters, and updates callers appropriately. New AddTestingServiceWithNetworks created in a couple of places and used for basic test. https://codereview.appspot.com/79800043/ R=dimitern	Martin Packman	10 years ago
2470	[r=cmars] Charm URL store resolves preferred series. [r=cmars] Charm URL store resolves preferred series. The charm-info request handler now chooses the preferred series for an unresolved charm reference by most recent, LTS preferred over all non-LTS.	Casey Marshall	10 years ago
2418	[r=axwalk] Refactor StartInstance to take param struct [r=axwalk] Refactor StartInstance to take param struct This is in preparation for adding an optional argument to StartInstance that names the principal unit initially assigned to the machine. No functional changes here, just refactoring. https://codereview.appspot.com/75130046/	Andrew Wilkins	10 years ago
2413	[r=waigani] Change checkers import path [r=waigani] Change checkers import path change all imports of: launchpad.net/juju-core/testing/checkers to github.com/juju/testing/checkers. Move the new import to the middle import block.	Jesse Meek	10 years ago
2409	[r=dimitern],[bug=1221134] various: production code and logg... [r=dimitern],[bug=1221134] various: production code and logging improvements Fixed 4 slightly annoying, unrelated minor issues: 1. Refactored production code not to depend on gocheck (manual provider and apiserver/charms). As a drive-by fix, I refactored environs/manual tests to be proper black-box unit tests, rather than white-box tests in the manual package. 2. Fixed and improved tools download output via curl and better handling of errors. 3. Added debug logging to environs sshstorage and httpstorage, and the manual provider. 4. Reformatted and unified generated boilerplate config across all providers, fixing bug #1221134 in the process (-e env not properly explained). Changes tested live with a manual and local environs with added manually provisioned machines. While testing I found out and filed this bug #1291292 (basically manual bootstrap is broken with ssl-hostname- verification set to false, but this is due to a deeper issue). I tried to unify and fix when all commands report "environment not bootstrapped", consistently across providers, but it turned out like more work than I originally thought, so I'll do a follow-up on that (which will entail dropping support for 1.14 environments without a .jenv file). https://codereview.appspot.com/72860045/ R=jameinel, rogpeppe	Dimiter Naydenov	10 years ago
2344	[r=axwalk] Wire up prechecker [r=axwalk] Wire up prechecker We introduce the concept of a policy into state: state.State is given a state.Policy interface when opened, which is consulted during certain operations to validate or modify behaviour. The Policy interface contains only one method, Prechecker, which is called to obtain a Prechecker. The Prechecker, if non-nil, is used to ensure that an instance with the specified parameters can potentially be instantiated. There is currently only one implementation of Prechecker, and that is the manual provider's Environ. The manual provider thus prevents add-machine without ssh- placement. https://codereview.appspot.com/61520045/	Andrew Wilkins	10 years ago
2335	[r=axwalk],[bug=1279259] Pass environs.BootstrapContext to P... [r=axwalk],[bug=1279259] Pass environs.BootstrapContext to Prepare This is part one of fixing lp:1279259. In this CL, we pass context to Prepare, giving providers an opportunity to prompt the user to initialise an environment. Passing context was previously restricted to Bootstrap and EnableBootstrapStorage; this is insufficient, as there are many ways to prepare an environment. It is currently possible to successfully "Prepare" and environment, but for the result to be unusable in the manual provider (e.g. if the bootstrap-host address is invalid). We should that a successfully Prepared environment should be able to be Destroyed (with force). https://codereview.appspot.com/62780044/	Andrew Wilkins	10 years ago
2187	[r=jameinel],[bug=1253631],[bug=1262186] cmd/juju/addmachine... [r=jameinel],[bug=1253631],[bug=1262186] cmd/juju/addmachine: compat with 1.16 This addresses bug #1253631. It changes the 'juju add-machine ssh:foo' to fall back to direct DB access when it is unable to make the new API calls. Some of the code is also refactored a bit to make it clearer when we are gathering information, vs when we are acting on that information (recording it in state, etc). This also required bringing DestroyMachines back somewhere that we could share the code (instead of only living in cmd/juju/destroymachine). I went for state/statecmd even though I didn't end up sharing that code with the API server. (We could, but we're quite likely to be deleting it soon, and it seemed like busy work to move it just to move it back.) https://codereview.appspot.com/40670043/	John Arbash Meinel	10 years ago

Older »