1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
|
from mock import patch, call, MagicMock
from collections import OrderedDict
import cinder_utils as cinder_utils
from test_utils import (
CharmTestCase,
)
TO_PATCH = [
# helpers.core.hookenv
'config',
'log',
# helpers.core.host
'mounts',
'umount',
# ceph utils
'ceph_create_pool',
'ceph_pool_exists',
# storage_utils
'create_lvm_physical_volume',
'create_lvm_volume_group',
'deactivate_lvm_volume_group',
'is_lvm_physical_volume',
'relation_ids',
'remove_lvm_physical_volume',
'ensure_loopback_device',
'is_block_device',
'zap_disk',
'get_os_codename_package',
'get_os_codename_install_source',
'configure_installation_source',
'eligible_leader',
'templating',
# fetch
'apt_update',
'apt_install'
]
MOUNTS = [
['/mnt', '/dev/vdb']
]
class TestCinderUtils(CharmTestCase):
def setUp(self):
super(TestCinderUtils, self).setUp(cinder_utils, TO_PATCH)
self.config.side_effect = self.test_config.get_all
def svc_enabled(self, svc):
return svc in self.test_config.get('enabled-services')
def test_all_services_enabled(self):
'''It determines all services are enabled based on config'''
self.test_config.set('enabled-services', 'all')
enabled = []
for s in ['volume', 'api', 'scheduler']:
enabled.append(cinder_utils.service_enabled(s))
self.assertEquals(enabled, [True, True, True])
def test_service_enabled(self):
'''It determines services are enabled based on config'''
self.test_config.set('enabled-services', 'api,volume,scheduler')
self.assertTrue(cinder_utils.service_enabled('volume'))
def test_service_not_enabled(self):
'''It determines services are not enabled based on config'''
self.test_config.set('enabled-services', 'api,scheduler')
self.assertFalse(cinder_utils.service_enabled('volume'))
@patch('cinder_utils.service_enabled')
def test_determine_packages_all(self, service_enabled):
'''It determines all packages required when all services enabled'''
service_enabled.return_value = True
pkgs = cinder_utils.determine_packages()
self.assertEquals(sorted(pkgs),
sorted(cinder_utils.COMMON_PACKAGES +
cinder_utils.VOLUME_PACKAGES +
cinder_utils.API_PACKAGES +
cinder_utils.SCHEDULER_PACKAGES))
@patch('cinder_utils.service_enabled')
def test_determine_packages_subset(self, service_enabled):
'''It determines packages required for a subset of enabled services'''
service_enabled.side_effect = self.svc_enabled
self.test_config.set('enabled-services', 'api')
pkgs = cinder_utils.determine_packages()
common = cinder_utils.COMMON_PACKAGES
self.assertEquals(sorted(pkgs),
sorted(common + cinder_utils.API_PACKAGES))
self.test_config.set('enabled-services', 'volume')
pkgs = cinder_utils.determine_packages()
common = cinder_utils.COMMON_PACKAGES
self.assertEquals(sorted(pkgs),
sorted(common + cinder_utils.VOLUME_PACKAGES))
self.test_config.set('enabled-services', 'api,scheduler')
pkgs = cinder_utils.determine_packages()
common = cinder_utils.COMMON_PACKAGES
self.assertEquals(sorted(pkgs),
sorted(common + cinder_utils.API_PACKAGES +
cinder_utils.SCHEDULER_PACKAGES))
def test_creates_restart_map_all_enabled(self):
'''It creates correct restart map when all services enabled'''
ex_map = OrderedDict([
('/etc/cinder/cinder.conf', ['cinder-api', 'cinder-volume',
'cinder-scheduler', 'haproxy']),
('/etc/cinder/api-paste.ini', ['cinder-api']),
('/etc/ceph/ceph.conf', ['cinder-volume']),
('/etc/haproxy/haproxy.cfg', ['haproxy']),
('/etc/apache2/sites-available/openstack_https_frontend',
['apache2']),
('/etc/apache2/sites-available/openstack_https_frontend.conf',
['apache2']),
])
self.assertEquals(cinder_utils.restart_map(), ex_map)
@patch('cinder_utils.service_enabled')
def test_creates_restart_map_no_api(self, service_enabled):
'''It creates correct restart map with api disabled'''
service_enabled.side_effect = self.svc_enabled
self.test_config.set('enabled-services', 'scheduler,volume')
ex_map = OrderedDict([
('/etc/cinder/cinder.conf', ['cinder-volume', 'cinder-scheduler',
'haproxy']),
('/etc/ceph/ceph.conf', ['cinder-volume']),
('/etc/haproxy/haproxy.cfg', ['haproxy']),
('/etc/apache2/sites-available/openstack_https_frontend',
['apache2']),
('/etc/apache2/sites-available/openstack_https_frontend.conf',
['apache2']),
])
self.assertEquals(cinder_utils.restart_map(), ex_map)
@patch('cinder_utils.service_enabled')
def test_creates_restart_map_only_api(self, service_enabled):
'''It creates correct restart map with only api enabled'''
service_enabled.side_effect = self.svc_enabled
self.test_config.set('enabled-services', 'api')
ex_map = OrderedDict([
('/etc/cinder/cinder.conf', ['cinder-api', 'haproxy']),
('/etc/cinder/api-paste.ini', ['cinder-api']),
('/etc/haproxy/haproxy.cfg', ['haproxy']),
('/etc/apache2/sites-available/openstack_https_frontend',
['apache2']),
('/etc/apache2/sites-available/openstack_https_frontend.conf',
['apache2']),
])
self.assertEquals(cinder_utils.restart_map(), ex_map)
def test_ensure_block_device_bad_config(self):
'''It doesn't prepare storage with bad config'''
for none in ['None', 'none', None]:
self.assertRaises(cinder_utils.CinderCharmError,
cinder_utils.ensure_block_device,
block_device=none)
def test_ensure_block_device_loopback(self):
'''It ensures loopback device when checking block device'''
cinder_utils.ensure_block_device('/tmp/cinder.img')
ex_size = cinder_utils.DEFAULT_LOOPBACK_SIZE
self.ensure_loopback_device.assert_called_with('/tmp/cinder.img',
ex_size)
cinder_utils.ensure_block_device('/tmp/cinder-2.img|15G')
self.ensure_loopback_device.assert_called_with('/tmp/cinder-2.img',
'15G')
def test_ensure_standard_block_device(self):
'''It looks for storage at both relative and full device path'''
for dev in ['vdb', '/dev/vdb']:
cinder_utils.ensure_block_device(dev)
self.is_block_device.assert_called_with('/dev/vdb')
def test_ensure_nonexistent_block_device(self):
'''It will not ensure a non-existant block device'''
self.is_block_device.return_value = False
self.assertRaises(cinder_utils.CinderCharmError,
cinder_utils.ensure_block_device, 'foo')
def test_clean_storage_unmount(self):
'''It unmounts block device when cleaning storage'''
self.is_lvm_physical_volume.return_value = False
self.zap_disk.return_value = True
self.mounts.return_value = MOUNTS
cinder_utils.clean_storage('/dev/vdb')
self.umount.called_with('/dev/vdb', True)
def test_clean_storage_lvm_wipe(self):
'''It removes traces of LVM when cleaning storage'''
self.mounts.return_value = []
self.is_lvm_physical_volume.return_value = True
cinder_utils.clean_storage('/dev/vdb')
self.remove_lvm_physical_volume.assert_called_with('/dev/vdb')
self.deactivate_lvm_volume_group.assert_called_with('/dev/vdb')
def test_clean_storage_zap_disk(self):
'''It removes traces of LVM when cleaning storage'''
self.mounts.return_value = []
self.is_lvm_physical_volume.return_value = False
cinder_utils.clean_storage('/dev/vdb')
self.zap_disk.assert_called_with('/dev/vdb')
def test_prepare_lvm_storage_not_clean(self):
'''It errors when prepping non-clean LVM storage'''
self.is_lvm_physical_volume.return_value = True
self.assertRaises(cinder_utils.CinderCharmError,
cinder_utils.prepare_lvm_storage,
block_device='/dev/foobar',
volume_group='bar-vg')
def test_prepare_lvm_storage_clean(self):
self.is_lvm_physical_volume.return_value = False
cinder_utils.prepare_lvm_storage(block_device='/dev/foobar',
volume_group='bar-vg')
self.create_lvm_physical_volume.assert_called_with('/dev/foobar')
self.create_lvm_volume_group.assert_called_with('bar-vg',
'/dev/foobar')
def test_prepare_lvm_storage_error(self):
self.is_lvm_physical_volume.return_value = False
self.create_lvm_physical_volume.side_effect = Exception()
# NOTE(jamespage) ensure general Exceptions mapped
# to CinderCharmError's
self.assertRaises(cinder_utils.CinderCharmError,
cinder_utils.prepare_lvm_storage,
block_device='/dev/foobar',
volume_group='bar-vg')
def test_migrate_database(self):
'''It migrates database with cinder-manage'''
with patch('subprocess.check_call') as check_call:
cinder_utils.migrate_database()
check_call.assert_called_with(['cinder-manage', 'db', 'sync'])
def test_ensure_ceph_pool(self):
self.ceph_pool_exists.return_value = False
cinder_utils.ensure_ceph_pool(service='cinder', replicas=3)
self.ceph_create_pool.assert_called_with(service='cinder',
name='cinder',
replicas=3)
def test_ensure_ceph_pool_already_exists(self):
self.ceph_pool_exists.return_value = True
cinder_utils.ensure_ceph_pool(service='cinder', replicas=3)
self.assertFalse(self.ceph_create_pool.called)
@patch('os.path.exists')
def test_register_configs_apache(self, exists):
exists.return_value = False
self.get_os_codename_package.return_value = 'grizzly'
self.relation_ids.return_value = False
configs = cinder_utils.register_configs()
calls = []
for conf in [cinder_utils.CINDER_API_CONF,
cinder_utils.CINDER_CONF,
cinder_utils.APACHE_SITE_CONF,
cinder_utils.HAPROXY_CONF]:
calls.append(
call(conf,
cinder_utils.CONFIG_FILES[conf]['hook_contexts'])
)
configs.register.assert_has_calls(calls, any_order=True)
@patch('os.path.exists')
def test_register_configs_apache24(self, exists):
exists.return_value = True
self.get_os_codename_package.return_value = 'grizzly'
self.relation_ids.return_value = False
configs = cinder_utils.register_configs()
calls = []
for conf in [cinder_utils.CINDER_API_CONF,
cinder_utils.CINDER_CONF,
cinder_utils.APACHE_SITE_24_CONF,
cinder_utils.HAPROXY_CONF]:
calls.append(
call(conf,
cinder_utils.CONFIG_FILES[conf]['hook_contexts'])
)
configs.register.assert_has_calls(calls, any_order=True)
@patch('os.mkdir')
@patch('os.path.isdir')
@patch('os.path.exists')
def test_register_configs_ceph(self, exists, isdir, mkdir):
exists.return_value = False
isdir.return_value = False
self.get_os_codename_package.return_value = 'grizzly'
self.relation_ids.return_value = ['ceph:0']
configs = cinder_utils.register_configs()
calls = []
for conf in [cinder_utils.CINDER_API_CONF,
cinder_utils.CINDER_CONF,
cinder_utils.APACHE_SITE_CONF,
cinder_utils.HAPROXY_CONF,
cinder_utils.CEPH_CONF]:
calls.append(
call(conf,
cinder_utils.CONFIG_FILES[conf]['hook_contexts'])
)
configs.register.assert_has_calls(calls, any_order=True)
self.assertTrue(mkdir.called)
def test_set_ceph_kludge(self):
pass
"""
def set_ceph_env_variables(service):
# XXX: Horrid kludge to make cinder-volume use
# a different ceph username than admin
env = open('/etc/environment', 'r').read()
if 'CEPH_ARGS' not in env:
with open('/etc/environment', 'a') as out:
out.write('CEPH_ARGS="--id %s"\n' % service)
with open('/etc/init/cinder-volume.override', 'w') as out:
out.write('env CEPH_ARGS="--id %s"\n' % service)
"""
@patch.object(cinder_utils, 'migrate_database')
@patch.object(cinder_utils, 'determine_packages')
def test_openstack_upgrade_leader(self, pkgs, migrate):
pkgs.return_value = ['mypackage']
self.config.side_effect = None
self.config.return_value = 'cloud:precise-havana'
self.eligible_leader.return_value = True
self.get_os_codename_install_source.return_value = 'havana'
configs = MagicMock()
cinder_utils.do_openstack_upgrade(configs)
self.assertTrue(configs.write_all.called)
configs.set_release.assert_called_with(openstack_release='havana')
self.assertTrue(migrate.called)
@patch.object(cinder_utils, 'migrate_database')
@patch.object(cinder_utils, 'determine_packages')
def test_openstack_upgrade_not_leader(self, pkgs, migrate):
pkgs.return_value = ['mypackage']
self.config.side_effect = None
self.config.return_value = 'cloud:precise-havana'
self.eligible_leader.return_value = False
self.get_os_codename_install_source.return_value = 'havana'
configs = MagicMock()
cinder_utils.do_openstack_upgrade(configs)
self.assertTrue(configs.write_all.called)
configs.set_release.assert_called_with(openstack_release='havana')
self.assertFalse(migrate.called)
|