1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
|
# Copyright 2009 Canonical Ltd. This software is licensed under the
# GNU Affero General Public License version 3 (see the file LICENSE).
"""Tests for automatic landing thing."""
__metaclass__ = type
import unittest
from launchpadlib.uris import (
DEV_SERVICE_ROOT, EDGE_SERVICE_ROOT, LPNET_SERVICE_ROOT,
STAGING_SERVICE_ROOT)
from bzrlib.plugins.pqm.lpland import (
get_bazaar_host, get_bugs_clause, get_reviewer_clause,
get_reviewer_handle, MissingReviewError)
class FakeBug:
"""Fake launchpadlib Bug object.
Only used for the purposes of testing.
"""
def __init__(self, id):
self.id = id
class FakePerson:
"""Fake launchpadlib Person object.
Only used for the purposes of testing.
"""
def __init__(self, name, irc_handles):
self.name = name
self.irc_nicknames = list(irc_handles)
class FakeIRC:
"""Fake IRC handle.
Only used for the purposes of testing.
"""
def __init__(self, nickname, network):
self.nickname = nickname
self.network = network
class TestBugsClaused(unittest.TestCase):
"""Tests for `get_bugs_clause`."""
def test_no_bugs(self):
# If there are no bugs, then there is no bugs clause.
bugs_clause = get_bugs_clause([])
self.assertEqual('', bugs_clause)
def test_one_bug(self):
# If there's a bug, then the bugs clause is [bug=$ID].
bug = FakeBug(45)
bugs_clause = get_bugs_clause([bug])
self.assertEqual('[bug=45]', bugs_clause)
def test_two_bugs(self):
# If there are two bugs, then the bugs clause is [bug=$ID,$ID].
bug1 = FakeBug(20)
bug2 = FakeBug(45)
bugs_clause = get_bugs_clause([bug1, bug2])
self.assertEqual('[bug=20,45]', bugs_clause)
class TestGetReviewerHandle(unittest.TestCase):
"""Tests for `get_reviewer_handle`."""
def makePerson(self, name, irc_handles):
return FakePerson(name, irc_handles)
def test_no_irc_nicknames(self):
# If the person has no IRC nicknames, their reviewer handle is their
# Launchpad user name.
person = self.makePerson(name='foo', irc_handles=[])
self.assertEqual('foo', get_reviewer_handle(person))
def test_freenode_irc_nick_preferred(self):
# If the person has a Freenode IRC nickname, then that is preferred as
# their user handle.
person = self.makePerson(
name='foo', irc_handles=[FakeIRC('bar', 'irc.freenode.net')])
self.assertEqual('bar', get_reviewer_handle(person))
def test_non_freenode_nicks_ignored(self):
# If the person has IRC nicks that aren't freenode, we ignore them.
person = self.makePerson(
name='foo', irc_handles=[FakeIRC('bar', 'irc.efnet.net')])
self.assertEqual('foo', get_reviewer_handle(person))
class TestGetReviewerClause(unittest.TestCase):
"""Tests for `get_reviewer_clause`."""
def makePerson(self, name):
return FakePerson(name, [])
def get_reviewer_clause(self, reviewers):
return get_reviewer_clause(reviewers)
def test_one_reviewer_no_type(self):
# It's very common for a merge proposal to be reviewed by one person
# with no specified type of review. It such cases the review clause is
# '[r=<person>][ui=none]'.
clause = self.get_reviewer_clause({None: [self.makePerson('foo')]})
self.assertEqual('[r=foo][ui=none]', clause)
def test_two_reviewers_no_type(self):
# Branches can have more than one reviewer.
clause = self.get_reviewer_clause(
{None: [self.makePerson('foo'), self.makePerson('bar')]})
self.assertEqual('[r=bar,foo][ui=none]', clause)
def test_mentat_reviewers(self):
# A mentat review sometimes is marked like 'ui*'. Due to the
# unordered nature of dictionaries, the reviewers are sorted before
# being put into the clause for predictability.
clause = self.get_reviewer_clause(
{None: [self.makePerson('foo')],
'code*': [self.makePerson('newguy')],
'ui': [self.makePerson('beuno')],
'ui*': [self.makePerson('bac')]})
self.assertEqual('[r=foo,newguy][ui=bac,beuno]', clause)
def test_code_reviewer_counts(self):
# Some people explicitly specify the 'code' type when they do code
# reviews, these are treated in the same way as reviewers without any
# given type.
clause = self.get_reviewer_clause({'code': [self.makePerson('foo')]})
self.assertEqual('[r=foo][ui=none]', clause)
def test_release_critical(self):
# Reviews that are marked as release-critical are included in a
# separate clause.
clause = self.get_reviewer_clause(
{'code': [self.makePerson('foo')],
'release-critical': [self.makePerson('bar')]})
self.assertEqual('[release-critical=bar][r=foo][ui=none]', clause)
def test_db_reviewer_counts(self):
# There's no special way of annotating database reviews in Launchpad
# commit messages, so they are included with the code reviews.
clause = self.get_reviewer_clause({'db': [self.makePerson('foo')]})
self.assertEqual('[r=foo][ui=none]', clause)
def test_ui_reviewers(self):
# If someone has done a UI review, then that appears in the clause
# separately from the code reviews.
clause = self.get_reviewer_clause(
{'code': [self.makePerson('foo')],
'ui': [self.makePerson('bar')],
})
self.assertEqual('[r=foo][ui=bar]', clause)
def test_no_reviewers(self):
# If the merge proposal hasn't been approved by anyone, we cannot
# generate a valid clause.
self.assertRaises(MissingReviewError, self.get_reviewer_clause, {})
class TestGetBazaarHost(unittest.TestCase):
"""Tests for `get_bazaar_host`."""
def test_dev_service(self):
# The Bazaar host for the dev service is bazaar.launchpad.dev.
self.assertEqual(
'bazaar.launchpad.dev', get_bazaar_host(DEV_SERVICE_ROOT))
def test_edge_service(self):
# The Bazaar host for the edge service is bazaar.launchpad.net, since
# there's no edge codehosting service.
self.assertEqual(
'bazaar.launchpad.net', get_bazaar_host(EDGE_SERVICE_ROOT))
def test_production_service(self):
# The Bazaar host for the production service is bazaar.launchpad.net.
self.assertEqual(
'bazaar.launchpad.net', get_bazaar_host(LPNET_SERVICE_ROOT))
def test_staging_service(self):
# The Bazaar host for the staging service is
# bazaar.staging.launchpad.net.
self.assertEqual(
'bazaar.staging.launchpad.net',
get_bazaar_host(STAGING_SERVICE_ROOT))
def test_unrecognized_service(self):
# Any unrecognized URL will raise a ValueError.
self.assertRaises(
ValueError, get_bazaar_host, 'https://api.lunchpad.net')
|