~jcsackett/charmworld/bac-tag-constraints : changes

~jcsackett/charmworld/bac-tag-constraints » Changes from revision 491.1.2

From Revision 491.1.2 to 474

Rev	Summary	Authors	Date
491.1.2	Move lint before test in lbox.check Move lint before test in lbox.check	Brad Crittenden	11 years ago
491.1.1	Re-write bundle service's constraints on ingest to be space-... Re-write bundle service's constraints on ingest to be space-separated.	Brad Crittenden	11 years ago
491	Filter charmworld searches by score. Filter charmworld searches by score. This change introduces a new parameter to the API search called 'min_score'. It defaults to a value of 1.0. Searches will be filtered and only those results with a score above min_score will be returned. The min_score will not be used if the search is for all bundles or charms. In addition, the number of results will be limited the smaller of 20 or the limit provided. Again, the limit is not applied if the search is for all charms or bundles. QA: % bin/ingest --limit=20 % make run In another window, interactively poke at it, e.g. % http GET "http://127.0.0.1:2464/api/3/search?text=mysql&min_score=0" % http GET "http://127.0.0.1:2464/api/3/search?text=mysql&min_score=2" % http GET "http://127.0.0.1:2464/api/3/search?text=charmworld&min_score=0" https://codereview.appspot.com/74900043/ R=benji. Fixes: https://bugs.launchpad.net/bugs/1287977. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
490	Normalize charm URLs in bundles Normalize charm URLs in bundles This branch normalizes the charm URLs in bundles for the GUI, which is expecting at least a <schema>:<series>/<name> style URL. Current proof allows bundles with charms specified only by name, so long as they're in the charmstore already. Caveats: * Currently only works on ingest * May require a GUI branch as well to add -HEAD if no version number (a smart move anyway) depending on API support. QA: * Run * Enqueue and ingest at least mysql and mediawiki * bin/enqueue --prefix=~bac/charms/bundles * bin/ingest-queued --prefix=~bac/charms/bundles --limit=100 * Get bac's bundle wiki:wiki - the charms should all have a charm: attribute, and the attributes should all be URLs as specified above. https://codereview.appspot.com/71070051/ R=benji, rharding. Approved by Benji York, Juju Gui Bot.	Matthew Scott	11 years ago
489	Make the proof API check constraints. Make the proof API check constraints. The proof API now uses charmworldlib to check the charm constraints specified in a bundle (deployer file). Errors returned from parse_constraints are returned as errors. If check_constraints indicates the constraints are comma-separated then a deprecation warning is returned. The previous API did not allow for warnings, so that mechanism was added. There are a lot of drive-by cleanups too, mainly in the test. Sorry for the noise they introduce but I think the code is more consistent and the tests are improved. https://codereview.appspot.com/69980054/ R=makyo. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
488	Use most recent data for current mean, not oldest. Use most recent data for current mean, not oldest. Approved by Juju Gui Bot, Brad Crittenden.	j.c.sackett	11 years ago
487	Add "charms:" and "bundles:" prefix to search (both via the ... Add "charms:" and "bundles:" prefix to search (both via the web interface and the API). Approved by Juju Gui Bot, Richard Harding.	Rick Harding	11 years ago
486	Removes the min and max data from review and improves chart ... Removes the min and max data from review and improves chart display. Approved by Juju Gui Bot, Brad Crittenden.	j.c.sackett	11 years ago
485	Promulgate bundles owned by ~charmers. Promulgate bundles owned by ~charmers. https://codereview.appspot.com/65550043/ R=benji. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
484	[r=bac] Copy the existing charms over during exodus. Fixes: ... [r=bac] Copy the existing charms over during exodus. Fixes: https://bugs.launchpad.net/bugs/1278222. Approved by Juju Gui Bot, Brad Crittenden.	Brad Crittenden	11 years ago
483	Add an index for db.charms. Add an index for db.charms. Without the proper index, sorting mongo results fail. * Add setup_mongo_indices and make it idempotent. * Lots of tests. * Change migration 'initialize' to call setup_mongo_indices. * Add a migration for existing dbs. * Drive by ugliness The migration scripts, even long-lived ones like test_migrations.py, were quite dirty lint-wise. Turns out the Makefile was excluding them explicitly. Changed the lint target and then had to fix the old scripts. https://codereview.appspot.com/61720043/ R=jcsackett. Fixes: https://bugs.launchpad.net/bugs/1278222. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
482	Add support for debug mode in getting charm icons. Add support for debug mode in getting charm icons. Normally a non-promulgated charm will get the generic icon, even if it has its own icon. Adding a '?debug' querystring will cause it to return the actual icon. Landing this change for Rick Harding. * Changed debug default value to False from None. * Added a test for a non-promulgated charm that does have an icon but no debug querystring. https://codereview.appspot.com/49700045/ R=bac. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
481	Updates the criteria for trigger_tests to prevent excessive ... Updates the criteria for trigger_tests to prevent excessive test calls. Fixes: https://bugs.launchpad.net/bugs/1272023. Approved by Juju Gui Bot, j.c.sackett, Brad Crittenden.	j.c.sackett	11 years ago
480	Fixes an enqueue error for ingest that occurs because of a n... Fixes an enqueue error for ingest that occurs because of a non-indexed sort. Approved by Juju Gui Bot, j.c.sackett, Brad Crittenden.	j.c.sackett	11 years ago
479	Add a very useful hint about relation ordering. Add a very useful hint about relation ordering. Approved by Juju Gui Bot.	Benji York	11 years ago
478	Improves the trigger_tests function with logging, and correc... Improves the trigger_tests function with logging, and corrects an error in url construction. Approved by Juju Gui Bot, Curtis Hovey.	j.c.sackett	11 years ago
477	Clear queues at ingest startup. Clear queues at ingest startup. Bundles seem to get stuck when the job entries are locked and the ingest process dies, such as happens when charm attributes are set or the charm gets updated. To avoid having the queues littered with items that never go away, which is disconcerting to the casual viewer of /heartbeat, this branch introduces a new --clear option to the queueing process which is used by the worker on the first invocation This branch also addresses a few other issues by being more defensive in the face of charms and bundles that are non-standard in a number of ways. * Handle the lack of 'bundles.yaml' gracefully. * Handle SVG files with float placement values. * Handle charms with no files. The only instance I've seen of this occurring is with a charm that is private in Launchpad, so I cannot assess how it happens. https://codereview.appspot.com/51010046/ R=rharding. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
476	Properly proof bundles with inheritance. Properly proof bundles with inheritance. - Use the existing get_flattened_deployment to realize the inheritance. - Update to new version of charm-tools. - Specify version for charmworldlib rather than grabbing the latest from pypi. - Add work-around to forking charm-tools to allow proofing on localhost during ingest. QA: In one terminal: % make run In another: % bin/ingest-queued --prefix=~bac Ensure that ~bac/charms/bundle/complicated/bundle ingests A-OK. https://codereview.appspot.com/51650043/ R=rharding. Fixes: https://bugs.launchpad.net/bugs/1263112. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago
475	Automatically trigger builds for new charms and new revision... Automatically trigger builds for new charms and new revisions of existing charms. Approved by Juju Gui Bot, Curtis Hovey.	j.c.sackett	11 years ago
474	Add two more questions to QA assessment. Add two more questions to QA assessment. https://codereview.appspot.com/49030044/ R=bac. Approved by Juju Gui Bot.	Brad Crittenden	11 years ago

Older »