~jcsackett/charmworld/bac-tag-constraints

  • Committer: Tarmac
  • Author(s): Brad Crittenden
  • Date: 2014-07-16 16:39:51 UTC
  • mfrom: (515.1.1 ngram-inquiry)
  • Revision ID: tarmac-20140716163951-hunwr56yizg012h5
Make ngram searches work.

After the ngram search was deployed it was discovered to only work if 1) using
the API and 2) had autocomplete=true.

Inspecting the code showed the intent for ngram to be used in other
situations, and there was not documented rationale for only using it when
doing autocomplete.

The problem was simply in the query for non-autocomplete the field for the
ngrams was prefixed with 'data.' when it should not have been.

The ngrams fields were moved out of the charm and bundle fields and passed as
separate fields, treated like 'provides' and 'requires', to avoid the
prefixing.

As a result of this change, the search on the manage.jujucharms.com page now
uses ngrams too.

https://codereview.appspot.com/117810044/

R=makyo. Fixes: https://bugs.launchpad.net/bugs/1220909.

Approved by Juju Gui Bot, Matthew Scott.
Filename Latest Rev Last Changed Committer Comment Size
..
charmworld 1 12 years ago kapil.foss at gmail charmworld pyramid starter Diff
docs 33 12 years ago kapil.foss at gmail add install doc Diff
scripts 21 12 years ago Kapil Thangavelu add ctl scripts Diff
.bzrignore 458.1.3 10 years ago j.c.sackett Bzr should ignore our conventional lp credentials 430 bytes Diff Download File
.lbox 419.1.2 10 years ago Brad Crittenden lbox defaults to -cr and sets project to charmworl 31 bytes Diff Download File
File .lbox.check 491.1.2 10 years ago Brad Crittenden Move lint before test in lbox.check 66 bytes Diff Download File
CHANGES.txt 67.1.10 11 years ago Kapil Thangavelu put back accidentally yanked changes 28 bytes Diff Download File
default.ini 474.1.6 10 years ago j.c.sackett Changes to address commentar in review. 2.9 KB Diff Download File
distribute_setup.py 71.1.2 11 years ago Rick Harding Add missing files 15.3 KB Diff Download File
LICENSE.txt 61 11 years ago kapil.foss at gmail add license 33.7 KB Diff Download File
Makefile 506.2.9 10 years ago Reed O'Brien don't install svn, and juju:pkgs->juju:stable 5.1 KB Diff Download File
MANIFEST.in 1 12 years ago kapil.foss at gmail charmworld pyramid starter 133 bytes Diff Download File
README.txt 7 12 years ago kapil.foss at gmail work in progress on multi namespace support 252 bytes Diff Download File
requirements.txt 487.2.1 10 years ago Brad Crittenden Check charm constraints when doing proof. Lots of 1.3 KB Diff Download File
setup.cfg 304.4.26 10 years ago Aaron Bentley Move logging filters to nose config. 569 bytes Diff Download File
setup.py 511.2.1 10 years ago Brad Crittenden Remove beaker:mongo stanza from setup.py 1.4 KB Diff Download File
test-setup.ini 474.1.6 10 years ago j.c.sackett Changes to address commentar in review. 668 bytes Diff Download File