- Committer: Ken VanDine
- Date: 2012-01-11 23:49:05 UTC
- Revision ID: ken.vandine@canonical.com-20120111234905-qio3featdrjsq0r9
Patch from ~covox (LP: #867649)
In method ido_offscreen_proxy_realize(), a call is made to gdk_screen_get_rgba_visual() to get a GdkVisual handle, which is then passed as part of a GdkWindowAttr structure to gdk_window_new().
What's not taken into account is that gdk_screen_get_rgba_visual() will return NULL if RGBA isn't supported by the destination window manager (e.g. if someone turned the Composite extension off). In this case, as the field is always marked as valid for use (GDK_WA_VISUAL), gdk_window_new will fall over.
Attached is a patch to fall back on gdk_screen_get_system_visual() if RGBA isn't available. With this, unity-panel-service no longer crashes after interacting with the Sound indicator if the Composite extension is switched off.
In method ido_offscreen_proxy_realize(), a call is made to gdk_screen_get_rgba_visual() to get a GdkVisual handle, which is then passed as part of a GdkWindowAttr structure to gdk_window_new().
What's not taken into account is that gdk_screen_get_rgba_visual() will return NULL if RGBA isn't supported by the destination window manager (e.g. if someone turned the Composite extension off). In this case, as the field is always marked as valid for use (GDK_WA_VISUAL), gdk_window_new will fall over.
Attached is a patch to fall back on gdk_screen_get_system_visual() if RGBA isn't available. With this, unity-panel-service no longer crashes after interacting with the Sound indicator if the Composite extension is switched off.
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 .. |
|||||||
example
|
1 | 14 years ago | Cody Russell | IDO initial commit, scale menuitem |
|
||
|
src
|
1 | 14 years ago | Cody Russell | IDO initial commit, scale menuitem |
|
||
.bzrignore |
92 | 12 years ago | Ted Gould | Ignoring m4 | 619 bytes |
|
|
|
AUTHORS |
1 | 14 years ago | Cody Russell | IDO initial commit, scale menuitem | 39 bytes |
|
|
autogen.sh |
2 | 14 years ago | Cody Russell | Autogen changes | 202 bytes |
|
|
|
ChangeLog |
1 | 14 years ago | Cody Russell | IDO initial commit, scale menuitem | Empty |
|
|
|
configure.ac |
97.1.1 | 12 years ago | Ken VanDine | removed deprecations from gtk3 and fixed sizing is | 3.6 KB |
|
|
|
COPYING |
6.3.1 | 14 years ago | Cody Russell | Copyright/license fu | 7.4 KB |
|
|
|
COPYING.LGPL.2.1 |
6.3.1 | 14 years ago | Cody Russell | Copyright/license fu | 25.9 KB |
|
|
|
INSTALL |
1 | 14 years ago | Cody Russell | IDO initial commit, scale menuitem | 9.2 KB |
|
|
|
libido.pc.in |
1 | 14 years ago | Cody Russell | IDO initial commit, scale menuitem | 244 bytes |
|
|
|
libido3.pc.in |
77.1.2 | 12 years ago | Michael Terry | allow building either gtk2 or gtk3 versions; some | 246 bytes |
|
|
|
Makefile.am |
82.3.1 | 12 years ago | Javier Jardón | build: Use upstream silent rules instead shave | 456 bytes |
|
|
|
NEWS |
1 | 14 years ago | Cody Russell | IDO initial commit, scale menuitem | Empty |
|
|
|
README |
1 | 14 years ago | Cody Russell | IDO initial commit, scale menuitem | Empty |
|
|
|
TODO |
6.3.2 | 14 years ago | Cody Russell | Remove stuff | Empty |
|
|