- Committer: Kilian Evang
- Date: 2015-05-12 13:44:26 UTC
- Revision ID: noreply@texttheater.net-20150512134426-qla5fmyglw5mfnwk
ReviewWdgt no longer associates shortcuts with grade buttons, instead handles
all key presses in the keyPressEvent method. I think this allows for a more
unified, less error-prone treatment of the keyboard interface.
In addition, it now always avoids reacting to auto-repeated grade key presses.
For example, if you press a number key to show the answer and hold it down for
too long, it would previously immediately grade the card. This is no longer the
case. There was no obvious way to solve this problem with the shortcuts.
Furthermore, it now always avoids grading the current card when the answer is
not showing. Previously, there was a race condition that could lead to two
cards being graded in a row when the user accidentally hit two grade keys at
once, see https://code.launchpad.net/~kevang/mnemosyne-proj/grade_only_if_showing/+merge/235605
for a detailed description.
all key presses in the keyPressEvent method. I think this allows for a more
unified, less error-prone treatment of the keyboard interface.
In addition, it now always avoids reacting to auto-repeated grade key presses.
For example, if you press a number key to show the answer and hold it down for
too long, it would previously immediately grade the card. This is no longer the
case. There was no obvious way to solve this problem with the shortcuts.
Furthermore, it now always avoids grading the current card when the answer is
not showing. Previously, there was a race condition that could lead to two
cards being graded in a row when the user accidentally hit two grade keys at
once, see https://code.launchpad.net/~kevang/mnemosyne-proj/grade_only_if_showing/+merge/235605
for a detailed description.
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
files
|
815 | 15 years ago | Peter Bienstman | More import work. |
|
||
benchmark.py |
1514 | 12 years ago | Peter Bienstman | -Bundle webserver on windows. -Fixes for activate | 5.4 KB |
|
|
|
benchmark_pyqt.py |
1178 | 14 years ago | Peter Bienstman | Add option not to download pregenerated data durin | 6.3 KB |
|
|
|
benchmark_sync_client.py |
1310 | 13 years ago | Peter Bienstman | Update benchmark code. | 5 KB |
|
|
|
benchmark_sync_server.py |
1310 | 13 years ago | Peter Bienstman | Update benchmark code. | 3.1 KB |
|
|
|
mnemosyne_test.py |
1786 | 10 years ago | Peter.Bienstman at UGent | Mark 2.3.1 | 3.8 KB |
|
|
|
test_activate_cards.py |
1681 | 11 years ago | Peter Bienstman | Finish sister cards/tags rework. | 17.8 KB |
|
|
|
test_add_cards.py |
1857 | 9 years ago | Peter.Bienstman at UGent | Fixing merging duplicate cards bug. | 16 KB |
|
|
|
test_card_type.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 13.7 KB |
|
|
|
test_cloze.py |
1756 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes | 15 KB |
|
|
|
test_controller.py |
1758 | 10 years ago | Peter.Bienstman at UGent | Fix latex related crash in cards export. | 8.1 KB |
|
|
|
test_convert_cards.py |
1762 | 10 years ago | Peter.Bienstman at UGent | Make card conversion more robust. | 30.8 KB |
|
|
|
test_cramming.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 6.1 KB |
|
|
|
test_cuecard_wcu_import.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 2.1 KB |
|
|
|
test_database.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 31.4 KB |
|
|
|
test_db_import.py |
1852 | 9 years ago | Peter.Bienstman at UGent | Small fixes. | 2.7 KB |
|
|
|
test_escape_to_html.py |
1460 | 12 years ago | Peter Bienstman | Improve linebreak handling. | 1.5 KB |
|
|
|
test_filter.py |
1771 | 10 years ago | Peter.Bienstman at UGent | Fix media path expansion corner case. | 2.4 KB |
|
|
|
test_html_css.py |
1576 | 12 years ago | Peter Bienstman | -fix case-related bug -don't ask for exit confirma | 4.1 KB |
|
|
|
test_logging.py |
1786 | 10 years ago | Peter.Bienstman at UGent | Mark 2.3.1 | 15.2 KB |
|
|
|
test_media.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 18.9 KB |
|
|
|
test_mem_import.py |
1800 | 10 years ago | Peter.Bienstman at UGent | Improve regular expression for src detection. | 36.2 KB |
|
|
|
test_mnemosyne1xml_import.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 16.7 KB |
|
|
|
test_mnemosyne2cards.py |
1758 | 10 years ago | Peter.Bienstman at UGent | Fix latex related crash in cards export. | 15 KB |
|
|
|
test_non_latin_font_size_increase.py |
1348 | 13 years ago | Peter Bienstman | Finish 'increase size of non-latin'. | 2.9 KB |
|
|
|
test_plugin.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 7.6 KB |
|
|
|
test_render_chain.py |
1514 | 12 years ago | Peter Bienstman | -Bundle webserver on windows. -Fixes for activate | 5 KB |
|
|
|
test_review_controller.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 7.5 KB |
|
|
|
test_scheduler.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 30.1 KB |
|
|
|
test_sentence.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 4.4 KB |
|
|
|
test_smconv_import.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 2.1 KB |
|
|
|
test_statistics.py |
1680 | 11 years ago | Peter Bienstman | Start on sister tag issues. | 7.2 KB |
|
|
|
test_supermemo_7_text_import.py |
1751 | 10 years ago | Peter.Bienstman at UGent | More testsuite fixes. | 2.3 KB |
|
|
|
test_sync.py |
1833 | 10 years ago | Peter.Bienstman at UGent | -fix sync with filenames with double dot -always g | 146 KB |
|
|
|
test_tag_tree.py |
1578 | 12 years ago | Peter Bienstman | Bug fixes for translations. Added test cases for t | 17.6 KB |
|
|
|
test_translator.py |
1378 | 13 years ago | Peter Bienstman | Fix translation issues. | 1.3 KB |
|
|
|
test_tsv_import.py |
1758 | 10 years ago | Peter.Bienstman at UGent | Fix latex related crash in cards export. | 5.7 KB |
|
|
|
test_util_functions.py |
1600 | 12 years ago | Peter Bienstman | -fix an issue with cancelling a card type conversi | 1.9 KB |
|
|