-
Committer:
Kilian Evang
-
Date:
2015-05-12 13:44:26 UTC
-
Revision ID:
noreply@texttheater.net-20150512134426-qla5fmyglw5mfnwk
ReviewWdgt no longer associates shortcuts with grade buttons, instead handles
all key presses in the keyPressEvent method. I think this allows for a more
unified, less error-prone treatment of the keyboard interface.
In addition, it now always avoids reacting to auto-repeated grade key presses.
For example, if you press a number key to show the answer and hold it down for
too long, it would previously immediately grade the card. This is no longer the
case. There was no obvious way to solve this problem with the shortcuts.
Furthermore, it now always avoids grading the current card when the answer is
not showing. Previously, there was a race condition that could lead to two
cards being graded in a row when the user accidentally hit two grade keys at
once, see https://code.launchpad.net/~kevang/mnemosyne-proj/grade_only_if_showing/+merge/235605
for a detailed description.