~kevinoid/duplicity/windows-port : changes

~kevinoid/duplicity/windows-port » Changes from revision 703

From Revision 703 to 684

Rev	Summary	Authors	Date
703	Include updates to GnuPGInterface Include updates to GnuPGInterface These updates are from the current state of a branch of development that I created to port GnuPGInterface to Windows, fix some bugs, and add Python 3 support. The branch is available on github at <http://github.com/kevinoid/py-gnupg>. These changes are taken from commit 91667c. I have assurances from the original author of GnuPGInterface that the changes will be merged into his sources with minimal changes (if any) once he has time and that it is safe to merge these changes into other projects that need them without introducing a significant maintenance burden. Note: This version of GnuPGInterface now uses subprocess rather than "raw" fork/exec. The threaded waitpid was removed due to threading issues with subprocess (particularly Issue 1731717). It should be largely unnecessary as any zombie child processes are reaped when a new subprocess is started. If the more immediate reaping is required, the threaded wait can easily be re-added (and less-easily be made thread safe with subprocess). Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
702	Unwrap temporary file instances Unwrap temporary file instances tempfile.TemporaryFile returns an instance of a wrapper class on non-POSIX, non-Cygwin systems. Yet the librsync code requires a standard file object. On Windows, the wrapper is unnecessary since the file is opened with O_TEMPORARY and is deleted automatically on close. On other systems the wrapper may be necessary to delete a file, so we error out (in a way that future developers on those systems should be able to find and understand...). Note: This is a bit of a hack and relies on undocumented properties of the object returned from tempfile.TemporaryFile. However, it avoids the need to track and delete the temporary file ourselves. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
701	Make the manifest format more interoperable Make the manifest format more interoperable At the cost of losing a bit of information, use the POSIX path and EOL convention as part of the file format for manifest files. This way backups created on one platform can be restored on another with a different path and/or EOL convention. To accomplish this, change the file mode to binary and convert native paths to POSIX paths during manifest creation and back during load. Note: During load the drive specifier for the target directory (if there is one) is added to the POSIX-converted path. This allows restoring cross-platform files more easily at the cost of losing a warning about restoring files to a different drive than the original backup. If this is unacceptable, the drive could be the first component of the POSIX path or the cross-platform interoperability could be dropped. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
700	Prevent Windows paths from being parsed as URLs Prevent Windows paths from being parsed as URLs Windows paths which begin with a drive specifier are parsed as having a scheme which is the drive letter. In order to avoid against these paths being treated as URLs, check if the potential url_string looks like a Windows path. Note: The regex is not perfect, since it is possible that the "c" URL scheme would not require slashes after the protocol. So limit the checks to Windows platforms where paths are more likely to have this form. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
699	Make file:// URL parsing more portable Make file:// URL parsing more portable Create path.from_url_path utility function which takes the path component of a file URL and converts it into the native path representation on the platform. Note: RFC 1738 specifies that anything after file:// before the next slash is a hostname (and therefore, implicitly, all paths are absolute). However, to maintain backwards compatibility, allow for relative paths to be specified in this manner. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
698	Ensure prefix ends with empty path component Ensure prefix ends with empty path component WARNING: Functionality change In order to prevent the given prefix from matching directories which begin with the last component of prefix, ensure that prefix ends with an empty path component (causing a tailing slash on POSIX systems). Otherwise the prefix /foo/b would also include /foo/bar. Note: If this functionality really was intended, wherever prefix is removed from a path, the result should not start with a directory separator (since it would result in a "/" first element in the return value from path.split_all). Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
697	Replace path manipulation based on "/" Replace path manipulation based on "/" Make use of path.split_all and os.path.join where paths were manipulated based on "/" In selection, change path import to keep path namespace, but alias path.Path to Path to minimize the diff. The bare uses of split_all seemed unnecessarily confusing and the other members of path are not used directly so there is no real need for the * import. Note: Removed unnecessary use of filter to remove blanks as this is handled implicitly by os.path.split and therefore by path.split_all. Note2: Need to be careful that os.path.join must have at least 1 argument, while "/".join() could work on a 0-length array. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
696	Create split_all utility function in path Create split_all utility function in path This function is intended to replace the pathstr.split("/") idiom in many places and provides a convenient way to break an arbitrary path into its constituent components. Note: Although it would be possible to split on os.altsep and os.sep and it would work in many cases, and run a bit faster, it doesn't handle more complex path systems and is likely to fail in corner cases even in less complex path systems. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
695	Support systems without pwd and/or grp in tarfile Support systems without pwd and/or grp in tarfile Inside tarfile this case is normally checked by the calling code, but since uid2uname and gid2gname are called by Path without checking for pwd and grp (and we want to support this case), remove the assertion that these modules are defined. When they are not, throw KeyError indicating the ID could not be mapped. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
694	Support more path systems in glob->regex conversion Support more path systems in glob->regex conversion - Match against the system path separators, rather than "/" - Update duplicity.1 man page to indicate that the metacharacters match against the directory separator, rather than "/" Note: This won't be portable to systems with more complex path systems (like VMS), but that case is not trivial so it is worth waiting for a need to arise. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
693	Protect against error code not in errno.errcode Protect against error code not in errno.errcode Unfortunately, the coverage of errno.errorcode is not complete and some functions can return unexpected error codes (e.g. code 123 on Windows for incorrect name syntax). In the case that it is not in errno.errcode, it is not the error being checked for, which is fine. Avoid KeyError by using .get() Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
692	Only call os.chown in Path if available Only call os.chown in Path if available Can't call os.chown when it is not defined. No need on such systems. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
691	Change archive_dir and config_dir on Windows Change archive_dir and config_dir on Windows Set archive_dir and config_dir according to the platform convention on Windows when run on Windows. Cache data is stored in the local application data folder if found, or the application data folder otherwise. Configuration data is stored in the application data directory. The recommended way to determine the location of these folders (which is user-configurable) is through SHGetFolderPath, which is only available using ctypes. This is more robust than using the environment variables, but can be taken out if use of ctypes is found to be unacceptable. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
690	Only create SrcIter when required Only create SrcIter when required Since the constructor of SrcIter opens a file that is not closed until the iter is read to completion or garbage collected, avoid creating SrcIter unless it will be used. This also fixes a problem on Windows where files can not be renamed while open, causing os.rename to fail in to_final. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
689	Replace invocation of "cp -p" with Path.copy Replace invocation of "cp -p" with Path.copy Avoid running another process to do a simple file copy. Improves portability to systems without "cp -p" support (Windows) Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
688	Disable to_partial checkpointing on Windows Disable to_partial checkpointing on Windows Windows does not allow renaming files which are open for writing, which makes it not (easily) possible to do the to_partial rename. On Windows, skip renaming of the partial and allow the hook to do the rename when the file is closed. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
687	Improve --restore-dir command-line parsing Improve --restore-dir command-line parsing Rather than removing the trailing slash, remove an empty component from the end of the path (if any). This should work with all path schemes. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
686	Handle --log-fd argument specially on Windows Handle --log-fd argument specially on Windows C file descriptors are not inherited in Windows as they are in Unix-like systems. However, OS file handles are inheritable. So the common practice on Windows (used by gpg among others) is to interpret fd arguments as OS file handle numbers. To this end, convert the OS file handle argument to a C file descriptor before calling log.add_fd. Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
685	Update import_backends assertion for Windows Update import_backends assertion for Windows Check that the case-normalized path ends with "duplicity" and "backends" joined by a separator. Note: This is not portable to other systems, e.g. VMS Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago
684	Make compilec.py portable to Windows Make compilec.py portable to Windows - Replace invocation of mv/rm with os.rename and shutil.rmtree - Replace find with os.walk - Check for .pyd in addition to .so file extension - Warn if binary not found Signed-off-by: Kevin Locke <klocke@digitalenginesoftware.com>	Kevin Locke	13 years ago

Older »