~lachlan-mulcahy/percona-xtrabackup/1.6-bug903984

Viewing all changes in revision 305.

  • Committer: Alexey Kopytov
  • Date: 2011-11-11 18:12:31 UTC
  • Revision ID: akopytov@gmail.com-20111111181231-ax8fbousm0s09s43
Bug #408803: innodbbackupex reaches Servers wait_timeout

The problem was the flawed keep-alive logic in innobackupex: keep-alive
queries were only sent to server when mysql_keep_alive() or
mysql_check() were explicitly called. Which led to connection timeouts
when some activity between those calls (e.g. copying a large non-InnoDB
file) took longer than server's wait_timeout.

Fixed innobackupex so that keep-alive queries are now sent automatically
using alarms. The time interval was also reduced from 1800 to 5 seconds
to accommodate low wait_timeout values. Since there is no need for
explicit calls to mysql_check() and mysql_keep_alive(), those functions
were removed.

There is no test case, because time sensitive tests for innobackupex are
basically impossible.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: