-
Committer:
Tarmac
-
Author(s):
Free Ekanayaka
-
Date:
2013-05-07 22:44:23 UTC
-
mfrom:
(660.9.5 amp-cleanup-9)
-
Revision ID:
tarmac-20130507224423-3vx51fxdcsaky2ro
Merge amp-cleanup-9 [f=1170669] [r=radix,tribaal] [a=Free Ekanayaka]
Alright, one of the last episodes of the AMP cleanup saga. In this branch:
- Drop landscape.lib.amp.RemoteObjectConnector, as most of its functionality has no been pushed down to MethodCallClientFactory which is a more standard Twisted primitive more importantly and is transport-agnostic, making landscape.lib.amp really generic.
- Convert landscape.lib.tests.test_amp.RemoteObjectConnectorTest to MethodCallFunctionalTest. The RemoteObjectConnectorTest class was exercising the (now gone) RemoteObjectConnector in a functional-like way, that means spinning the real twisted reactor and listening/connecting to real Unix sockets. Even if from a strict unit-test point of view all the functionality in landscape.lib.amp is already tested, I felt it was nice to still have some functional-like coverage mainly to protect us against regressions or API changes in the Twisted machinery that we depend on. I've used @inlineCallbacks to make tests a bit more readable.