~laney/mojo/snap-base

Viewing all changes in revision 497.

  • Committer: mergebot at canonical
  • Author(s): "Colin Watson"
  • Date: 2019-04-24 11:56:50 UTC
  • mfrom: (496.1.1 remove-git-verify-check)
  • Revision ID: mergebot@juju-139df4-prod-is-toolbox-0.canonical.com-20190424115650-qcq4l59b76nvi1h5
Remove verify check from run-jenkins-job-git-spec.

This check doesn't exist in the corresponding run-jenkins-job-bzr-spec
script, and it's buggy because it doesn't take MOJO_STAGE into consideration
when determining the path to the manifest file.  Furthermore, manifests may
well do their verification by including another manifest; without expanding
includes, this script can't tell whether a manifest does any verify
operations.  As such I think it's better to just drop this incorrect check.

Reviewed-on: https://code.launchpad.net/~cjwatson/mojo/remove-git-verify-check/+merge/366449
Reviewed-by: Tom Haddon <tom.haddon@canonical.com>
Reviewed-by: Barry Price <barry.price@canonical.com>

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: