~ltrager/maas/lp1554636_2.0

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
# Copyright 2015 Canonical Ltd.  This software is licensed under the
# GNU Affero General Public License version 3 (see the file LICENSE).

"""Tests for bcache API."""

__all__ = []

import http.client
from uuid import uuid4

from django.core.urlresolvers import reverse
from maasserver.enum import (
    CACHE_MODE_TYPE,
    FILESYSTEM_GROUP_TYPE,
    FILESYSTEM_TYPE,
    NODE_STATUS,
)
from maasserver.testing.api import APITestCase
from maasserver.testing.factory import factory
from maasserver.testing.orm import reload_object
from maasserver.utils.converters import (
    human_readable_bytes,
    json_load_bytes,
)
from testtools.matchers import (
    ContainsDict,
    Equals,
)


def get_bcache_devices_uri(node):
    """Return a Node's bcache devices URI on the API."""
    return reverse(
        'bcache_devices_handler', args=[node.system_id])


def get_bcache_device_uri(bcache, node=None):
    """Return a bcache device URI on the API."""
    if node is None:
        node = bcache.get_node()
    return reverse(
        'bcache_device_handler', args=[node.system_id, bcache.id])


class TestBcacheDevicesAPI(APITestCase):

    def test_handler_path(self):
        node = factory.make_Node()
        self.assertEqual(
            '/api/1.0/nodes/%s/bcaches/' % (node.system_id),
            get_bcache_devices_uri(node))

    def test_read(self):
        node = factory.make_Node()
        bcaches = [
            factory.make_FilesystemGroup(
                node=node, group_type=FILESYSTEM_GROUP_TYPE.BCACHE)
            for _ in range(3)
        ]
        # Not bcache. Should not be in the output.
        for _ in range(3):
            factory.make_FilesystemGroup(
                node=node, group_type=factory.pick_enum(
                    FILESYSTEM_GROUP_TYPE,
                    but_not=FILESYSTEM_GROUP_TYPE.BCACHE))
        uri = get_bcache_devices_uri(node)
        response = self.client.get(uri)

        self.assertEqual(
            http.client.OK, response.status_code, response.content)
        expected_ids = [
            bcache.id
            for bcache in bcaches
            ]
        result_ids = [
            bcache["id"]
            for bcache in json_load_bytes(response.content)
            ]
        self.assertItemsEqual(expected_ids, result_ids)

    def test_create_403_if_not_admin(self):
        node = factory.make_Node(status=NODE_STATUS.READY)
        backing_size = 10 * 1000 ** 4
        cache_set = factory.make_CacheSet(node=node)
        backing_device = factory.make_PhysicalBlockDevice(
            node=node, size=backing_size)
        uuid = str(uuid4())
        uri = get_bcache_devices_uri(node)
        response = self.client.post(uri, {
            'name': 'bcache0',
            'uuid': uuid,
            'cache_mode': CACHE_MODE_TYPE.WRITEBACK,
            'cache_set': cache_set.id,
            'backing_device': backing_device.id,
        })
        self.assertEqual(
            http.client.FORBIDDEN, response.status_code, response.content)

    def test_create_409_if_not_ready(self):
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.ALLOCATED)
        backing_size = 10 * 1000 ** 4
        cache_set = factory.make_CacheSet(node=node)
        backing_device = factory.make_PhysicalBlockDevice(
            node=node, size=backing_size)
        uuid = str(uuid4())
        uri = get_bcache_devices_uri(node)
        response = self.client.post(uri, {
            'name': 'bcache0',
            'uuid': uuid,
            'cache_mode': CACHE_MODE_TYPE.WRITEBACK,
            'cache_set': cache_set.id,
            'backing_device': backing_device.id,
        })
        self.assertEqual(
            http.client.CONFLICT, response.status_code, response.content)

    def test_create(self):
        """Tests Bcache device creation."""
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.READY)
        backing_size = 10 * 1000 ** 4
        cache_set = factory.make_CacheSet(node=node)
        backing_device = factory.make_PhysicalBlockDevice(
            node=node, size=backing_size)
        uuid = str(uuid4())
        uri = get_bcache_devices_uri(node)
        response = self.client.post(uri, {
            'name': 'bcache0',
            'uuid': uuid,
            'cache_mode': CACHE_MODE_TYPE.WRITEBACK,
            'cache_set': cache_set.id,
            'backing_device': backing_device.id,
        })
        self.assertEqual(
            http.client.OK, response.status_code, response.content)
        parsed_device = json_load_bytes(response.content)
        self.assertEqual(backing_size, parsed_device['virtual_device']['size'])
        self.assertItemsEqual('bcache0', parsed_device['name'])
        self.assertItemsEqual(uuid, parsed_device['uuid'])

    def test_create_with_missing_cache_set_fails(self):
        """Tests Bcache device creation without a cache set."""
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.READY)
        backing_size = 10 * 1000 ** 4
        backing_device = factory.make_PhysicalBlockDevice(
            node=node, size=backing_size)
        uuid = str(uuid4())
        uri = get_bcache_devices_uri(node)
        response = self.client.post(uri, {
            'name': 'bcache0',
            'uuid': uuid,
            'cache_mode': CACHE_MODE_TYPE.WRITEBACK,
            'backing_device': backing_device.id,
        })
        self.assertEqual(
            http.client.BAD_REQUEST, response.status_code, response.content)
        parsed_content = json_load_bytes(response.content)
        self.assertIn(
            'Bcache requires a cache_set.',
            parsed_content['__all__'])
        self.assertIsNone(backing_device.get_effective_filesystem())

    def test_create_with_missing_backing_fails(self):
        """Tests Bcache device creation without a backing device."""
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.READY)
        cache_set = factory.make_CacheSet(node=node)
        uuid = str(uuid4())
        uri = get_bcache_devices_uri(node)
        response = self.client.post(uri, {
            'name': 'bcache0',
            'uuid': uuid,
            'cache_mode': CACHE_MODE_TYPE.WRITEBACK,
            'cache_set': cache_set.id,
        })
        self.assertEqual(
            http.client.BAD_REQUEST, response.status_code, response.content)
        parsed_content = json_load_bytes(response.content)
        self.assertIn(
            'Either backing_device or backing_partition must be specified.',
            parsed_content['__all__'])


class TestBcacheDeviceAPI(APITestCase):

    def test_handler_path(self):
        node = factory.make_Node()
        bcache = factory.make_FilesystemGroup(
            node=node, group_type=FILESYSTEM_GROUP_TYPE.BCACHE)
        self.assertEqual(
            '/api/1.0/nodes/%s/bcache/%s/' % (
                node.system_id, bcache.id),
            get_bcache_device_uri(bcache, node=node))

    def test_read(self):
        node = factory.make_Node()
        cache_set = factory.make_CacheSet(node=node)
        backing_block_device = factory.make_PhysicalBlockDevice(node=node)
        backing_filesystem = factory.make_Filesystem(
            fstype=FILESYSTEM_TYPE.BCACHE_BACKING,
            block_device=backing_block_device)
        bcache = factory.make_FilesystemGroup(
            group_type=FILESYSTEM_GROUP_TYPE.BCACHE, cache_set=cache_set,
            filesystems=[backing_filesystem])
        uri = get_bcache_device_uri(bcache)
        response = self.client.get(uri)

        self.assertEqual(
            http.client.OK, response.status_code, response.content)
        parsed_bcache = json_load_bytes(response.content)
        self.assertThat(parsed_bcache, ContainsDict({
            "id": Equals(bcache.id),
            "uuid": Equals(bcache.uuid),
            "name": Equals(bcache.name),
            "size": Equals(bcache.get_size()),
            "human_size": Equals(
                human_readable_bytes(bcache.get_size())),
            "resource_uri": Equals(get_bcache_device_uri(bcache)),
            "virtual_device": ContainsDict({
                "id": Equals(bcache.virtual_device.id),
                }),
            "cache_set": ContainsDict({
                "id": Equals(cache_set.id),
                "name": Equals(cache_set.name),
                }),
            "backing_device": ContainsDict({
                "id": Equals(backing_block_device.id),
                }),
            }))

    def test_read_404_when_not_bcache(self):
        not_bcache = factory.make_FilesystemGroup(
            group_type=factory.pick_enum(
                FILESYSTEM_GROUP_TYPE, but_not=FILESYSTEM_GROUP_TYPE.BCACHE))
        uri = get_bcache_device_uri(not_bcache)
        response = self.client.get(uri)
        self.assertEqual(
            http.client.NOT_FOUND, response.status_code, response.content)

    def test_delete_deletes_bcache(self):
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.READY)
        bcache = factory.make_FilesystemGroup(
            node=node, group_type=FILESYSTEM_GROUP_TYPE.BCACHE)
        uri = get_bcache_device_uri(bcache)
        response = self.client.delete(uri)
        self.assertEqual(
            http.client.NO_CONTENT, response.status_code, response.content)
        self.assertIsNone(reload_object(bcache))

    def test_delete_403_when_not_admin(self):
        node = factory.make_Node(status=NODE_STATUS.READY)
        bcache = factory.make_FilesystemGroup(
            group_type=FILESYSTEM_GROUP_TYPE.BCACHE, node=node)
        uri = get_bcache_device_uri(bcache)
        response = self.client.delete(uri)
        self.assertEqual(
            http.client.FORBIDDEN, response.status_code, response.content)

    def test_delete_404_when_not_bcache(self):
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.READY)
        not_bcache = factory.make_FilesystemGroup(
            node=node, group_type=factory.pick_enum(
                FILESYSTEM_GROUP_TYPE, but_not=FILESYSTEM_GROUP_TYPE.BCACHE))
        uri = get_bcache_device_uri(not_bcache)
        response = self.client.delete(uri)
        self.assertEqual(
            http.client.NOT_FOUND, response.status_code, response.content)

    def test_delete_409_when_not_ready(self):
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.ALLOCATED)
        bcache = factory.make_FilesystemGroup(
            group_type=FILESYSTEM_GROUP_TYPE.BCACHE, node=node)
        uri = get_bcache_device_uri(bcache)
        response = self.client.delete(uri)
        self.assertEqual(
            http.client.CONFLICT, response.status_code, response.content)

    def test_update_bcache(self):
        """Tests update bcache method by changing the name, UUID and cache
        mode of a bcache."""
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.READY)
        bcache = factory.make_FilesystemGroup(
            node=node, group_type=FILESYSTEM_GROUP_TYPE.BCACHE,
            cache_mode=CACHE_MODE_TYPE.WRITEBACK)
        uri = get_bcache_device_uri(bcache)
        uuid = str(uuid4())
        filesystem_ids = [fs.id for fs in bcache.filesystems.all()]
        response = self.client.put(uri, {
            'name': 'new_name',
            'uuid': uuid,
            'cache_mode': CACHE_MODE_TYPE.WRITEAROUND,
        })
        self.assertEqual(
            http.client.OK, response.status_code, response.content)
        parsed_device = json_load_bytes(response.content)
        self.assertEqual('new_name', parsed_device['name'])
        self.assertEqual(uuid, parsed_device['uuid'])
        self.assertEqual(
            CACHE_MODE_TYPE.WRITEAROUND, parsed_device['cache_mode'])
        # Ensure the filesystems were not changed.
        self.assertListEqual(
            filesystem_ids, [fs.id for fs in bcache.filesystems.all()])

    def test_change_bcache_backing(self):
        """Tests update bcache method by changing backing device to different
        block device."""
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.READY)
        bcache = factory.make_FilesystemGroup(
            node=node, group_type=FILESYSTEM_GROUP_TYPE.BCACHE,
            cache_mode=CACHE_MODE_TYPE.WRITEBACK)
        uri = get_bcache_device_uri(bcache)
        new_backing = factory.make_PhysicalBlockDevice(node=node)
        response = self.client.put(uri, {
            'backing_device': new_backing.id
        })
        self.assertEqual(
            http.client.OK, response.status_code, response.content)
        parsed_device = json_load_bytes(response.content)
        self.assertEqual(new_backing.id, parsed_device['backing_device']['id'])
        self.assertEqual('physical', parsed_device['backing_device']['type'])

    def test_change_storages_to_partitions_bcache(self):
        """Tests update bcache method by changing backing device to a
        partition."""
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.READY)
        bcache = factory.make_FilesystemGroup(
            node=node, group_type=FILESYSTEM_GROUP_TYPE.BCACHE,
            cache_mode=CACHE_MODE_TYPE.WRITEBACK)
        uri = get_bcache_device_uri(bcache)
        new_backing = factory.make_PartitionTable(
            block_device=factory.make_PhysicalBlockDevice(
                node=node)).add_partition()
        response = self.client.put(uri, {
            'backing_partition': new_backing.id
        })
        self.assertEqual(
            http.client.OK, response.status_code, response.content)
        parsed_device = json_load_bytes(response.content)
        self.assertEqual(new_backing.id, parsed_device['backing_device']['id'])
        self.assertEqual('partition', parsed_device['backing_device']['type'])

    def test_invalid_change_fails(self):
        """Tests changing the backing of a bcache device to None fails."""
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.READY)
        bcache = factory.make_FilesystemGroup(
            node=node, group_type=FILESYSTEM_GROUP_TYPE.BCACHE,
            cache_mode=CACHE_MODE_TYPE.WRITEBACK)
        uri = get_bcache_device_uri(bcache)
        new_backing = factory.make_PhysicalBlockDevice()  # On other node.
        response = self.client.put(uri, {
            'backing_device': new_backing.id,
        })
        self.assertEqual(
            http.client.BAD_REQUEST, response.status_code, response.content)
        parsed_content = json_load_bytes(response.content)
        self.assertIn(
            'Select a valid choice.',
            parsed_content['backing_device'][0])

    def test_update_403_if_not_admin(self):
        node = factory.make_Node(status=NODE_STATUS.READY)
        bcache = factory.make_FilesystemGroup(
            node=node, group_type=FILESYSTEM_GROUP_TYPE.BCACHE,
            cache_mode=CACHE_MODE_TYPE.WRITEBACK)
        uri = get_bcache_device_uri(bcache)
        uuid = str(uuid4())
        response = self.client.put(uri, {
            'name': 'new_name',
            'uuid': uuid,
            'cache_mode': CACHE_MODE_TYPE.WRITEAROUND,
        })
        self.assertEqual(
            http.client.FORBIDDEN, response.status_code, response.content)

    def test_update_409_if_not_ready(self):
        self.become_admin()
        node = factory.make_Node(status=NODE_STATUS.ALLOCATED)
        bcache = factory.make_FilesystemGroup(
            node=node, group_type=FILESYSTEM_GROUP_TYPE.BCACHE,
            cache_mode=CACHE_MODE_TYPE.WRITEBACK)
        uri = get_bcache_device_uri(bcache)
        uuid = str(uuid4())
        response = self.client.put(uri, {
            'name': 'new_name',
            'uuid': uuid,
            'cache_mode': CACHE_MODE_TYPE.WRITEAROUND,
        })
        self.assertEqual(
            http.client.CONFLICT, response.status_code, response.content)