~lttng/lttng-modules/trunk : changes

~lttng/lttng-modules/trunk » Changes from revision 1153

From Revision 1153 to 1134

Rev	Summary	Authors	Date
1153	Fix: btrfs instrumentation namespacing Fix: btrfs instrumentation namespacing Triggers this warning: [ 47.922818] WARNING: CPU: 29 PID: 1163 at /home/efficios/git/lttng-modules/lttng-probes.c:83 fixup_lazy_probes+0x1fb/0x210 [lttng_tracer] [ 47.951661] Modules linked in: lttng_probe_compaction(O+) lttng_probe_btrfs(O) lttng_probe_block(O) lttng_ring_buffer_metadata_mmap_client(O) lttng_ring_buffer_client_mmap_overwrite(O) lttng_ring_buffer_client_mmap_discard(O) lttng_ring_buffer_metadata_client(O) lttng_ring_buffer_client_overwrite(O) lttng_ring_buffer_client_discard(O) lttng_tracer(O) lttng_statedump(O) lttng_ftrace(O) lttng_kprobes(O) lttng_clock(O) lttng_uprobes(O) lttng_lib_ring_buffer(O) lttng_kretprobes(O) [ 48.039200] CPU: 29 PID: 1163 Comm: modprobe Tainted: G O 4.19.0-rc7+ #19 [ 48.055628] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 [ 48.078273] RIP: 0010:fixup_lazy_probes+0x1fb/0x210 [lttng_tracer] [ 48.092257] Code: 01 48 39 d0 76 24 43 80 3c 3a 5f 75 1d 44 8b 44 24 14 4c 8b 4c 24 08 41 83 c0 01 45 39 45 10 0f 86 7a fe ff ff e9 6c ff ff ff <0f> 0b e9 6e fe ff ff 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 0f [ 48.141947] RSP: 0018:ffffafe74777bc40 EFLAGS: 00010286 [ 48.153733] RAX: 00000000ffffffff RBX: dead000000000200 RCX: 0000000000000061 [ 48.173986] RDX: 0000000000000005 RSI: ffffffffc04b728c RDI: ffffffffc04b74a5 [ 48.193595] RBP: dead000000000100 R08: 0000000000000062 R09: ffffffffc04bd040 [ 48.211573] R10: ffffffffc04b74a5 R11: ffffffff920e204d R12: ffffffffffffffff [ 48.232131] R13: ffffffffc04bd000 R14: ffffffffc03f0078 R15: 0000000000000005 [ 48.246832] FS: 00007f5495093540(0000) GS:ffff8fcf0fb40000(0000) knlGS:0000000000000000 [ 48.267475] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 48.280348] CR2: 00007ffde00f8328 CR3: 00000018078a2001 CR4: 00000000001606e0 [ 48.302404] Call Trace: [ 48.309201] lttng_probe_register+0xd5/0xe0 [lttng_tracer] [ 48.326993] ? __event_probe__compaction_isolate_template+0x2c0/0x2c0 [lttng_probe_compaction] [ 48.345702] do_one_initcall+0x46/0x1c8 [ 48.360147] ? kobject_uevent_env+0x117/0x810 [ 48.370388] ? _cond_resched+0x15/0x40 [ 48.380649] ? kmem_cache_alloc_trace+0x153/0x1c0 [ 48.394706] do_init_module+0x5b/0x20b [ 48.404412] load_module+0x2194/0x2980 [ 48.418759] ? ima_post_read_file+0xe2/0x120 [ 48.427716] ? __do_sys_finit_module+0xe9/0x110 [ 48.438226] __do_sys_finit_module+0xe9/0x110 [ 48.452983] do_syscall_64+0x65/0x190 [ 48.461521] entry_SYSCALL_64_after_hwframe+0x44/0xa9 [ 48.473173] RIP: 0033:0x7f5494ba6839 [ 48.486630] Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 1f f6 2c 00 f7 d8 64 89 01 48 [ 48.529108] RSP: 002b:00007ffde00fb408 EFLAGS: 00000246 ORIG_RAX: 0000000000000139 [ 48.549652] RAX: ffffffffffffffda RBX: 000055d326ee2ac0 RCX: 00007f5494ba6839 [ 48.564325] RDX: 0000000000000000 RSI: 000055d326cbac2e RDI: 0000000000000005 [ 48.582576] RBP: 000055d326cbac2e R08: 0000000000000000 R09: 000055d326ee2ac0 [ 48.596892] R10: 0000000000000005 R11: 0000000000000246 R12: 0000000000000000 [ 48.617576] R13: 000055d326ee2d80 R14: 0000000000040000 R15: 000055d326ee2ac0 [ 48.633713] ---[ end trace c265591e0ada440c ]--- Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Mathieu Desnoyers	5 years ago
1152	Fix: Convert rcu tracepointis to gp_seq (v4.19) Fix: Convert rcu tracepointis to gp_seq (v4.19) See upstream commits : commit 477351f7829d2268769c5d545511081555066529 Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Date: Tue May 1 12:54:11 2018 -0700 rcu: Convert rcu_grace_period tracepoint to gp_seq This commit makes the rcu_grace_period tracepoint use gp_seq instead of ->gpnum or ->completed. It also introduces a "cpuofl-bgp" string to less obscurely indicate when a CPU has gone offline while a grace period is waiting on it. commit 63d86a7e85f84b8ac3b2f394570965aedbb03787 Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Date: Tue May 1 13:08:46 2018 -0700 rcu: Convert rcu_grace_period_init tracepoint to gp_seq This commit makes the rcu_grace_period_init tracepoint use gp_seq instead of ->gpnum. commit 598ce09480efb6b48799df60c66bac70bea5ef54 Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Date: Tue May 1 13:35:20 2018 -0700 rcu: Convert rcu_preempt_task tracepoint to ->gp_seq This commit makes the rcu_preempt_task tracepoint use ->gp_seq instead of ->gpnum. commit 865aa1e08d8aefdfd1f5d30ecfce1b8ef8cd520a Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Date: Tue May 1 13:35:20 2018 -0700 rcu: Convert rcu_unlock_preempted_task tracepoint to ->gp_seq This commit makes the rcu_unlock_preempted_task tracepoint use ->gp_seq instead of ->gpnum. commit db023296f0115d2fe01fdabad54678f2b806da23 Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Date: Tue May 1 13:35:20 2018 -0700 rcu: Convert rcu_quiescent_state_report tracepoint to ->gp_seq This commit makes the rcu_quiescent_state_report tracepoint use ->gp_seq instead of ->gpnum. commit fee5997c17562e95fb1fecc142efb2da0934baa4 Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Date: Tue May 1 13:35:20 2018 -0700 rcu: Convert rcu_fqs tracepoint to ->gp_seq This commit makes the rcu_fqs tracepoint use ->gp_seq instead of ->gpnum. Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	5 years ago
1151	Fix: tracing: Centralize preemptirq tracepoints (4.19) Fix: tracing: Centralize preemptirq tracepoints (4.19) See upstream commit: commit c3bc8fd637a9623f5c507bd18f9677effbddf584 Author: Joel Fernandes (Google) <joel@joelfernandes.org> Date: Mon Jul 30 15:24:23 2018 -0700 tracing: Centralize preemptirq tracepoints and unify their usage This patch detaches the preemptirq tracepoints from the tracers and keeps it separate. Advantages: * Lockdep and irqsoff event can now run in parallel since they no longer have their own calls. * This unifies the usecase of adding hooks to an irqsoff and irqson event, and a preemptoff and preempton event. 3 users of the events exist: - Lockdep - irqsoff and preemptoff tracers - irqs and preempt trace events The unification cleans up several ifdefs and makes the code in preempt tracer and irqsoff tracers simpler. It gets rid of all the horrific ifdeferry around PROVE_LOCKING and makes configuration of the different users of the tracepoints more easy and understandable. It also gets rid of the time_* function calls from the lockdep hooks used to call into the preemptirq tracer which is not needed anymore. The negative delta in lines of code in this patch is quite large too. In the patch we introduce a new CONFIG option PREEMPTIRQ_TRACEPOINTS as a single point for registering probes onto the tracepoints. With this, the web of config options for preempt/irq toggle tracepoints and its users becomes: PREEMPT_TRACER PREEMPTIRQ_EVENTS IRQSOFF_TRACER PROVE_LOCKING \| \| \ \| \| \ (selects) / \ \ (selects) / TRACE_PREEMPT_TOGGLE ----> TRACE_IRQFLAGS \ / \ (depends on) / PREEMPTIRQ_TRACEPOINTS Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	5 years ago
1150	Fix: net: expose sk wmem in sock_exceed_buf_limit tracepoint... Fix: net: expose sk wmem in sock_exceed_buf_limit tracepoint (4.19) See upstream commit: commit d6f19938eb031ee2158272757db33258153ae59c Author: Yafang Shao <laoar.shao@gmail.com> Date: Sun Jul 1 23:31:30 2018 +0800 net: expose sk wmem in sock_exceed_buf_limit tracepoint Currently trace_sock_exceed_buf_limit() only show rmem info, but wmem limit may also be hit. So expose wmem info in this tracepoint as well. Regarding memcg, I think it is better to introduce a new tracepoint(if that is needed), i.e. trace_memcg_limit_hit other than show memcg info in trace_sock_exceed_buf_limit. Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	5 years ago
1149	Fix: access migrate_disable field directly Fix: access migrate_disable field directly For stable real time kernel > 4.9, the __migrate_disabled utility symbol is not always exported. This can result in linking problem at build time and runtime, preventing the loading of the tracer. The problem was reported to the RT community. [1] [2] A solution is to access the field directly instead of using the utility wrapper. It is important to note that the field is now available for other configurations than CONFIG_PREEMPT_RT_FULL. For now, we choose to expose the migratable context only for configurations where CONFIG_PREEMPT_RT_FULL is set. Based on the configuration dependency of the kernels, selecting CONFIG_PREEMPT_RT_FULL ensures the presence of the migrate_disable field. Initial bug report [3]. [1] https://marc.info/?l=linux-rt-users&m=153730414126984&w=2 [2] https://marc.info/?l=linux-rt-users&m=153729444223779&w=2 [3] https://lists.lttng.org/pipermail/lttng-dev/2018-September/028216.html Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Jonathan Rajotte	5 years ago
1148	Fix: out of memory error handling Fix: out of memory error handling CPU hotplug handles teardown on failure to complete adding an instance of CPU hotplug. Trying to remove after a failed "add" on that instance triggers a NULL pointer dereference OOPS. Fixes: #1167 Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Mathieu Desnoyers	5 years ago
1147	Fix: uprobes: missing break in lttng_event_ioctl() Fix: uprobes: missing break in lttng_event_ioctl() Found by Coverity: ** CID 1395322: Control flow issues (MISSING_BREAK) /lttng-abi.c: 1465 in lttng_event_ioctl() Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Mathieu Desnoyers	5 years ago
1146	Fix: ACCESS_ONCE was removed in 4.15, use READ_ONCE instead Fix: ACCESS_ONCE was removed in 4.15, use READ_ONCE instead Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Francis Deslauriers	5 years ago
1145	Fix: instruction pointer has different names across arch Fix: instruction pointer has different names across arch Different terms are used to refer to the instruction pointer depending on the CPU architecture. For example: x86 -> ip powerpc -> nip RISC-V -> sepc ARM -> ARM_pc Microblaze -> pc To fix this issue, we use the instruction_pointer() kernel function (or macro depending on the arch) to get the right field in the pt_regs struct for the current architecture. Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Francis Deslauriers	5 years ago
1144	Fix: build failures when CONFIG_UPROBES is absent Fix: build failures when CONFIG_UPROBES is absent Problems ======== - There is a typo in the struct name of the parameters of stub version of the lttng_uprobes_add_callsite function, - We are building the lttng-uprobes.o object file even when CONFIG_UPROBES is absent. Both of these are causing build errors. Fixes ===== - Replace struct lttng_kernel_callsite_uprobe by struct lttng_kernel_event_callsite, - Only add the lttng-uprobes.o object file to the needed artefacts if CONFIG_UPROBES is present. Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Francis Deslauriers	5 years ago
1143	uprobe: Support multiple call sites for the same uprobe even... uprobe: Support multiple call sites for the same uprobe event Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Francis Deslauriers	5 years ago
1142	uprobe: Receive file descriptor from session instead of path... uprobe: Receive file descriptor from session instead of path to file Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Francis Deslauriers	5 years ago
1141	uprobe: Mark uprobe event as registered uprobe: Mark uprobe event as registered Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Francis Deslauriers	5 years ago
1140	Add uprobes support Add uprobes support The added support is basic. It create an event with no data associated to the file path + offset specified. Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com> Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Yannick Brosseau	5 years ago
1139	Fix: adjust SLE version ranges to build with SP2 and SP3 Fix: adjust SLE version ranges to build with SP2 and SP3 The early kernel versions of SuSE 12 SP3 overlap with the range from the later SP2 kernels but are from a different source trees. This patch adds specific ranges for the SP3 kernels that overlap and allows compatibility with both SP2 and SP3 kernels. Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	5 years ago
1138	Fix: Allow alphanumeric characters in SLE version Fix: Allow alphanumeric characters in SLE version Allow alphanumeric characters in the long version string before extracting specific version numbers. This prevents failure in detecting a SuSE kernel when the version string was customized by the end user. Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	5 years ago
1137	Fix: Adjust range for SuSE 4.4.103-92 kernels Fix: Adjust range for SuSE 4.4.103-92 kernels Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	5 years ago
1136	Cleanup: move to kernel style SPDX license identifiers Cleanup: move to kernel style SPDX license identifiers The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. According to kernel documentation it has to be inserted on the first or second line of a file. Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	5 years ago
1135	Cleanup: move scripts to subdirectory Cleanup: move scripts to subdirectory Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	5 years ago
1134	Cleanup: modinfo keys Cleanup: modinfo keys Remove duplicates keys, add missing keys, add missing information and fix the description of some modules. Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	5 years ago

Older »