~lttng/lttng-ust/lttng-ust : changes

~lttng/lttng-ust/lttng-ust » Changes from revision 3059

From Revision 3038 to 3019

Rev	Summary	Authors	Date
3038	fix: invoke MKDIR_P before changing directories fix: invoke MKDIR_P before changing directories In autoconf < 2.72d `AC_PROG_MKDIR_P` may fall back to using `install-sh` and that may be referenced as a relative path. To avoid issues with relative paths causing the command to not be found, the build directories are created before changing the working directory. One way to to test the behaviour prior to this commit is to configure the build similar to the following: ./configure MKDIR_P="$(realpath --relative-to="$(pwd)" \ $(command -v mkdir))" BUILD_EXAMPLES_FROM_TREE=1 Fixes https://bugs.lttng.org/issues/1404 Change-Id: I2d66254cd8c208f9236d55c6ef1b83c580560c7c Signed-off-by: Kienan Stewart <kstewart@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Kienan Stewart	11 months ago
3037	docs: Update contributing guide docs: Update contributing guide Indicate that Gerrit (https://review.lttng.org) is the principal place where patches are submitted and reviewed, rather than the mailing list. Based on feedback received on the mailing list: https://lists.lttng.org/pipermail/lttng-dev/2023-November/030670.html Change-Id: I3543659b0d02ecd672f2c8a45d23975c271628f9 Signed-off-by: Kienan Stewart <kstewart@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Kienan Stewart	11 months ago
3036	Build system: implement REUSE with SPDX identifiers Build system: implement REUSE with SPDX identifiers The SPDX identifiers [1] are a legally binding shorthand, which can be used instead of the full boiler plate text. This is the first step towards implementing the full REUSE spec [2] to help with copyright and licensing audits and compliance. This will reduce a lot a manual work required for the licensing audit required in Debian on each update. For files that lacked copyright and licensing information, I used the following guidelines. If a clear author could be determined from the git history use it, otherwise use 'EfficiOS Inc.'. For build system files, use 'MIT', for documentation 'CC-BY-4.0' and for data files 'CC0-1.0'. Freeform text files were converted to Markdown to allow licensing comments. [1] https://spdx.org/ids-how [2] https://reuse.software/tutorial/ Change-Id: I75f6120ff1241e1f6ea5aac44cd87c89d7fd21e3 Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	11 months ago
3035	Disallow building static librairies Disallow building static librairies We don't officialy support static linking the LTTng-UST tracer, however the autotools build system still allows building static libraries. Make it impossible to build static libraries without modifying the configure.ac script to make it explicit. Adding support for static linking would require a lot of additional testing an also for applications to explicitly call the library constructor. Change-Id: I55d7d9db9fa9c8623305901d085aef1a33286f28 Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	11 months ago
3034	fix: -Wsingle-bit-bitfield-constant-conversion with clang16 fix: -Wsingle-bit-bitfield-constant-conversion with clang16 We get the following warning with Clang 16: lttng-ust-abi.c:558:38: warning: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Wsingle-bit-bitfield-constant-conversion] lttng_chan_buf->priv->parent.tstate = 1; My understanding is that there is no bug because we only check if the values are zero or not, so we can silence the warning by making the variables unsigned. Change-Id: Ic4e02164d5adf4271fa24e5b13e5d320ae19de2e Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	1 year ago
3033	Revert "Add support for LTTNG_UST_HOME" Revert "Add support for LTTNG_UST_HOME" This reverts commit 90d125c709f566f3663bf84677f100134cc618e0. After discussion with Jeremie, we want to introduce two (not one) environment variables: - LTTNG_UST_APP_PATH, - LTTNG_UST_CTL_PATH. to accomodate use-cases where a sessiond within a container is traced by a sessiond in the parent container. In that situation, we want the sessiond in the parent container to access the tracee through the LTTNG_UST_CTL_PATH, without making the unix sockets for tracing control visible to the child container. Therefore, remove the LTTNG_UST_HOME environment variable before it is added into an official release. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Mathieu Desnoyers	1 year ago
3032	Revert "Cleanup: remove leftover comment" Revert "Cleanup: remove leftover comment" This reverts commit 5c0cb615bd9744f061ea318f829e0aa147b05958. Will also revert "Add support for LTTNG_UST_HOME" in a follow up revert. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Mathieu Desnoyers	1 year ago
3031	Cleanup: remove leftover comment Cleanup: remove leftover comment Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Ifd2ead39c7d7ebe9d50ec20b834c81cd4caa5e1d	Mathieu Desnoyers	1 year ago
3030	fix: clean java inner class files in examples fix: clean java inner class files in examples Java classes that contain inner classes will result in additional class files being created when compiled in the form of 'Class$InnerClass.class'. Expand the clean target to delete those additional files. Change-Id: I0ed7939dcaefa5ca26db9438f7a9b34e57d78f21 Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	1 year ago
3029	Cleanup: remove whitespaces at EOL in lttng-ust.pc.in Cleanup: remove whitespaces at EOL in lttng-ust.pc.in Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I1da0f8291929c6638bea44748e6e223ba32b36dc	Mathieu Desnoyers	1 year ago
3028	Add support for LTTNG_UST_HOME Add support for LTTNG_UST_HOME Namespacing the LTTNG_HOME env variable facilitates the work carried to have a way to trace the tracer (lttng-sessiond). This also fits with the work done lately to namespace lttng-ust. The LTTNG_HOME environment variable is used by lttng-sessiond to setup the whole tracing environment for the application to be traced. When lttng-ust is loaded by the lttng-sessiond to be traced, the fact that it reuse the `LTTNG_HOME` set for the lttng-sessiond prevent us from specifying an external lttng-sessiond home. Albeit it could be possible for the lttng-sessiond to "trace" itself (self tracing), it make more sense, in our testing environment, to have a supplementary lttng-sessiond handling the tracing of the lttng-sessiond under testing. Note that some work will be carried to limit the use of LTTNG_HOME to setup the tracing environment by lttng-sessiond and liblttng-ctl APIs but it will be a long effort. Providing `LTTNG_UST_HOME` allows us to start dogfooding today. `LTTNG_HOME` is still used as a fallback to `LTTNG_UST_HOME` to preserve backward compatibility. Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I6aed21fd70d1b79b6768d237f59cc80612938d65	Jonathan Rajotte	1 year ago
3027	Log path used in connection attempts Log path used in connection attempts Motivated by feedback on the lttng-dev mailing list that a user couldn't find the socket path used when debugging connection issues of their UST application. Refs https://bugs.lttng.org/issues/1393 Change-Id: I42c8bb9ae372683a16f176caf87ac394f816955e Signed-off-by: Kienan Stewart <kstewart@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Kienan Stewart	1 year ago
3026	Introduce sync vs unsync enablers Introduce sync vs unsync enablers Eliminate iteration over unmodified enablers when synchronizing the enablers vs event state. The intent is to turn a O(m*n) algorithm (m = number of enablers, n = number of event probes) into a O(n) when enabling many additional events when tracing is active. This change is done both for event enablers and for event notifier enablers. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Ifdadbafbf899ce5f3c5f8eb22409ac0c4af3139c	Mathieu Desnoyers	1 year ago
3025	Fix: misaligned urcu reader accesses Fix: misaligned urcu reader accesses Running the LTTng-tools tests (test_valid_filter, for example) under address sanitizer results in the following warning: /usr/include/lttng/urcu/static/urcu-ust.h:155:6: runtime error: member access within misaligned address 0x7fc45db3a020 for type 'struct lttng_ust_urcu_reader', which requires 128 byte alignment 0x7fc45db3a020: note: pointer points here c4 7f 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ^ While the node member of lttng_ust_urcu_reader has an "aligned" attribute of CAA_CACHE_LINE_SIZE, the compiler can't ensure the alignment of members for dynamically allocated instances. The `data` pointer is changed from char* to struct lttng_ust_urcu_reader*, allowing the compiler to enforce the expected alignment constraints. Since `data` was addressed in bytes, the code using this field is adapted to use element counts. As the chunks are only used to allocate reader instances (and not other types), it makes the code a bit easier to read. Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Ic826cf94444681bea3a192d3a9f4262a0961e948	Jérémie Galarneau	1 year ago
3024	ustfork: Initialize libc pointers in constructor ustfork: Initialize libc pointers in constructor Instead of resolving individual libc functions lazily at their call site, resolve every libc functions in a global constructor. This improve error reporting for the user, by only emiting a single warning for each failed symbol lookup. Change-Id: I47504846e44a68366870b983ff556158e634cf83 Signed-off-by: Olivier Dion <odion@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Olivier Dion	1 year ago
3023	ustfork: Fix warning about volatile qualifier ustfork: Fix warning about volatile qualifier Clang is strict about the volatile qualifier on function pointers. It also wants pointers to be passed to atomic builtins, even for functions. Therefore, use the addresses of function pointers even if unnecessary according to C standard. Change-Id: I5d553a46671cc4bfbe8de5cec2425201459f60d2 Signed-off-by: Olivier Dion <odion@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Olivier Dion	1 year ago
3022	ustfork: Fix possible race conditions ustfork: Fix possible race conditions Assuming that `dlsym(RTLD_NEXT, "symbol")' is invariant for "symbol", then we could think that memory operations on the `plibc_func' pointers can be safely done without atomics. However, consider what would happen if a load to a`plibc_func' pointer is torn apart by the compiler. Then a thread could see: 1) NULL 2) The stored value as returned by a dlsym() call 3) A mix of 1) and 2) The same goes for other optimizations that a compiler is authorized to do (e.g. store tearing, load fusing). One could question whether such race condition is even possible for the clone(2) wrapper. Indeed, a thread must be cloned to get into existence. Therefore, the main thread would always store the value of `plibc_func' at least once before creating the first sibling thread, preventing any possible race condition for this wrapper. However, this assume that the main thread will not call the clone system call directly before calling the libc wrapper! Thus, to be on the safe side, we do the same for the clone wrapper. Fix the race conditions by using the uatomic_read/uatomic_set functions, on access to `plibc_func' pointers. Change-Id: Ic4be25983b8836d2b333f367af9c18d2f6b75879 Signed-off-by: Olivier Dion <odion@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Olivier Dion	1 year ago
3021	Fix: tracepoint: Remove trailing \ at the end of macro Fix: tracepoint: Remove trailing \ at the end of macro Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Ia6dba969704d64d0e31f7d6b3667996101c50f70	Mathieu Desnoyers	1 year ago
3020	Show python agent install output in verbose builds Show python agent install output in verbose builds When running 'make V=1' print the output of the python agent install command to help with debugging. Change-Id: I1c34f1c4302b914fa4c75fbdfbe8527886652565 Signed-off-by: Michael Jeanson <mjeanson@debian.org> Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	1 year ago
3019	fix: python agent: use stdlib distutils when setuptools is i... fix: python agent: use stdlib distutils when setuptools is installed When the setuptools package is installed, it monkey patches the standard library distutils even if the user code doesn't import setuptools. This results in a failure to install the python agent in a directory which ins't in the current PYTHONPATH. To allow this setuptools requires the '--single-version-externally-managed' options which is not implemented in distutils. To resolve this, force the use of distutils for python < 3.12 even when setuptools is installed with the 'SETUPTOOLS_USE_DISTUTILS' environment variable and use the proper setuptools option with python >= 3.12 which doesn't include distutils anymore. Change-Id: Idf477ca61bed460c9f6be7f481fe3b84624f328c Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	1 year ago