~lttng/urcu/trunk : changes

~lttng/urcu/trunk » Changes from revision 1486

From Revision 1374 to 1355

Rev	Summary	Authors	Date
1374	wfcqueue API: implement overloaded wrappers with templates wfcqueue API: implement overloaded wrappers with templates Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I58613298f2d949fa1195efdbb9f452fd97b77eeb	Mathieu Desnoyers	2 years ago
1373	wfcqueue: combine C++ API cds_wfcq_head_cast with overloadin... wfcqueue: combine C++ API cds_wfcq_head_cast with overloading For the sake of wrapper API, implement a cds_wfcq_head_cast_cpp with overloading, thus leaving in place the cds_wfcq_head_cast and __cds_wfcq_head_cast C identifiers already exposed by the C++ API. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Id9781d46290c47b81a57f48fc045b6307c1143de	Mathieu Desnoyers	2 years ago
1372	wfstack C++ API: implement overloaded wrappers with template... wfstack C++ API: implement overloaded wrappers with templates Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Iac57f35ce31972c751d95fac7306e9729e9dfa43	Mathieu Desnoyers	2 years ago
1371	lfstack C++ API: implement overloaded wrappers with template... lfstack C++ API: implement overloaded wrappers with templates Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I1bcfd8f0bab53e30778f7d20e374de750ebdf806	Mathieu Desnoyers	2 years ago
1370	wfstack: combine C++ API cds_wfs_stack_cast with overloading wfstack: combine C++ API cds_wfs_stack_cast with overloading Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I343f85d4fab6bf11f8ed128ee4ebd332f4f3d061	Mathieu Desnoyers	2 years ago
1369	lfstack: combine C++ API cds_lfs_stack_cast with overloading lfstack: combine C++ API cds_lfs_stack_cast with overloading Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I8d9cf79a320f057176972de11e1847076ddb1330	Mathieu Desnoyers	2 years ago
1368	fix: test_build tap plan fix: test_build tap plan Change-Id: I83dc2343fe7c457a1ec0c94ed164c1365fce2bdb Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	2 years ago
1367	Test C++ build of list head init Test C++ build of list head init Signed-off-by: Simon Marchi <simon.marchi@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Iaf7655c8a8e76d004910da14343bbebc4309576e	Simon Marchi	2 years ago
1366	Fix order of initializers in CDS_LIST_HEAD_INIT Fix order of initializers in CDS_LIST_HEAD_INIT When using CDS_LIST_HEAD_INIT in a C++ program, we get (with clang rather than gcc, because the error message is clearer): /home/simark/src/urcu/tests/unit/test_build_cxx.cpp:73:13: error: ISO C++ requires field designators to be specified in declaration order; field 'prev' will be initialized after field 'next' [-Werror,-Wreorder-init-list] .head = CDS_LIST_HEAD_INIT(list.head), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/simark/src/urcu/include/urcu/list.h:49:53: note: expanded from macro 'CDS_LIST_HEAD_INIT' #define CDS_LIST_HEAD_INIT(name) { .prev = &(name), .next = &(name) } ^~~~~~~~~~~~~~~ /home/simark/src/urcu/tests/unit/test_build_cxx.cpp:73:13: note: previous initialization for field 'prev' is here .head = CDS_LIST_HEAD_INIT(list.head), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/simark/src/urcu/include/urcu/list.h:49:44: note: expanded from macro 'CDS_LIST_HEAD_INIT' #define CDS_LIST_HEAD_INIT(name) { .prev = &(name), .next = &(name) } ^~~~~~~ Fix that by swapping the initializers in CDS_LIST_HEAD_INIT. Change-Id: Ib127b9cc128fd64f5b2ae028e093be42ca10f437 Signed-off-by: Simon Marchi <simon.marchi@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Mathieu Desnoyers	2 years ago
1365	unit tests: test wfcqueue, wfstack, lfstack empty check func... unit tests: test wfcqueue, wfstack, lfstack empty check functions in C++ Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I16c2d51872c1007762a6b75aac7a21974b4b9c8b	Mathieu Desnoyers	2 years ago
1364	wfcqueue: implement C++ API based on function overloading wfcqueue: implement C++ API based on function overloading Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I8dbd00e9f2c74e9ee914906afa3e6fdece14fc27	Mathieu Desnoyers	2 years ago
1363	wfstack: implement C++ API based on function overloading wfstack: implement C++ API based on function overloading Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I85d3f7b8b8d390363b55da634bcafe844ef67102	Mathieu Desnoyers	2 years ago
1362	lfstack: implement C++ API based on function overloading lfstack: implement C++ API based on function overloading Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I72967ad460b24f1464394620d68af868340a16ce	Mathieu Desnoyers	2 years ago
1361	Fix tap.h: remove extra semicolon in pass/fail macros Fix tap.h: remove extra semicolon in pass/fail macros Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: Id7df3c04f26932332063b1fed31dc7be80695755	Mathieu Desnoyers	2 years ago
1360	Add C++ build tests Add C++ build tests Some urcu header files cause build failures when included in C++ programs. Add a test file that includes all exported headers (except those that are marked as deprecated) and build that test file as a C and C++ program, with and without _LGPL_SOURCE defined (to test both the static and non-static implementations). This helps ensure that the code in these headers works as both languages. This alone does not ensure full coverage, there may be code in unused macros that would need fixing. But by including the "static" headers, this already finds a few issues. The test doesn't run anything, its purpose is only to verify that things build. This catches the following build failures: - clang++ doesn't know the __transparent_union__ attribute, place some pragmas to ignore this warning around where __transparent_union__ is used. - CDS_WFS_WOULDBLOCK and CDS_WFS_END are cast to a void. This doesn't work in C++ when assigning to a field them to typed pointer. Fix them by casting to the appropriate type. - The transparent union trick doesn't work in C++: CXX test_build_cxx.o In file included from /home/simark/src/urcu/include/urcu/wfstack.h:116, from /home/simark/src/urcu/include/urcu/cds.h:35, from /home/simark/src/urcu/tests/unit/test_build_cxx.cpp:34: /home/simark/src/urcu/include/urcu/static/wfstack.h: In function ‘cds_wfs_node _cds_wfs_pop_with_state_blocking(cds_wfs_stack, int)’: /home/simark/src/urcu/include/urcu/static/wfstack.h:350:54: error: could not convert ‘s’ from ‘cds_wfs_stack’ to ‘cds_wfs_stack_ptr_t’ 350 \| retnode = ___cds_wfs_pop_with_state_blocking(s, state); \| ^ \| \| \| cds_wfs_stack A C++ user can fall back to instantiating a cds_wfs_stack_ptr_t explicitly, assigning the right field, and passing the cds_wfs_stack_ptr_t to the function. Fix a few instances in the static headers. A follow up commit will introduce C++ API wrappers based on function overloading to provide a C++ API similar to the C API. Signed-off-by: Simon Marchi <simon.marchi@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I30adc8df69414a0a019c5ec081f64cfac64843f5	Simon Marchi	2 years ago
1359	Build and run regression and unit tests as C++ programs Build and run regression and unit tests as C++ programs Build and run all tests under tests/regression and tests/unit as C++ programs in addition to C. This helps get confidence that urcu, when used from a C++ program, behaves well. Change-Id: Iacaa42dddbcbf59eff8e327edfd0352cce0b74b7 Signed-off-by: Simon Marchi <simon.marchi@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Simon Marchi	2 years ago
1358	Add --enable-Werror configure switch Add --enable-Werror configure switch Change-Id: I514335a042b962dcb737f03e2c19c2223961b99c Signed-off-by: Simon Marchi <simon.marchi@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Simon Marchi	2 years ago
1357	Add `urcu_posix_assert()` as `assert()` replacement Add `urcu_posix_assert()` as `assert()` replacement This macro acts like the regular `assert()` macro unless NDEBUG is defined in which case it consumes the expression and becomes a no-op. This consumption trick (see `_urcu_use_expression()` macro) prevents the compiler from warning about unused variables even when assert() are removed by the NDEBUG define. This macro is also used for the existing `urcu_assert_debug()` macro. The implementation of `_urcu_use_expression()` is inspired by the Babeltrace 2 approach. See `BT_USE_EXPR()` macro and documentation in Babeltrace commit [1]: commit 1778c2a4134647150b199b2b57130817144446b0 Author: Philippe Proulx <eeppeliteloop@gmail.com> Date: Tue Apr 21 11:15:42 2020 -0400 lib: assign a unique ID to each pre/postcond. and report it on failure All assertion macros are moved to the new urcu/assert.h file. Link: https://github.com/efficios/babeltrace/commit/1778c2a4134647150b199b2b57130817144446b0 [1] Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: If60ce2d3f45ea8f5ec1dbb92fb43f83fd9f8102b	Francis Deslauriers	2 years ago
1356	Rename `urcu_assert()` to `urcu_assert_debug()` Rename `urcu_assert()` to `urcu_assert_debug()` This is done in preparation for the addition of the `urcu_posix_assert()` macro that will replace the vanilla `assert()` in the project. We must continue to expose the `urcu_assert()` macro in the `urcu/debug.h` file as it's used by at least one external project (LTTng-UST). Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Change-Id: I02f237450a35b57e37718c87a0596a5a14468f58	Francis Deslauriers	2 years ago
1355	cleanup: spelling fixes in comments cleanup: spelling fixes in comments Change-Id: I22ae33365d77abeb5f7051882e9d0fa807e38f6f Signed-off-by: Michael Jeanson <mjeanson@efficios.com> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>	Michael Jeanson	2 years ago