2351
|
|
|
mattyw |
|
10 years ago
|
|
|
2350
|
|
|
mattyw |
|
10 years ago
|
|
|
2349
|
|
|
mattyw |
|
10 years ago
|
|
|
2348
|
|
[r=dimitern],[bug=1281577],[bug=1283412] cmd/juju: ssh/scp commands extra arguments; fixes
Removed the extraneous "--" that the ssh command adds to the passed arguments, so any extra arguments after the command will be forwarded to ssh properly. It worked in 1.16, so this fixes a regression. This fixes bug #1281577.
The scp command claims in its help that it supports -- to pass extra arguments to scp, but it does not and also does not support multiple local/remote targets to be specified, as OpenSSH scp command does. This fixes bug #1283412.
Also, improved a lot of ssh-related tests in both utils/ssh/ and in cmd/juju/, adding new tests as needed for the extra arguments.
Improved help texts for ssh, scp and add-machine commands (included examples for the extra args and multiple targets for scp, added ssh: example for add-machine).
All changes are tested live: - bootstrapping on EC2 and running ssh or scp to test extra args and multiple targets; - manual bootstrapping - add-machine ssh:user@host to an existing env; - using juju on Windows, to test the embedded go.crypto ssh command.
https://codereview.appspot.com/66340045/
R=axwalk, gz
|
Dimiter Naydenov |
|
10 years ago
|
|
|
2347
|
|
|
Nate Finch |
|
10 years ago
|
|
|
2346
|
|
|
Curtis Hovey |
|
10 years ago
|
|
|
2345
|
|
|
Dimiter Naydenov |
juju-1.17.3 |
10 years ago
|
|
|
2344
|
|
|
Andrew Wilkins |
|
10 years ago
|
|
|
2343
|
|
|
Ian Booth |
|
10 years ago
|
|
|
2342
|
|
|
Andrew Wilkins |
|
10 years ago
|
|
|
2341
|
|
|
Roger Peppe |
|
10 years ago
|
|
|
2340
|
|
|
Ian Booth |
|
10 years ago
|
|
|
2339
|
|
|
Roger Peppe |
|
10 years ago
|
|
|
2338
|
|
|
Nate Finch |
|
10 years ago
|
|
|
2337
|
|
|
Andrew Wilkins |
|
10 years ago
|
|
|
2336
|
|
|
Andrew Wilkins |
|
10 years ago
|
|
|
2335
|
|
|
Andrew Wilkins |
|
10 years ago
|
|
|
2334
|
|
|
Jesse Meek |
|
10 years ago
|
|
|
2333
|
|
|
Roger Peppe |
|
10 years ago
|
|
|
2332
|
|
|
Ian Booth |
|
10 years ago
|
|
|