~maxiberta/canonical-identity-provider/ssh-key-break-all : changes

~maxiberta/canonical-identity-provider/ssh-key-break-all » Changes from revision 1721

From Revision 1721 to 1702

Rev	Summary	Authors	Date
1721	Prevent extraneous line breaks when showing SSH keys. Prevent extraneous line breaks when showing SSH keys.	Maximiliano Bertacch...	4 years ago
1720	Update home page recently authenticated table to display mor... Update home page recently authenticated table to display more clearly. Also correct grammar of section heading Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/table-header/+merge/378868	Karl Williams	4 years ago
1719	Update vanilla base template to allow full-width headings Update vanilla base template to allow full-width headings Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/heading-style/+merge/378830	Karl Williams	4 years ago
1718	Fixed the styling and content of the tooltip on the "Preferr... Fixed the styling and content of the tooltip on the "Preferred email address" field on the user detail page. Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/email-tooltip/+merge/378758	Karl Williams	4 years ago
1717	Fixed the rendering of error states for the password fields ... Fixed the rendering of error states for the password fields (included modifying the password field generation code to take an optional HTML class parameter) Changed the base template to move global error messages into the main strip, reducing vertical spacing. Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/form-error-states/+merge/378530	Karl Williams	4 years ago
1716	Assorted improvements to the SSH keys form. Assorted improvements to the SSH keys form. - Prevent extraneous line breaks when showing SSH keys. - Improve parsing of SSH keys with multiple white spaces. Merged from https://code.launchpad.net/~maxiberta/canonical-identity-provider/ssh-form-improvements/+merge/378425	Maximiliano Bertacch...	4 years ago
1715	Fixed the display bug on the SSH key form. Fixed the display bug on the SSH key form. Modified the data passed to the form and removed the full HTML generation in favour of explicit validation of the data fields. Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/ssh-form/+merge/377940	Karl Williams	4 years ago
1714	This update hides the Add SSH key form when the user can't i... This update hides the Add SSH key form when the user can't interact with it. Notifications explaining why this is the case have been updated to use a notification rather than the input element's placeholder text. Partial fix for: https://bugs.launchpad.net/canonical-identity-provider/+bug/1859195 Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/ssh-disabled-form/+merge/378171	Karl Williams	4 years ago
1713	Fix /+ubuntuone-account sidebar. Fix /+ubuntuone-account sidebar. Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/u1-account-fix/+merge/377991	Karl Williams	4 years ago
1712	Made the hero section of the template much shallower followi... Made the hero section of the template much shallower following user feedback. Also cleaned up the markup to reduce duplication of the <h1> tag in every sub-template. Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/shallow-hero/+merge/377924	Karl Williams	4 years ago
1711	Update Django from 1.11.16 to 1.11.27 Update Django from 1.11.16 to 1.11.27 Merged from https://code.launchpad.net/~suligap/canonical-identity-provider/django-upgrade-1.11.16-to-1.11.27/+merge/377878	Przemysław Suliga	4 years ago
1710	Fix tests for password reset logging. Fix tests for password reset logging. Fixing the tests made me realize that the actual logging was outputting the numeric value of an account.status enum. I fixed this to use the human-readable status label. The tests formerly included a line that looks like it is intended to assert that the correct logging is done, but is actually a no-op. It calls a non-existent method on a mock, which helpfully provides a no-op callable, which returns without error. Instead, we now explicitly self.assertEqual on the mocks.call_args. Also, the mock_logger in question was not patching the correct thing. Now it is. Also, a few other tests used mock_logger.xxx.assert_called_once_with. These '.assert_xxx' methods on Mock are dangerous. If they are mis-spelled, they will always silently pass. I suggest never using them, and replacing with explicit assertEqual on mock.call_args, as done here. Merged from https://code.launchpad.net/~tartley/canonical-identity-provider/fix-logging-tests/+merge/377647	Jonathan Hartley	4 years ago
1709	Unconditionally error if "not account.can_reset_password" Unconditionally error if "not account.can_reset_password" Don't try to special-case "deactivated" accounts, since we cannot reach this code with that account.status value. Don't special case "suspended" accounts, since that is the only status value which can reach this bit of code. Instead, just unconditionally refuse to send the password reset and return an error. There was a test of special-case for "deactivated" accounts, but to reach that code, the test monkey-patched to create an impossible situation. Without that patching, the test now demonstrates what actually happens (both before this change and after it) - i.e. a deactivated account can send a password reset email. Add a comment about test assertions using mock_logging, which actually do nothing. Fix a few comment typos. Merged from https://code.launchpad.net/~tartley/canonical-identity-provider/rm-deactivated-check/+merge/377387	Jonathan Hartley	4 years ago
1708	Remove code that cannot be reached. Remove code that cannot be reached. The containing 'if not account.can_reset_password', 16 lines up from the deletion, does not check whether there are any validated email addresses. Instead it just checks that account.status must be either Suspended or Deleted. Suspended accounts are handled by an early return, 9 lines up from the deletion. Deleted accounts also delete their associated email addresses, so can not be retrieved by the Account.get_by_email call near the start of this method. There was a test for this deleted code, but it monkey patched a fake value to make this code reachable. I tried replacing the test with one that didn't do monkey patching (e.g. using a deleted account would be the only way) but was unable to make the code reachable. In practice, accounts with no validated email addresses pass right by this code, and end up reading from account.preferredemail, 14 lines below the deletion, which falls back to using a new email address. Merged from https://code.launchpad.net/~tartley/canonical-identity-provider/rm-no-verified-address-para/+merge/377382	Jonathan Hartley	4 years ago
1707	Test fail diagnostics for bad response status code. Test fail diagnostics for bad response status code. If a response has an unexpected status code, display the response content and the expected/actual status codes. Merged from https://code.launchpad.net/~tartley/canonical-identity-provider/status-code-diagnostics/+merge/377377	Jonathan Hartley	4 years ago
1706	Restore users ability to send password reset email to new ad... Restore users ability to send password reset email to new addresses. A branch was merged before Christmas to fix a security hole in the password reset process. In that branch, out of an abundance of caution, we also prevented password reset emails from being sent to 'new' email addresses. https://code.launchpad.net/~tartley/canonical-identity-provider/password-reset/+merge/376991 On reflection, the latter part was more cautious than required. This MP restores the ability for the password reset email logic to fall back to using an account's 'new' email address if no preferred or validated email addresses exist. Merged from https://code.launchpad.net/~tartley/canonical-identity-provider/allow-new-emails/+merge/377333	Jonathan Hartley	4 years ago
1705	Convert all error and logged-in user pages to Vanilla templa... Convert all error and logged-in user pages to Vanilla templates Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/merge-3-user/+merge/375403	Karl Williams	4 years ago
1704	Prevent password reset security problem. Prevent password reset security problem. It's possible for an attacker to request a password reset using a variation on an existing user's email which differs only in case. For ASCII, this makes no difference, but for unicode, different case may constitute a distinct email address. In such a case, it's important we email the password reset token to the user's email which we have stored and validated, rather than the variant of it provided and controlled by the attacker. If a user has no validated email address, we should not send the password reset token to an unvalidated (new) email address, which may not be read or may be controlled by someone else. In this case we refuse to allow password reset. The user can recover from this by validating the email address they provided, or by contacting support as they are prompted to do. Merged from https://code.launchpad.net/~tartley/canonical-identity-provider/password-reset/+merge/376991	Jonathan Hartley	4 years ago
1703	Convert templates for the registration and login flows to Va... Convert templates for the registration and login flows to Vanilla Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/merge-2-registration/+merge/375393	Karl Williams	4 years ago
1702	Update static pages on the site to use a Vanilla-based templ... Update static pages on the site to use a Vanilla-based template. - /+faq - /one-redirect - /+description - /+ubuntuone-account Merged from https://code.launchpad.net/~deadlight/canonical-identity-provider/merge-1-static/+merge/375327	Karl Williams	4 years ago

Older »