~mc-return/compiz/compiz.fix1030473-part4 : changes

~mc-return/compiz/compiz.fix1030473-part4 » Changes from revision 3312

From Revision 3312 to 3293

Rev	Summary	Authors	Date
3312	Changed the int buttonNum to unsigned int buttonNum and chan... Changed the int buttonNum to unsigned int buttonNum and changed "%d" to "%2u", because we do not have negative buttonNums and never more than 99 buttons	MC Return	11 years ago
3311	Added field width specifiers (%5d x2) to "screenshot%d" Added field width specifiers (%5d x2) to "screenshot%d"	MC Return	11 years ago
3310	Added field width specifier " %256s " to sscanf (for variabl... Added field width specifier " %256s " to sscanf (for variable nameTrimmed)	MC Return	11 years ago
3309	Added field width specifiers to " %d " changing them to " %5... Added field width specifiers to " %d " changing them to " %5d " for the int variables vb and vi	MC Return	11 years ago
3308	Added a field width specifier to " %s " changing it to " %25... Added a field width specifier to " %s " changing it to " %256s " to allow a maximum of 256 characters for optNamesValues (is it too much ?)	MC Return	11 years ago
3307	Changed 'int buttonNum;' to 'unsigned int buttonNum;', becau... Changed 'int buttonNum;' to 'unsigned int buttonNum;', because buttonNum should always be positive Changed 'if (sscanf (binding + strlen ("Button"), "%d", &buttonNum) == 1)' to 'if (sscanf (binding + strlen ("Button"), "%2u", &buttonNum) == 1)', because buttonNum should never be higher than 20	MC Return	11 years ago
3306	Changed 'sscanf (token, "screen%d", &screenNum);' to 'sscanf... Changed 'sscanf (token, "screen%d", &screenNum);' to 'sscanf (token, "screen%5u", &screenNum);', adding a field width specifier and changing the type from decimal integer to an unsigned integer (min 0, max 65536)	MC Return	11 years ago
3305	Prevent overflow of name[1024] by adding a field width speci... Prevent overflow of name[1024] by adding a field width specifier (%1023s)	MC Return	11 years ago
3304	Reduced the scope of the variable 'icccm_version', removed a... Reduced the scope of the variable 'icccm_version', removed a break that can never be executed, added the variables 'frameType', 'frameState' and 'frameActions' to decor_quads_to_property in the #else branch in KWD::Switcher::updateWindowProperties () as well and simplified calc_button_size (decor_t *d) in cairo.c.. Fixes: https://bugs.launchpad.net/bugs/1030473. Approved by Daniel van Vugt.	MC Return	11 years ago
3303	bug fix for minor bug 1033085 bug fix for minor bug 1033085 Commands addon desripion typo Buning -> binding. Fixes: https://bugs.launchpad.net/bugs/1033085. Approved by MC Return, Omer Akram.	Keith Madill	11 years ago
3302	Fixed various problems described in bug 1030473. Fixed various problems described in bug 1030473. Optimized performance and style following suggestions reported by cppcheck: 1. Used !xxxx.empty() instead of xxxx.size(), because it can be faster. xxxx.size() can take linear time while xxxx.empty() is guaranteed to take constant time. 2. Defensive programming: Reordered array-out-of-bound condition checks such as '(a[i] && i < 10)' to '(i < 10 && a[i])'. That way the array will not be accessed, because the index is checked first.. Fixes: . Approved by Daniel van Vugt, Sam Spilsbury.	MC Return	11 years ago
3301	Fixed various problems described in bug 1030473. Fixed various problems described in bug 1030473. Optimized performance and style following suggestions reported by cppcheck: 1. Reduced the scope of various variables. 2. Used prefix ++ operators for non-primitive types, because those can be more efficient than post-increment. Post-increment usually keeps a copy of the previous value, adds extra code and is slower.. Fixes: https://bugs.launchpad.net/bugs/1030473. Approved by Daniel van Vugt, Sam Spilsbury.	MC Return	11 years ago
3300	ParseArguments isn't installed, having it around is misleadi... ParseArguments isn't installed, having it around is misleading, move its functionality to CompizCommon which is installed so that we don't cause cascading build failures everywhere else .... Fixes: . Approved by Daniel van Vugt.	Sam Spilsbury	11 years ago
3299	Adds a COVERAGE argument to compiz_discover_tests so clients... Adds a COVERAGE argument to compiz_discover_tests so clients can specify which libraries the tests actually cover (so that coverage reports are correctly generated for our various utility libs). Fixes: . Approved by Daniel van Vugt.	Sam Spilsbury	11 years ago
3298	Added test module for the migration script created by Franci... Added test module for the migration script created by Francis Ginther (big thanks!). Added a check for non-existence of the MUT.. Fixes: . Approved by Daniel van Vugt.	Łukasz 'sil2100' Zem...	11 years ago
3297	Reduces combined filesizes of Compiz' .png resources from 2.... Reduces combined filesizes of Compiz' .png resources from 2.2MB to 1.5MB by recompression of those with Trimage Image Compressor. This will decrease package size, downloading/loading/displaying times without changing appearance in any way, because png is a lossless format and this commit just optimizes compression and filesizes. png files with higher compression take less time to display, not only because of reduced loading times, but also because deflation in memory finishes faster as decompression speed is largely uninfluenced by the compression level and thus decompression of better compressed png files is faster.. Fixes: . Approved by Daniel van Vugt, Sam Spilsbury.	MC Return	11 years ago
3296	Fixed: schemas were getting installed to ${DESTDIR} twice, e... Fixed: schemas were getting installed to ${DESTDIR} twice, eg ${DESTDIR}${DESTDIR}${CMAKE_INSTALL_PREFIX}. Fixes: . Approved by Daniel van Vugt.	smspillaz	11 years ago
3295	Install the cmake helper macros and check for them in COMPIZ... Install the cmake helper macros and check for them in COMPIZ_CMAKE_MODULE_PATH (LP: #1024179). Fixes: https://bugs.launchpad.net/bugs/1024179, https://bugs.launchpad.net/bugs/1030176. Approved by Daniel van Vugt.	Sam Spilsbury	11 years ago
3294	Fix incorrect shell expansion, leading to invalid "sed" synt... Fix incorrect shell expansion, leading to invalid "sed" syntax (LP: #1029383). Fixes: https://bugs.launchpad.net/bugs/1029383. Approved by Sam Spilsbury.	Daniel van Vugt	11 years ago
3293	Fixed CompTimerTestCallback.TimerOrder failure on slow syste... Fixed CompTimerTestCallback.TimerOrder failure on slow systems (like valgrind) (LP: #1021139) If the environment (like valgrind in ExperimentalMemCheck) is so slow that it took more than 50ms to schedule the tests, then they would all be overdue on startup (instead of just one of them) and the order would not be predictable. So I spread the timers out over longer intervals and reduced the number of repetitions to stop the new test from taking too long.. Fixes: https://bugs.launchpad.net/bugs/1021139. Approved by jenkins, Sam Spilsbury.	Daniel van Vugt	11 years ago

Older »