Viewing all changes in revision 3561.
- Committer: Tarmac
- Date: 2013-01-12 11:22:36 UTC
- mfrom: (3554.3.1 fix-1098185)
- Revision ID: tarmac-20130112112236-7gx3us5h6yilfen6
Animation: Correctly specify the events an effect can be used with.
If AnimEffectUsedFor::none() is called, the effect will be marked to
be used with ALL events instead of NONE. This causes crashes if the
chosen random effect is not compatible with the triggering event.
For example dodge effect as random minimize animation causes segfault
as it's only supposed to be a focus in/out animation. Fixes: https://bugs.launchpad.net/bugs/1048840, https://bugs.launchpad.net/bugs/1098185.
Approved by Brandon Schaefer, Sam Spilsbury.
If AnimEffectUsedFor::none() is called, the effect will be marked to
be used with ALL events instead of NONE. This causes crashes if the
chosen random effect is not compatible with the triggering event.
For example dodge effect as random minimize animation causes segfault
as it's only supposed to be a focus in/out animation. Fixes: https://bugs.launchpad.net/bugs/1048840, https://bugs.launchpad.net/bugs/1098185.
Approved by Brandon Schaefer, Sam Spilsbury.
- files modified:
- plugins/animation/src/animation.cpp
expand all
collapse all
added
removed
