~mc-return/compiz/compiz.merge-src-header-files-cleanup : changes

~mc-return/compiz/compiz.merge-src-header-files-cleanup » Changes from revision 3728

From Revision 3703 to 3684

Rev	Summary	Authors	Date
3703	Scale Addons code cleanup: Scale Addons code cleanup: Always bail out of functions ASAP, do not calculate unnecessary stuff before. Merged if-condition checks. Declaration and assignment of local variables in one line. Reduced the scope of some variables. Use pre- instead of postfix in- and decrements. Added and removed newlines where appropriate. Added brackets to foreach macro loops and removed them otherwise (if redundant). Fixed indentation. Note: This plugin has a huge chunk of code, which has been commented out. (apparantly/according to the comment, because it does not work) I was very cautious in refactoring this part of the code, as it currently is excluded from compilation and thus cannot be tested. TODO: Test, repair and integrate this code (or remove it if it is redundant). TODO: Fix half-broken "Exit Scale On Pull". TODO: Fix the scale-will-only-terminate-if-initiate_key-is-defined bug. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3702	gtk/, include/, kde/: gtk/, include/, kde/: Use prefix instead of postfix de- and increments. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3701	Ring Switcher, new feature: Ring Switcher, new feature: Implemented "Vertical Offset" option with a default of 50 pixels. This allows the CCSM user to easily and exactly configure where the window title text should be displayed. Ring Switcher, cleanup: Simplified RingWindow::compareRingWindowDepth (...). Bail out of functions ASAP, do not initialize anything you do not need, if you exit anyway. Merged if condition checks. Declaration and assignment of local variables in one line. Removed redundant brackets. Added and removed newlines, if appropriate. Fixed indentation. (LP: #1173684). Fixes: https://bugs.launchpad.net/bugs/1173684. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3700	compizconfig/, libdecoration/: compizconfig/, libdecoration/: Use prefix instead of postfix de- and increments. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3699	Expo plugin: Expo plugin: Fixed inactive viewports saturation setting being ignored. Let's "fade to grey"... :) (LP: #1179183). Fixes: https://bugs.launchpad.net/bugs/1179183. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3698	OpenGL Screen: Ignore the MSAA configs during initialization OpenGL Screen: Ignore the MSAA configs during initialization This fixes a crash with new MESA drivers and high monitor resolutions caused by the fact that we're accidentally using some MSAA configs with some drivers in Mesa 9.0. Taking in account the values of GLX_SAMPLES and GLX_SAMPLE_BUFFERS fixes the issue. See mesa bug https://bugs.freedesktop.org/show_bug.cgi?id=61182. Fixes: https://bugs.launchpad.net/bugs/1174495. Approved by PS Jenkins bot, Sam Spilsbury, MC Return.	Marco Trevisan (Trev...	11 years ago
3697	Removed redundant Expo configuration changes from ubuntu-con... Removed redundant Expo configuration changes from ubuntu-config.patch: The reflection scale change, because reflection is disabled by default anyway. The inactive viewport saturation change from 100.0% to 40.0%, because this option does not work (and never did AFAICR), but if it finally gets fixed Expo's look would dramatically change. (LP: #1178965). Fixes: https://bugs.launchpad.net/bugs/1178965. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3696	Use XIDefineCursor rather than XDefineCursor. Use XIDefineCursor rather than XDefineCursor. compiz should show a busy cursor during the application startup stage. the corresponding code is in scr/screen.cpp: cps::StartupSequenceImpl::updateStateFeedback () the patch changes all XDefineCursor to XIDefineCursor (see XInput2 extension) (LP: #1179155). Fixes: https://bugs.launchpad.net/bugs/1179155. Approved by PS Jenkins bot, Sam Spilsbury.	stevenhooke11 at gma...	11 years ago
3695	Ring, Shift and Stack Window Switcher: Ring, Shift and Stack Window Switcher: Increased the non-power-of-2 icon texture resolution from 96x96 to 512x512 pixels, in the case of the ring switcher from 64 to 512. Static Switcher: Replaced #define of MAX_ICON_SIZE with type-safe extern const unsigned short and set the icon resolution to 512 as well. Compiztoolbox: Increased the non-power-of-2 icon texture resolution const unsigned short ICON_SIZE from 48 to 512 and const unsigned int MAX_ICON_SIZE from 256 to 512 as well. Changed the type of MAX_ICON_SIZE from const unsigned int to const unsigned short. Scale: Increased the non-power-of-2 icon texture resolution from 96x96 to 512x512 pixels. KDE Compatibility: Increased the icon texture resolution from 256x256 to 512x512 pixels. (LP: #1173914). Fixes: https://bugs.launchpad.net/bugs/1173914. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3694	Try to launch tests on another server if there's tests runni... Try to launch tests on another server if there's tests running in parallel. Provide our own compiz_xorg_gtest_main and subclass xorg::testing::Environment to try and launch tests on another display if there's tests running on one already. This isn't by any means perfect - there are still race conditions surrounding XOpenDisplay and parallel test runs but it makes a more smaller time gap for conditions such as: 1. Client has a server grab on the display we're checking and won't let go. 2. Two servers get launched on one port and one set of tests interfere with the other. It also means that we're now unable to configure the display port, log file and config file on the command line. But we weren't using that anyways. Finally, the logs now point to /tmp/Compiz.Xorg.GTest.displaynum.log (LP: #1178514). Fixes: https://bugs.launchpad.net/bugs/1178514. Approved by Sam Spilsbury, PS Jenkins bot, MC Return.	Sam Spilsbury	11 years ago
3693	Wobbly Windows, code cleanup: Wobbly Windows, code cleanup: Declaration and assignment of local variables in one line. Merged if statements. Removed redundant brackets. Added missing break. Removed and added newlines for better readability. Fixed indentation. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3692	Resize, minor code cleanup: Resize, minor code cleanup: Declaration and assignment of local variables in one line. Added and removed newlines, if appropriate. Removed redundant brackets. Indentation fixes. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3691	Added "move window to previous monitor" feature to compiz Pu... Added "move window to previous monitor" feature to compiz Put plugin. Fixes: https://bugs.launchpad.net/bugs/1178581. Approved by PS Jenkins bot, MC Return, Mehrdad Afshari, Sam Spilsbury.	Mehrdad Afshari	11 years ago
3690	Grid, code changes and fixes: Grid, code changes and fixes: Fixed segfault in Compiz when unchecking "Snap windows back to original size". This option now fully works and will snap back windows to current size, if they are dragged off via mouse. Fixed segfault in Compiz when unchecking "Snapoff Maximized/Semi-maximized Windows" - this option is now removed as this setting is configurable via "Move" plugin already. The snapoff threshold global setting is now configurable instead of hardcoded. Fixed broken cursor y-coordinate calculation. Fixed window placement cursor calculation for non-original-size-restored windows. Make sure grid-maximizing will never overwrite the windows' original size. Removed useless code until someone can convince me that we need it (LP: #1020857). This fixes the weird positioning (50, 50) when restoring mouse-grid-maximized windows via keyboard. Added missing ABI checks of OpenGL and Composite. Grid, xml changes and fixes: Put Corners/Edges setting into own tab. New tab named "Resize Actions". Removed hardcoded SNAPOFF_THRESHOLD and made it configurable. Improved tooltips. Re-applied the quilt patch to the changed grid.xml.in. Changed the put_restore_key to "Ctrl+Super+Down" to fix restoring of grid-maximized windows for Ubuntu as well. (LP: #1172641) Grid, minor code cleanup: Removed redundant (int) casts. Improved readability for the if condition checks. Added and removed newlines, if appropriate. Added comments. Indentation fixes. (LP: #745159, LP: #1020857, LP: #1172641). Fixes: https://bugs.launchpad.net/bugs/745159, https://bugs.launchpad.net/bugs/1020857, https://bugs.launchpad.net/bugs/1172641. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3689	Improved and optimized ABI logic checks consistently for all... Improved and optimized ABI logic checks consistently for all plugins. (LP: #1178228). Fixes: https://bugs.launchpad.net/bugs/1178228. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3688	Opacity, Brightness and Saturation (obs) code cleanup: Opacity, Brightness and Saturation (obs) code cleanup: Replaced #define MODIFIER_COUNT 3 with const unsigned short MODIFIER_COUNT = 3; (the variable MODIFIER_COUNT is needed in obs.h and obs.cpp). Use prefix instead of postfix increment. Merged if condition checks. Declaration and assignment of local variables in one line. Removed redundant brackets. Added and removed newlines if appropriate. Indentation fixes. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3687	Opacity, Brightness and Saturation (obs) .xml cleanup: Opacity, Brightness and Saturation (obs) .xml cleanup: Better plugin description. Improved setting names and tooltips. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3686	Fixed issue where minimizing an unredirect full screen windo... Fixed issue where minimizing an unredirect full screen window would repaint the full screen window after minimizing it even though it isn't really there. . Fixes: https://bugs.launchpad.net/bugs/1053895. Approved by PS Jenkins bot, Sam Spilsbury.	Chris Townsend	11 years ago
3685	Shift Window Switcher, new features: Shift Window Switcher, new features: Implemented new option to adjust the vertical offset of the text placement and fixed vertical placement calculation for top and bottom positions. The default offset is 50 pixels now. Removed hardcoded and redundant float border. Use 256x256 pixels resolution for icon textures, instead of 96x96. Minor indentation fixes. (LP: #1173684). Fixes: https://bugs.launchpad.net/bugs/1173684. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago
3684	Ring Switcher .xml cleanup: Ring Switcher .xml cleanup: Better description of the "Ring Switcher". Uppercase for titles. More precise names for the tabs. Improved tooltip wording and descriptions. Changed the order of options in "General Options" tab: "Ring Windows" and "Overlay Icon" options are now on top. No settings have been changed. Approved by PS Jenkins bot, Sam Spilsbury.	MC Return	11 years ago