~mwhudson/juju-core/gccgo-reflection-fun : changes

~mwhudson/juju-core/gccgo-reflection-fun » Changes from revision 2076

From Revision 2076 to 2057

Rev	Summary	Authors	Date
2076	another workaround field another workaround field	Michael Hudson-Doyle	10 years ago
2075	add workaround fields add workaround fields	Michael Hudson-Doyle	10 years ago
2074	discard methods taking or returning empty structures discard methods taking or returning empty structures	Michael Hudson-Doyle	10 years ago
2073	[r=wallyworld] Hook up container setup logic [r=wallyworld] Hook up container setup logic The main focus of this branch is to wore up the logic to intialise container infrastructure when they are first provisioned. Right now, that means apt-get install any required packages, but that may expand to include downloading/sync images etc. A new container.Initialisation interface is created, with implementations for lxc and kvm. This allows the current simple package install logic to be expanded later. The lxc package install in cloudinit is removed since it is no longer needed there. The provisioner worker has been tweaked to add in kvm support (but waiting on kvm broker). Some test code was moved from the apt util to testbase to that the apt cmd output could be captured in several tests. https://codereview.appspot.com/22980045/	Ian Booth	10 years ago
2072	[r=wallyworld] Container provisioners are not started until ... [r=wallyworld] Container provisioners are not started until needed. The machine agent established what container types are supported on a given host and starts watchers which trigger when the first container of that type is requested. At that point, the provisoner is started. This is the first in a series of changes which will also need the container dependencies be installed on an as required basis and other work done to improve container provisioning. https://codereview.appspot.com/25040043/	Ian Booth	10 years ago
2071	[r=themue],[bug=1193244] switch: more script friendly output [r=themue],[bug=1193244] switch: more script friendly output Changed switch command to more script friendly output. Branch has been newly created after an error when reverting. https://codereview.appspot.com/15080044/	Frank Mueller	10 years ago
2070	[r=adeuring],[bug=1245427] avoid the term 'service' in juju ... [r=adeuring],[bug=1245427] avoid the term 'service' in juju ssh -h	Abel Deuring	10 years ago
2069	[r=axwalk],[bug=1236691] Providers are responsible for selec... [r=axwalk],[bug=1236691] Providers are responsible for selecting tools This change makes providers responsible for selecting bootstrap tools, and ensuring they are available in storage. The null provider is updated to select the tools appropriate to the bootstrap host. Other providers use a default implementation in environs/bootstrap, which has been extracted from cmd/juju/bootstrap.go. One test fails due to a logging change. This is fixed by https://codereview.appspot.com/14430064/. Fixes #1236691 https://codereview.appspot.com/14433058/	Andrew Wilkins	10 years ago
2068	[r=rogpeppe] state: create stateServers document [r=rogpeppe] state: create stateServers document There's no way for it to change currently, and it will be out of date the moment anyone adds or removes a machine with a state server job, but that will come in subsequent CLs, where we'll implement EnsureAvailability and remove the jobs argument from AddMachine and friends.	Roger Peppe	10 years ago
2067	[r=sinzui],[bug=1251711] Restore YAML block and flow interpr... [r=sinzui],[bug=1251711] Restore YAML block and flow interpretation. Update the goyaml dep to r50 so that --- and ... can have text following them.	Curtis Hovey	10 years ago
2066	[r=fwereade] cmd/juju: destroy-machine lacked -e flag [r=fwereade] cmd/juju: destroy-machine lacked -e flag https://codereview.appspot.com/26870043/	William Reade	10 years ago
2065	[r=axwalk] Refactor environs/{cloudinit,manual} [r=axwalk] Refactor environs/{cloudinit,manual} environs/cloudinit has been modified to have two sub-Configure methods: ConfigureBase and ConfigureJuju. The former initialises a cloud-init config to setup a base OS with SSH keys; the latter does the rest. environs/manual has been modified to expose provisionMachineAgent (now with a capital P), which now just takes a hostname and *cloudinit.MachineConfig. We will use this later to install machine agents into cloud images. https://codereview.appspot.com/26570047/	Andrew Wilkins	10 years ago
2064	[r=wallyworld] AddSupportedContainers on provisioner machine... [r=wallyworld] AddSupportedContainers on provisioner machine api The AddSupportedContainers api on the provisioner.Machine will be used by future changes to machine agent initialisation. A change was also made to the server side implementation so that the machine doc txn-revno is no longer checked. It was causing issues with multi-threaded tests where different fields in the machine doc were being updated. The machine agent initialisation thread is the only one that updates the supported containers set. https://codereview.appspot.com/25480047/	Ian Booth	10 years ago
2063	[r=sinzui],[bug=1251279] Fix delimiter in dependencies.tsv [r=sinzui],[bug=1251279] Fix delimiter in dependencies.tsv Developers and CI cannot update the source to the correct deps because spaces are used on the goyaml line. The delimiter must be tabs.	Curtis Hovey	10 years ago
2062	[r=wallyworld],[bug=1250974] Fix handling of deprecated tool... [r=wallyworld],[bug=1250974] Fix handling of deprecated tools-url The branch ensures that regardless of which combination of tools-url and tool-metadata-url values are in the environment.yaml, the constructed config struct has both tools-url and tools-metadata-url attributes, both of which are set to the first non-empty value of, in order of precedence: 1. tools-metadata-url 2. tools-url This ensures the config passed to older nodes during an upgrade still contains the older tools-url that those nodes rely on. https://codereview.appspot.com/26550043/	Ian Booth	10 years ago
2061	[r=jameinel] state/apiserver: change log arrow [r=jameinel] state/apiserver: change log arrow When we switched to the RequestNotifier pattern, we accidentally made both requests and responses use "<-" rather than "->" for reponses. I was digging through some 1.16 logs and noticed the difference. So this just updates the code for that. Should be pretty trivial. https://codereview.appspot.com/26470043/	John Arbash Meinel	10 years ago
2060	[r=dimitern],[bug=1233451] cmd/juju: upgrade-juju minor vers... [r=dimitern],[bug=1233451] cmd/juju: upgrade-juju minor version upgrades This changes a few things needed to fix lp:1233451: * --dev flag is removed, as the logic changed, see below; * default behavior, when --version is not specified now tries to upgrade to the next stable (major.minor+2) version first, failing that will try the most recent current version; * development flags in the environment config, or the client's development version is not used to decide whether to pick a development version for upgrade: the only way to upgrade to a development version now is by using --version only (even if the current one is dev); * improved tests, removed the (not redundant) public storage, as it's not used anymore; * explicit --version overrides the behavior described above and effectively forces and upgrade to the given version, regardless if it's supported (no warning). * when changing the agent-version in the environment, the new SetEnvironAgentVersion is used, to ensure all agents are running the same version first, so that partial upgrades will be detected and reported. All this is needed to ensure we can do proper upgrades to the next/current supported version properly and is required before we can convert upgrade-juju to use the API. https://codereview.appspot.com/25080043/ R=fwereade	Dimiter Naydenov	10 years ago
2059	[r=dave-cheney] Update dependencies.tsv [r=dave-cheney] Update dependencies.tsv Pickup fixes for LP #1227952 Also needs to be backported to 1.16 for 1.16.4	Dave Cheney	10 years ago
2058	[r=jameinel],[bug=1250750] environs/config.go: defer config.... [r=jameinel],[bug=1250750] environs/config.go: defer config.New until needed We want to allow you to have configuration in environments.yaml which may be for another version of juju (python-juju) or older/newer versions of juju-core. We currently 'support' it by parsing everything, and just saving the errors and not reporting them until we actually ask for that entry. However, the recent deprecation of 'tools-url' is using Warnings rather than Errors (which is perfectly reasonable for a deprecation warning). And these were getting generated as soon as we called config.New(). tools-url is slightly special because it is a global config, so it was validated in the common config.Validate() rather than during config.ValidateUnknowns() which is how we handled other unknown fields. (But that is triggered directly be the concrete Config.Validate() vs the thing we were doing on every entry in environs.) This changes the code so that we still parse that it is valid yaml, mostly because we need to get the names of everything. However, we don't actually call config.New() until we actually call Environs.Config(name). I went with a test that we don't have any Warnings until late, which exposes the bug, but it is pretty specific to tools-url because that is currently the only thing that was generating a Warning. If there is a better way to do more generic testing I'd be happy to use it. (Create a test-specific deprecated global field doesn't sound great.) I filed http://pad.lv/1250750 to track this. https://codereview.appspot.com/25910043/	John Arbash Meinel	10 years ago
2057	[r=jameinel],[bug=1250149] typo: Fix a typo in a warning [r=jameinel],[bug=1250149] typo: Fix a typo in a warning We accidentally had "% should" rather than something like "%s should". I went with "%q should" because that matched how we wrote the other variable eariler in the message. https://codereview.appspot.com/25900043/	John Arbash Meinel	10 years ago

Older »