Viewing all changes in revision 366.
- Committer: Geert Vanderkelen
- Date: 2012-12-04 21:08:36 UTC
- Revision ID: geert.vanderkelen@oracle.com-20121204210836-r3sh4nsmi3xpbkr4
BUG#14829471: Fix reading incomplete MySQL packets headers
Previously, we were reading the MySQL packet headers as
4 (or 7) bytes long buffers from the socket. When we did have
the correct length, we would immediately raise an exception.
We now keep reading data from the socket until we got the
full header or bail out on errors.
The BaseMySQLSocket.recv() has been refactored a bit to be
more clear how it works and comments were added.
No test case for bug #14829471 is needed since almost all
other tests are using the changed code.
Previously, we were reading the MySQL packet headers as
4 (or 7) bytes long buffers from the socket. When we did have
the correct length, we would immediately raise an exception.
We now keep reading data from the socket until we got the
full header or bail out on errors.
The BaseMySQLSocket.recv() has been refactored a bit to be
more clear how it works and comments were added.
No test case for bug #14829471 is needed since almost all
other tests are using the changed code.
expand all
collapse all
added
removed
