1599
|
|
|
Mirco Müller |
|
9 years ago
|
|
|
1598
|
|
|
handsome_feng |
|
9 years ago
|
|
|
1597
|
|
|
Daniel d'Andrada |
|
9 years ago
|
|
|
1596
|
|
|
Michael Zanetti |
|
9 years ago
|
|
|
1595
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|
1594
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|
1593
|
|
|
CI Train Bot |
8.02+15.04.20150205-0ubuntu1 |
9 years ago
|
|
|
1592
|
|
Don't accept multiple "Finish" clicks during the last step of the wizard
Doing so can cause password-setting to be left in an inconsistent state. Here's how that happens:
A) User clicks Finish multiple times, queuing up multiple input events (queued because Finish makes some blocking calls). B) The first Finish starts, let's say it's called with new password "1111" and type "passcode". The current password is "" with a type of "swipe". C) The first Finish completes, having set the password correctly to 1111/passcode. D) The second Finish starts. Also called with "1111/passcode". But it still thinks the current type is "swipe" because it takes a moment for AccountsService to update itself. E) The second Finish first changes the display mode hint to "passcode" F) Then the second Finish can't change the password because it's trying to authenticate using "" when the password is actually "1111" now. G) So the second Finish enters the "error mode cleanup" stage and tries to revert its display mode hint change from step E. But it's reverting to what it thought the previous type was -- "swipe" -- which uses the "passphrase" hint behind the scenes (instead of "passcode")
Some possible solutions to this: - Cache the password type locally instead of waiting for AccountsService to update (not a bad idea, but would be done in ubuntu-system-settings, not unity8) - Don't let the user click the Finish button twice. This seems like a no-brainer that should be done anyway. This would also avoid the whole problem.
To reproduce this bug / test this fix, enable the wizard, enter adb, run "sudo passwd -d phablet", reboot, then go through the wizard but just keep spamming that final Finish button. You'll also notice some slow down because it's trying to do all those Finish operations. Fixes: #1414762 Approved by: Albert Astals Cid
|
Michael Terry |
|
9 years ago
|
|
|
1591
|
|
|
Andrea Cimitan |
|
9 years ago
|
|
|
1590
|
|
|
Daniel d'Andrada |
|
9 years ago
|
|
|
1589
|
|
|
Andrea Cimitan |
|
9 years ago
|
|
|
1588
|
|
|
Albert Astals |
|
9 years ago
|
|
|
1587
|
|
|
Daniel d'Andrada |
|
9 years ago
|
|
|
1586
|
|
|
Daniel d'Andrada |
|
9 years ago
|
|
|
1585
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|
1584
|
|
|
Michał Sawicz |
|
9 years ago
|
|
|
1583
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|
1582
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|
1581
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|
1580
|
|
|
Launchpad Translatio... |
|
9 years ago
|
|
|