~neon/juk/master : changes

~neon/juk/master » Changes from revision 2591

From Revision 2590 to 2571

Rev	Summary	Authors	Date
2590	mpris: Don't toggle playback with "Pause". mpris: Don't toggle playback with "Pause". We already have a separate playPause action for this, both in the MPRIS2 DBus adaptor, and in PlayerManager. This also fixes playback resuming when the computer is suspended (Plasma sends the "Pause" command to each media player regardless of whether it's playing, and JuK incorrectly treats that as a request to toggle playback). BUG:381271 FIXED-IN:18.04	Michael Pyne	6 years ago
2589	Remove ancient Exec= key from .desktop file. Remove ancient Exec= key from .desktop file. Should allow JuK to start on Wayland. Should also allow arguments to be passed to JuK (which in theory supports loading files from command line). I ask for URLs to be passed (%U) instead of files (%F) to avoid over-eager file managers or desktops trying to download music files to a temp directory and then deleting them once JuK is done. GUI: BUG:391354 FIXED-IN:18.04	Michael Pyne	6 years ago
2588	Enable the standard "show menu bar" action. Enable the standard "show menu bar" action. As nicely requested in bug 391308. BUG:391308 FIXED-IN:18.04	Michael Pyne	6 years ago
2587	SVN_SILENT made messages (.desktop file) - always resolve ou... SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"	l10n daemon script	6 years ago
2586	GIT_SILENT made messages (after extraction) GIT_SILENT made messages (after extraction)	l10n daemon script	6 years ago
2585	SVN_SILENT made messages (.desktop file) - always resolve ou... SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"	l10n daemon script	6 years ago
2584	GIT_SILENT made messages (after extraction) GIT_SILENT made messages (after extraction)	l10n daemon script	6 years ago
2583	Merge remote-tracking branch 'origin/Applications/17.12' Merge remote-tracking branch 'origin/Applications/17.12'	Michael Pyne	6 years ago
2582	GIT_SILENT modernize some comments. GIT_SILENT modernize some comments.	Michael Pyne	6 years ago
2581	Bring back a visual indication of the playing item. Bring back a visual indication of the playing item. Turned out to be surprisingly more difficult than I thought, so hopefully no additional bugs. In particular some Phonon backends seem to insert a trip to a StoppedState when changing the MediaObject's current source, so I had to find a way around that to be able to call Playlist::stop() from PlaylistCollection (which is what actually clears the visual indication when playback stops).	Michael Pyne	6 years ago
2580	Micro-optimization: use uniform row heights for minor speedu... Micro-optimization: use uniform row heights for minor speedup.	Michael Pyne	6 years ago
2579	Remove dead code for visible column signal/slots. Remove dead code for visible column signal/slots.	Michael Pyne	6 years ago
2578	More column-handling bugfixes in Playlist. More column-handling bugfixes in Playlist. - The showColumn/hideColumn functions work on visual indices, not logical indices, so converting a visual index to a logical one is both wrong and extra work. - The "Show Columns" menu was just flatly checking every column, even the ones that weren't shown.	Michael Pyne	6 years ago
2577	Bring back playing current item from keyboard. Bring back playing current item from keyboard.	Michael Pyne	6 years ago
2576	Extract Playlist::SharedSettings into a separate file. Extract Playlist::SharedSettings into a separate file. This helps declutter playlist.cpp and even makes it seem a bit easier to read through, I think. I also tried to fix a couple of outstanding bugs along the way, for instance reordering columns should work now, although there's still a lot of improvements that need to be made here.	Michael Pyne	6 years ago
2575	GIT_SILENT Remove stray comment from previously-killed code. GIT_SILENT Remove stray comment from previously-killed code.	Michael Pyne	6 years ago
2574	Remove the 'emitChanged' hack in Playlist::createItem<> Remove the 'emitChanged' hack in Playlist::createItem<> Whichever code is creating these items is in the best spot to know whether there will be one or many of these items and when the best time is to permit the playlist to sync up afterwards. This permits the createItem functions to focus more on just that function.	Michael Pyne	6 years ago
2573	Stop playback before taking shutdown actions. Stop playback before taking shutdown actions. This seems to prevent a gstreamer deadlock I sometimes get when trying to quit, though it's only a guess as to whether this is the cause or not.	Michael Pyne	6 years ago
2572	Remove FileHandle::null concept and manual memory mgmt. Remove FileHandle::null concept and manual memory mgmt. On second thought the whole FileHandle::null thing seems silly now. It made sense as an optimization when it was introduced but the extra conceptual baggage is hard to maintain and far less important now.	Michael Pyne	6 years ago
2571	Have FileHandle::isNull check for empty filenames. Have FileHandle::isNull check for empty filenames. This may have worked back in Qt 3 times but this appears to be the source of the common JuK complaint about "trying to add an empty file" (which seems to be related to the Now Playing widget trying to show tags for what it thinks is a valid FileHandle).	Michael Pyne	6 years ago

Older »