~neon/juk/master

  • Committer: Michael Pyne
  • Date: 2011-04-25 02:38:05 UTC
  • Revision ID: git-v1:d8b7228ca1c3eaaf835e0ad662035d711866d6a2
Refresh tag editor if collection is updated while visible.

The indefatigable Giorgos Kylafas managed to troubleshoot the cause of a bug
where the Tag Editor's artist, genre, and track name fields would be reset to
the first item in the respective combo boxes after the collection was updated,
although this behavior only occurred if the tag editor was visible when it
happened.

I would say this should have tipped me off, but I haven't had enough time for
JuK recently so honestly I haven't looked at it. Giorgos has, however, and I
can confirm he tracked down the issue correctly and fixed it.

Going through the bugs seems to indicate this might be the cause of 271054
(JuK tag guesser works improperly if tag editor is open), which I believe is
caused the the tag editor being updated when the file renamer operates,
immediately updating the relevant fields to the wrong values and (somehow?)
then saving those changes.

This commit is against trunk, I will backport to 4.6.3.

CCBUG:271054
CCMAIL:gekylafas@gmail.com

svn path=/trunk/KDE/kdemultimedia/juk/; revision=1229044
Filename Latest Rev Last Changed Committer Comment Size
..
doc 1 22 years ago Scott Wheeler initial import for the JuK branch -- JuK is a KDE Diff
pics 2 22 years ago Scott Wheeler initial import for the JuK branch -- JuK is a KDE Diff
tests 1801 17 years ago Andreas Pakulat Prepare a change in the kde test macros by moving Diff
actioncollection.cpp 2093 15 years ago Michael Pyne Take advantage of dfaure's kdelibs feature to dyna 1.5 KB Diff Download File
actioncollection.h 1791 17 years ago Michael Pyne Fairly large overhaul of the JuK codebase to beat 1.5 KB Diff Download File
advancedsearchdialog.cpp 2175 14 years ago Laurent Montel Start to compile with "-DQT_NO_CAST_FROM_ASCII-DQT 6.4 KB Diff Download File
advancedsearchdialog.h 1884 16 years ago Michael Pyne Fix crash in the search playlist dialog. svn path 2.1 KB Diff Download File
cache.cpp 2093 15 years ago Michael Pyne Take advantage of dfaure's kdelibs feature to dyna 11.4 KB Diff Download File
cache.h 1893 16 years ago Michael Pyne Fix binary incompatible loading of JuK's playlists 2 KB Diff Download File
categoryreaderinterface.cpp 2034 15 years ago Michael Pyne Fix handling of empty tags in the file renamer, th 2.4 KB Diff Download File
categoryreaderinterface.h 1791 17 years ago Michael Pyne Fairly large overhaul of the JuK codebase to beat 4.2 KB Diff Download File
CMakeLists.txt 2178 13 years ago David Faure Make executable the Type=Application .desktop file 3.7 KB Diff Download File
collectionlist.cpp 2093 15 years ago Michael Pyne Take advantage of dfaure's kdelibs feature to dyna 14.9 KB Diff Download File
collectionlist.h 1971 16 years ago Michael Pyne JuK optimizapalooza! * Add whatever X-DBUS-foo li 6.1 KB Diff Download File
config-juk.h.cmake 1874 16 years ago Allen Winter move the tunepimp library check here, along with a 83 bytes Diff Download File
coverdialog.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 4.4 KB Diff Download File
coverdialog.h 1701 17 years ago Tim Beaulen Port the cover dialog to Ui4 svn path=/trunk/KDE 1.4 KB Diff Download File
coverdialogbase.ui 2052 15 years ago Christoph Feck SVN_SILENT Cleanup .ui files This removes (as dis 3.8 KB Diff Download File
covericonview.cpp 1952 16 years ago Michael Pyne More --qt3support: * Remove support for the cover 1.8 KB Diff Download File
covericonview.h 1803 17 years ago Michael Pyne Rename references to the old Google image fetcher 1.9 KB Diff Download File
coverinfo.cpp 2022 15 years ago Michael Pyne This debug output has outlived its usefulness svn 11 KB Diff Download File
coverinfo.h 1952 16 years ago Michael Pyne More --qt3support: * Remove support for the cover 2.2 KB Diff Download File
covermanager.cpp 2093 15 years ago Michael Pyne Take advantage of dfaure's kdelibs feature to dyna 17.2 KB Diff Download File
covermanager.h 2027 15 years ago Michael Pyne Fix cover art downloading by using KIO async, the 9 KB Diff Download File
coverproxy.cpp 2027 15 years ago Michael Pyne Fix cover art downloading by using KIO async, the 1.3 KB Diff Download File
coverproxy.h 2027 15 years ago Michael Pyne Fix cover art downloading by using KIO async, the 1.2 KB Diff Download File
dbuscollectionproxy.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 4.3 KB Diff Download File
dbuscollectionproxy.h 2017 15 years ago Michael Pyne Don't leave stray temporary cover files laying aro 2.3 KB Diff Download File
deletedialog.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 4.5 KB Diff Download File
deletedialog.h 1915 16 years ago Michael Pyne Some delete dialog code cleanups (what I really sh 1.8 KB Diff Download File
deletedialogbase.ui 2086 15 years ago Michael Pyne More kde3support removal patches from Georg Grable 4 KB Diff Download File
directorylist.cpp 2088 15 years ago Michael Pyne Commit the final patch for kde3support removal tha 4.3 KB Diff Download File
directorylist.h 2088 15 years ago Michael Pyne Commit the final patch for kde3support removal tha 1.9 KB Diff Download File
directorylistbase.ui 2088 15 years ago Michael Pyne Commit the final patch for kde3support removal tha 3.1 KB Diff Download File
dynamicplaylist.cpp 1985 15 years ago Laurent Montel Fix iterator svn path=/trunk/KDE/kdemultimedia/ju 5.4 KB Diff Download File
dynamicplaylist.h 1895 16 years ago Michael Pyne Fix JuK icon names. svn path=/trunk/KDE/kdemultim 3.4 KB Diff Download File
exampleoptions.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 2.7 KB Diff Download File
exampleoptions.h 1699 17 years ago Tim Beaulen Port the exampleoptions widget to Ui4 svn path=/ 2 KB Diff Download File
exampleoptionsbase.ui 2084 15 years ago Andrius Štikonas Use KIntSpinBox instead of QSpinBox for better int 12 KB Diff Download File
filehandle.cpp 2093 15 years ago Michael Pyne Take advantage of dfaure's kdelibs feature to dyna 7.1 KB Diff Download File
filehandle.h 1791 17 years ago Michael Pyne Fairly large overhaul of the JuK codebase to beat 2.4 KB Diff Download File
filehandleproperties.h 1985 15 years ago Laurent Montel Fix iterator svn path=/trunk/KDE/kdemultimedia/ju 4.3 KB Diff Download File
filerenamer.cpp 2189 13 years ago Michael Pyne Correctly add renamer categories in l10n'ed KDE de 31 KB Diff Download File
filerenamer.h 2091 15 years ago Laurent Montel Fix forward declaration svn path=/trunk/KDE/kdemu 18 KB Diff Download File
filerenamerbase.ui 2052 15 years ago Christoph Feck SVN_SILENT Cleanup .ui files This removes (as dis 8.5 KB Diff Download File
filerenamerconfigdlg.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 1.6 KB Diff Download File
filerenamerconfigdlg.h 1787 17 years ago Michael Pyne Reorganize headers to fix a ton of Krazy reports. 1.3 KB Diff Download File
filerenameroptions.cpp 2025 15 years ago Michael Pyne Make the file renamer dialog actually work for the 4.7 KB Diff Download File
filerenameroptions.h 1626 18 years ago Richard Lärkäng KDialogBase -> KDialog svn path=/trunk/KDE/kdemul 2.3 KB Diff Download File
filerenameroptionsbase.ui 2059 15 years ago Burkhard Lück fixing nonsense/wrong string, string freeze break 12.3 KB Diff Download File
folderplaylist.cpp 1894 16 years ago Michael Pyne Forward port fix allowing JuK to load JuK data fro 2.5 KB Diff Download File
folderplaylist.h 1789 17 years ago Michael Pyne Change QString::null to QString() in JuK where it 1.5 KB Diff Download File
HACKING 1564 18 years ago Michael Pyne Also standardize all of the JuK include header gua 5.7 KB Diff Download File
hi128-app-juk.png 1581 18 years ago Fabio Pedretti Losslessly optimize file size of *.png files in /t 14.6 KB Diff Download File
hi16-app-juk.png 1581 18 years ago Fabio Pedretti Losslessly optimize file size of *.png files in /t 813 bytes Diff Download File
hi32-app-juk.png 1581 18 years ago Fabio Pedretti Losslessly optimize file size of *.png files in /t 2.2 KB Diff Download File
hi48-app-juk.png 1581 18 years ago Fabio Pedretti Losslessly optimize file size of *.png files in /t 3.8 KB Diff Download File
hi64-app-juk.png 1581 18 years ago Fabio Pedretti Losslessly optimize file size of *.png files in /t 5.7 KB Diff Download File
historyplaylist.cpp 2152 14 years ago Michael Pyne Finally get the "Time" column to show up in the hi 4.6 KB Diff Download File
historyplaylist.h 2152 14 years ago Michael Pyne Finally get the "Time" column to show up in the hi 2.3 KB Diff Download File
juk-exception.h 1894 16 years ago Michael Pyne Forward port fix allowing JuK to load JuK data fro 1.4 KB Diff Download File
juk.cpp 2175 14 years ago Laurent Montel Start to compile with "-DQT_NO_CAST_FROM_ASCII-DQT 18.7 KB Diff Download File
File juk.desktop 2185 13 years ago Script Kiddy SVN_SILENT made messages (.desktop file) svn path 3.8 KB Diff Download File
juk.h 2111 14 years ago Michael Pyne Decouple PlayerManager from JuK so that it isn't a 2.8 KB Diff Download File
juk.notifyrc 2187 13 years ago Script Kiddy SVN_SILENT made messages (.desktop file) svn path 13.7 KB Diff Download File
jukIface.h 1785 17 years ago Michael Pyne Krazy fix: Fix missing copyright tags. I had to r 3.7 KB Diff Download File
jukservicemenu.desktop 2187 13 years ago Script Kiddy SVN_SILENT made messages (.desktop file) svn path 3 KB Diff Download File
jukui-rtl.rc 2094 15 years ago Michael Pyne Add ability to disable music crossfading in JuK. 2.5 KB Diff Download File
jukui.rc 2094 15 years ago Michael Pyne Add ability to disable music crossfading in JuK. 2.6 KB Diff Download File
k3bexporter.cpp 2175 14 years ago Laurent Montel Start to compile with "-DQT_NO_CAST_FROM_ASCII-DQT 5.5 KB Diff Download File
k3bexporter.h 2163 14 years ago Pierre Ducroquet Fix K3B export. Use K3B only from command line sin 2.9 KB Diff Download File
keydialog.cpp 1919 16 years ago Michael Pyne Fix bug 157028 (JuK shortcuts dialog has extra unl 7 KB Diff Download File
keydialog.h 1919 16 years ago Michael Pyne Fix bug 157028 (JuK shortcuts dialog has extra unl 2.5 KB Diff Download File
ktrm.cpp 2093 15 years ago Michael Pyne Take advantage of dfaure's kdelibs feature to dyna 20.2 KB Diff Download File
ktrm.h 1791 17 years ago Michael Pyne Fairly large overhaul of the JuK codebase to beat 6.8 KB Diff Download File
main.cpp 2188 13 years ago Michael Pyne Set directory mode for renamer's "music folder". 5 KB Diff Download File
mediafiles.cpp 2110 14 years ago Michael Pyne Use shared-mime-info-compliant MP4 mimetype, and a 7.1 KB Diff Download File
mediafiles.h 2101 15 years ago Michael Pyne Remove TagLib support code that wasn't even necess 3.5 KB Diff Download File
Messages.sh 2169 14 years ago Albert Astals Cid fix Messages.sh after yesterday change in extract- 96 bytes Diff Download File
musicbrainzquery.cpp 1995 15 years ago Michael Pyne Fix bug 176956 in trunk (JuK crashes on internet t 3.7 KB Diff Download File
musicbrainzquery.h 1685 18 years ago Laurent Montel Now we can search tunepimp lib juk compiles with i 1.3 KB Diff Download File
nowplaying.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 11.3 KB Diff Download File
nowplaying.h 2112 14 years ago Michael Pyne Cancel the now playing bar's filter if the now pla 4.2 KB Diff Download File
org.kde.juk.collection.xml 2016 15 years ago Michael Pyne Add trackCover method to JuK's D-Bus Collection in 1.7 KB Diff Download File
org.kde.juk.player.xml 2038 15 years ago Michael Pyne Remove the seek method from the JuK DBus interface 1.8 KB Diff Download File
org.kde.juk.search.xml 1627 18 years ago Laurent Montel Add dbus adaptor file svn path=/trunk/KDE/kdemul 393 bytes Diff Download File
playermanager.cpp 2128 14 years ago Frederik Schwarzer re-add the markup that was removed yesterday It w 18.1 KB Diff Download File
playermanager.h 2111 14 years ago Michael Pyne Decouple PlayerManager from JuK so that it isn't a 3.8 KB Diff Download File
playlist.cpp 2152 14 years ago Michael Pyne Finally get the "Time" column to show up in the hi 66.6 KB Diff Download File
playlist.h 2152 14 years ago Michael Pyne Finally get the "Time" column to show up in the hi 23.9 KB Diff Download File
playlistbox.cpp 2151 14 years ago Michael Pyne Make the history playlist work again. In the grea 25.7 KB Diff Download File
playlistbox.h 2151 14 years ago Michael Pyne Make the history playlist work again. In the grea 6.1 KB Diff Download File
playlistcollection.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 26.7 KB Diff Download File
playlistcollection.h 2151 14 years ago Michael Pyne Make the history playlist work again. In the grea 9.1 KB Diff Download File
playlistexporter.cpp 1826 17 years ago Arto Hytönen kdemultimedia EBN cleaning, also includes my 1st f 1 KB Diff Download File
playlistexporter.h 1826 17 years ago Arto Hytönen kdemultimedia EBN cleaning, also includes my 1st f 1.6 KB Diff Download File
playlistinterface.cpp 2056 15 years ago Michael Pyne Apply patch from Jiri Palecek to fix a fairly comm 2.2 KB Diff Download File
playlistinterface.h 1963 16 years ago Michael Pyne Fix late access to global static caused by NowPlay 3 KB Diff Download File
playlistitem.cpp 2021 15 years ago Michael Pyne Last crasher bug I fixed was due to not using Play 13.4 KB Diff Download File
playlistitem.h 2018 15 years ago Michael Pyne local8Bit encodings scare me, so save the QString 7 KB Diff Download File
playlistsearch.cpp 1985 15 years ago Laurent Montel Fix iterator svn path=/trunk/KDE/kdemultimedia/ju 9.1 KB Diff Download File
playlistsearch.h 1791 17 years ago Michael Pyne Fairly large overhaul of the JuK codebase to beat 4.8 KB Diff Download File
playlistsplitter.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 9.7 KB Diff Download File
playlistsplitter.h 2151 14 years ago Michael Pyne Make the history playlist work again. In the grea 2.9 KB Diff Download File
searchplaylist.cpp 2093 15 years ago Michael Pyne Take advantage of dfaure's kdelibs feature to dyna 3.5 KB Diff Download File
searchplaylist.h 1789 17 years ago Michael Pyne Change QString::null to QString() in JuK where it 1.8 KB Diff Download File
searchwidget.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 8.4 KB Diff Download File
searchwidget.h 1976 16 years ago Michael Pyne Fun thing to do with JuK: Pause playback. Type in 2.8 KB Diff Download File
slideraction.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 10.8 KB Diff Download File
slideraction.h 1793 17 years ago Laurent Montel Remove not necessary "class <classname>;" svn pat 2.1 KB Diff Download File
sortedstringlist.cpp 1907 16 years ago Michael Pyne Remove unnecessary check as per discussion on kde- 3.6 KB Diff Download File
sortedstringlist.h 1562 18 years ago Michael Pyne Since we're standardizing the source style, figure 1.8 KB Diff Download File
splashscreen.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 2.9 KB Diff Download File
splashscreen.h 1610 18 years ago Laurent Montel Convert include from "#include <q...h>" to "#inclu 1.7 KB Diff Download File
statuslabel.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 6.7 KB Diff Download File
statuslabel.h 1793 17 years ago Laurent Montel Remove not necessary "class <classname>;" svn pat 2 KB Diff Download File
stringhash.h 1837 17 years ago Matthias Kretz use QHash/QSet instead of custom implementation. l 2.1 KB Diff Download File
stringshare.cpp 2019 15 years ago Michael Pyne Maksim pointed out that my change to StringShare t 2.2 KB Diff Download File
stringshare.h 2018 15 years ago Michael Pyne local8Bit encodings scare me, so save the QString 1.2 KB Diff Download File
systemtray.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 15 KB Diff Download File
systemtray.h 2167 14 years ago Michael Pyne Add mouse wheel-handling code to the track announc 4.3 KB Diff Download File
tag.cpp 2165 14 years ago Michael Pyne Fix bug 230041 (JuK system tray tooltip clips lett 6.7 KB Diff Download File
tag.h 2118 14 years ago Michael Pyne Minimize memory usages when adding new tracks as w 3.3 KB Diff Download File
tageditor.cpp 2190 13 years ago Michael Pyne Refresh tag editor if collection is updated while 27.6 KB Diff Download File
tageditor.h 1793 17 years ago Laurent Montel Remove not necessary "class <classname>;" svn pat 3.3 KB Diff Download File
tagguesser.cpp 1985 15 years ago Laurent Montel Fix iterator svn path=/trunk/KDE/kdemultimedia/ju 6.1 KB Diff Download File
tagguesser.h 1791 17 years ago Michael Pyne Fairly large overhaul of the JuK codebase to beat 1.8 KB Diff Download File
tagguesserconfigdlg.cpp 2175 14 years ago Laurent Montel Start to compile with "-DQT_NO_CAST_FROM_ASCII-DQT 4.4 KB Diff Download File
tagguesserconfigdlg.h 2087 15 years ago Michael Pyne More kde3support-- patches from Georg Grabler. Th 1.2 KB Diff Download File
tagguesserconfigdlgwidget.ui 2087 15 years ago Michael Pyne More kde3support-- patches from Georg Grabler. Th 4.3 KB Diff Download File
tagrenameroptions.cpp 2077 15 years ago Michael Pyne Finally fix bug 118317 (JuK ignores Genre/Year in 5.3 KB Diff Download File
tagrenameroptions.h 1787 17 years ago Michael Pyne Reorganize headers to fix a ton of Krazy reports. 5.5 KB Diff Download File
tagtransactionmanager.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 6 KB Diff Download File
tagtransactionmanager.h 1791 17 years ago Michael Pyne Fairly large overhaul of the JuK codebase to beat 7.2 KB Diff Download File
TODO 1415 19 years ago Scott Wheeler Readding the TODO for now. Just something of a 3. 839 bytes Diff Download File
trackpickerdialog.cpp 2098 15 years ago Michael Pyne Remove needless config.h svn path=/trunk/KDE/kdem 3.3 KB Diff Download File
trackpickerdialog.h 2098 15 years ago Michael Pyne Remove needless config.h svn path=/trunk/KDE/kdem 1.6 KB Diff Download File
trackpickerdialogbase.ui 2052 15 years ago Christoph Feck SVN_SILENT Cleanup .ui files This removes (as dis 5.9 KB Diff Download File
tracksequenceiterator.cpp 2093 15 years ago Michael Pyne Take advantage of dfaure's kdelibs feature to dyna 8.8 KB Diff Download File
tracksequenceiterator.h 1564 18 years ago Michael Pyne Also standardize all of the JuK include header gua 7.3 KB Diff Download File
tracksequencemanager.cpp 2177 14 years ago Michael Pyne Commit stray bugfix floating around in my local co 5 KB Diff Download File
tracksequencemanager.h 2044 15 years ago Michael Pyne Use smart pointer for cached Playlist handle svn 6.4 KB Diff Download File
treeviewitemplaylist.cpp 1878 16 years ago Laurent Montel Fix include svn path=/trunk/KDE/kdemultimedia/juk 3.1 KB Diff Download File
treeviewitemplaylist.h 1789 17 years ago Michael Pyne Change QString::null to QString() in JuK where it 1.5 KB Diff Download File
upcomingplaylist.cpp 2080 15 years ago Michael Pyne Port most iterators to use foreach when feasible. 7.5 KB Diff Download File
upcomingplaylist.h 1786 17 years ago Michael Pyne More krazy fixes for JuK. Although we've not yet 7.1 KB Diff Download File
viewmode.cpp 1982 15 years ago Sebastian Sauer * fix crash on startup if treeviewmode was chosen 11.9 KB Diff Download File
viewmode.h 1793 17 years ago Laurent Montel Remove not necessary "class <classname>;" svn pat 4.6 KB Diff Download File
webimagefetcher.cpp 2093 15 years ago Michael Pyne Take advantage of dfaure's kdelibs feature to dyna 6.8 KB Diff Download File
webimagefetcher.h 1914 16 years ago Michael Pyne Fix bug 157987 (JuK unnecessarily converts all cov 2.2 KB Diff Download File
webimagefetcherdialog.cpp 2174 14 years ago Laurent Montel Use QLatin1String svn path=/trunk/KDE/kdemultime 8.3 KB Diff Download File
webimagefetcherdialog.h 2026 15 years ago Michael Pyne Remove dead code from JuK web image fetcher svn p 2.5 KB Diff Download File