~neon/phonon/master

Viewing all changes in revision 2960.

  • Committer: Friedrich W. H. Kossebau
  • Date: 2020-08-23 22:06:09 UTC
  • Revision ID: git-v1:3dacd49b116f7389e953f2bf63bc64b06ebe4409
Use Q_DECLARE_OPERATORS_FOR_FLAGS in same namespace as flags definition

Having the macro's definition of the operator| in the namespace of the
flags argument improves/unbreaks things for the argument-dependent
lookup of unqualified function names, e.g. when flags are combined in
calls of other methods, but there is some other operator| defined in the
namespace of the current code.

Given Q_DECLARE_OPERATORS_FOR_FLAGS creates inlined functions, this
should be a source and binary compatible change.

Qt did similar for Qt 5.12 in
https://codereview.qt-project.org/c/qt/qtbase/+/225348

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: