~neon/taglib/master : changes

~neon/taglib/master » Changes from revision 1581

From Revision 1568 to 1549

Rev	Summary	Authors	Date
1568	Map: Add method value() to look up without creating entry Map: Add method value() to look up without creating entry	Urs Fleisch	2 years ago
1567	We don't need to export these symbols We don't need to export these symbols	Scott Wheeler	2 years ago
1566	Add MP4::File::strip() to remove meta atom from file Add MP4::File::strip() to remove meta atom from file This changes the modifications from the last commit in order to achieve the following behavior: MP4::File::save() works in the same way as before, i.e. it will never shrink the file and will make space from removed items available as padding in the form of a "free" atom. To completely remove the "meta" atom from the file, a new method strip() is introduced, which can be used in the same way as its MPEG::File::strip() counterpart.	Urs Fleisch	2 years ago
1565	Remove MP4 meta atom when empty tag is saved Remove MP4 meta atom when empty tag is saved Currently, MP4 tags can only grow. If items are removed, they are just replaced by padding in the form of "free" atoms. This change will remove the whole "meta" atom when an MP4 tag without items is saved. This will make it possible, to bring the file back to its pristine state without metadata.	Urs Fleisch	2 years ago
1564	Add `-Wall` compiler flag to Clang compilers. Add `-Wall` compiler flag to Clang compilers. Use CMAKE's `CMAKE_<LANG>_COMPILER_ID`, available from 3.0.2. See: https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER_ID.html	Dzmitry Neviadomski	2 years ago
1563	Add compile_commands.json to gitignore Add compile_commands.json to gitignore Other entries were copied from KDE/marble repo as well. See also: https://invent.kde.org/sdk/kdesrc-build/-/issues/86	ivan tkachenko	2 years ago
1562	clang-tidy: replace static_cast with dynamic_cast (#1021) clang-tidy: replace static_cast with dynamic_cast (#1021) * clang-tidy: replace static_cast with dynamic_cast Found with cppcoreguidelines-pro-type-static-cast-downcast Signed-off-by: Rosen Penev <rosenp@gmail.com>	Rosen Penev	2 years ago
1561	add missing const add missing const Avoids using a non const global variable. Signed-off-by: Rosen Penev <rosenp@gmail.com>	Rosen Penev	2 years ago
1560	use std::pair instead of 2D C array (#1020) use std::pair instead of 2D C array (#1020) * use std::pair instead of 2D C array Mostly the same. Except there's now an association between both values. make_pair has to be used since there's no uniform initialization. Signed-off-by: Rosen Penev <rosenp@gmail.com>	Rosen Penev	3 years ago
1559	clang-tidy: don't use else after return clang-tidy: don't use else after return Found with readability-else-after-return Signed-off-by: Rosen Penev <rosenp@gmail.com>	Rosen Penev	3 years ago
1558	clang-tidy: simplify boolean return clang-tidy: simplify boolean return Found with readability-simplify-boolean-expr Signed-off-by: Rosen Penev <rosenp@gmail.com>	Rosen Penev	3 years ago
1557	clang-tidy: use C++ casting clang-tidy: use C++ casting Found with google-readability-casting Signed-off-by: Rosen Penev <rosenp@gmail.com>	Rosen Penev	3 years ago
1556	clang-tidy: add ending namespace comments clang-tidy: add ending namespace comments Found with google-readability-namespace-comments Signed-off-by: Rosen Penev <rosenp@gmail.com>	Rosen Penev	3 years ago
1555	clang-tidy: remove redundant initializations clang-tidy: remove redundant initializations Found with readability-redundant-member-init Signed-off-by: Rosen Penev <rosenp@gmail.com>	Rosen Penev	3 years ago
1554	Detect by contents if file detected by extension is invalid ... Detect by contents if file detected by extension is invalid (#1011) This is the case for Opus files with an ogg extension.	Urs Fleisch	3 years ago
1553	Fix "error: duplicate ‘volatile’" on systems without HAVE_GC... Fix "error: duplicate ‘volatile’" on systems without HAVE_GCC_ATOMIC in 1.12 (#1012) * fix error: duplicate volatile * fix volatile ATOMIC_INT in constructor	Oleg Antonyan	3 years ago
1552	ID3v2: Address review comments ID3v2: Address review comments Change the size check to use isEmpty() as requested.	bobsayshilol	3 years ago
1551	ASF: Bounds check the size of each header object ASF: Bounds check the size of each header object UBSan spotted an integer overflow on the line `dataPos += size`, so add a bounds check to the size that we read.	bobsayshilol	3 years ago
1550	ID3v2: Return early from decode() on invalid data ID3v2: Return early from decode() on invalid data The while loop in this function assumes that `data.end() - 1` is less than `data.end()`, which isn't the case if `data` is empty since `data.end()` can be a nullptr.	bobsayshilol	3 years ago
1549	MPC: Fix heap-buffer-overflow in readSV7() MPC: Fix heap-buffer-overflow in readSV7() If `data` is an allocation of only 3 bytes (MP+) then `data[3]` is a read past the end of the buffer.	bobsayshilol	3 years ago

Older »