1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
|
# Copyright 2014-2015 Canonical Ltd. This software is licensed under the
# GNU Affero General Public License version 3 (see the file LICENSE).
"""Tests for `NetworkForm`."""
from __future__ import (
absolute_import,
print_function,
unicode_literals,
)
str = None
__metaclass__ = type
__all__ = []
from maasserver import forms as forms_module
from maasserver.dns import config as dns_config_module
from maasserver.enum import NODEGROUPINTERFACE_MANAGEMENT
from maasserver.forms import (
create_Network_from_NodeGroupInterface,
NetworkForm,
)
from maasserver.models import (
MACAddress,
Network,
)
from maasserver.testing.factory import factory
from maasserver.testing.orm import reload_object
from maasserver.testing.testcase import MAASServerTestCase
from maastesting.matchers import MockCalledOnceWith
from netaddr import IPNetwork
from testtools.matchers import Contains
class TestNetworkForm(MAASServerTestCase):
"""Tests for `NetworkForm`."""
def test_creates_network(self):
network = factory.make_ipv4_network()
name = factory.make_name('network')
definition = {
'name': name,
'description': factory.make_string(),
'ip': "%s" % network.cidr.ip,
'netmask': "%s" % network.netmask,
'vlan_tag': factory.make_vlan_tag(),
}
form = NetworkForm(data=definition)
form.save()
network_obj = Network.objects.get(name=name)
self.assertAttributes(network_obj, definition)
def test_network_creation_fails_if_empty_IP(self):
network = factory.make_ipv4_network()
name = factory.make_name('network')
definition = {
'name': name,
'description': factory.make_string(),
'ip': "",
'netmask': "%s" % network.netmask,
'vlan_tag': factory.make_vlan_tag(),
}
form = NetworkForm(data=definition)
self.assertFalse(form.is_valid())
self.assertEqual(
["This field is required."], form.errors['ip'])
def test_network_creation_fails_if_empty_netmask(self):
network = factory.make_ipv4_network()
name = factory.make_name('network')
definition = {
'name': name,
'description': factory.make_string(),
'ip': "%s" % network.cidr.ip,
'netmask': "",
'vlan_tag': factory.make_vlan_tag(),
}
form = NetworkForm(data=definition)
self.assertFalse(form.is_valid())
self.assertEqual(
["This field is required."], form.errors['netmask'])
def test_updates_network(self):
network = factory.make_Network()
new_description = factory.make_string()
form = NetworkForm(
data={'description': new_description}, instance=network)
form.save()
network = reload_object(network)
self.assertEqual(new_description, network.description)
def test_populates_initial_macaddresses(self):
network = factory.make_Network()
macs = [
factory.make_MACAddress_with_Node(networks=[network])
for _ in range(3)]
# Create other MAC addresses.
for _ in range(2):
factory.make_MACAddress_with_Node(
networks=[factory.make_Network()])
new_description = factory.make_string()
form = NetworkForm(
data={'description': new_description}, instance=network)
self.assertItemsEqual(
[mac.mac_address.get_raw() for mac in macs],
form.initial['mac_addresses'])
def test_macaddresses_are_sorted(self):
network1, network2 = factory.make_Networks(2)
macs = [
factory.make_MACAddress_with_Node(networks=[network1])
for _ in range(3)]
# Create macs connected to the same node.
macs = macs + [
factory.make_MACAddress(networks=[network1], node=macs[0].node)
for _ in range(3)]
# Create other MAC addresses.
for _ in range(2):
factory.make_MACAddress_with_Node(networks=[network2])
form = NetworkForm(data={}, instance=network1)
self.assertEqual(
list(MACAddress.objects.all().order_by(
'node__hostname', 'mac_address')),
list(form.fields['mac_addresses'].queryset))
def test_macaddresses_widget_displays_MAC_and_node_hostname(self):
networks = factory.make_Networks(3)
same_network = networks[0]
misc_networks = networks[1:]
for _ in range(3):
factory.make_MACAddress_with_Node(networks=[same_network])
# Create other MAC addresses.
for network in misc_networks:
factory.make_MACAddress_with_Node(networks=[network])
form = NetworkForm(data={}, instance=same_network)
self.assertItemsEqual(
[(mac.mac_address, "%s (%s)" % (
mac.mac_address, mac.node.hostname))
for mac in MACAddress.objects.all()],
form.fields['mac_addresses'].widget.choices)
def test_updates_macaddresses(self):
network = factory.make_Network()
# Attach a couple of MAC addresses to the network.
[factory.make_MACAddress_with_Node(networks=[network])
for _ in range(3)]
new_macs = [
factory.make_MACAddress_with_Node()
for _ in range(3)]
form = NetworkForm(
data={
'mac_addresses': [
mac.mac_address.get_raw() for mac in new_macs],
},
instance=network)
form.save()
network = reload_object(network)
self.assertItemsEqual(new_macs, network.macaddress_set.all())
def test_deletes_macaddresses_by_default_if_not_specified(self):
network = factory.make_Network()
[factory.make_MACAddress_with_Node(networks=[network])
for _ in range(3)]
form = NetworkForm(
data={
'name': "foo",
},
instance=network)
form.save()
network = reload_object(network)
self.assertItemsEqual([], network.macaddress_set.all())
def test_does_not_delete_unspecified_macaddresses_if_told_not_to(self):
network = factory.make_Network()
macs = [
factory.make_MACAddress_with_Node(networks=[network])
for _ in range(3)]
form = NetworkForm(
data={
'name': "foo",
},
instance=network,
delete_macs_if_not_present=False,
)
form.save()
network = reload_object(network)
self.assertItemsEqual(macs, network.macaddress_set.all())
def test_reports_clashes(self):
# The uniqueness test on the Network model raises a ValidationError
# when it finds a clash, but Django is prone to crashing when the
# exception doesn't take the expected form (bug 1299114).
big_network = IPNetwork('10.9.0.0/16')
nested_network = IPNetwork('10.9.9.0/24')
existing_network = factory.make_Network(network=big_network)
form = NetworkForm(data={
'name': factory.make_name('clashing-network'),
'ip': "%s" % nested_network.cidr.ip,
'netmask': "%s" % nested_network.netmask,
'vlan_tag': factory.make_vlan_tag(),
})
self.assertFalse(form.is_valid())
message = "IP range clashes with network '%s'." % existing_network.name
self.assertEqual(
{
'ip': [message],
'netmask': [message],
},
form.errors)
def test_writes_dns_when_network_edited(self):
dns_update_all_zones = self.patch(
dns_config_module, "dns_update_all_zones")
network = factory.make_ipv4_network()
name = factory.make_name('network')
definition = {
'name': name,
'description': factory.make_string(),
'ip': "%s" % network.cidr.ip,
'netmask': "%s" % network.netmask,
'vlan_tag': factory.make_vlan_tag(),
}
form = NetworkForm(data=definition)
form.save()
self.assertThat(dns_update_all_zones, MockCalledOnceWith())
def test_writes_dns_when_network_deleted(self):
network = factory.make_Network()
dns_update_all_zones = self.patch(
dns_config_module, "dns_update_all_zones")
network.delete()
self.assertThat(dns_update_all_zones, MockCalledOnceWith())
class TestCreateNetworkFromNodeGroupInterface(MAASServerTestCase):
def test_skips_creation_if_netmask_undefined(self):
nodegroup = factory.make_NodeGroup()
interface = factory.make_NodeGroupInterface(
nodegroup, management=NODEGROUPINTERFACE_MANAGEMENT.UNMANAGED)
interface.subnet_mask = None
network = create_Network_from_NodeGroupInterface(interface)
self.assertIsNone(network)
self.assertItemsEqual([], Network.objects.all())
def test_creates_network_without_vlan(self):
nodegroup = factory.make_NodeGroup()
interface = factory.make_NodeGroupInterface(nodegroup)
network = create_Network_from_NodeGroupInterface(interface)
definition = {
'name': "%s-%s" % (
interface.nodegroup.name, interface.interface),
'description': (
"Auto created when creating interface %s on cluster %s" % (
interface.name, interface.nodegroup.name)),
'ip': "%s" % interface.network.ip,
'netmask': "%s" % interface.network.netmask,
'vlan_tag': None,
}
network_obj = Network.objects.get(id=network.id)
self.assertAttributes(network_obj, definition)
def test_creates_network_with_vlan(self):
nodegroup = factory.make_NodeGroup()
intf = 'eth0'
vlan = 1
interface = factory.make_NodeGroupInterface(
nodegroup, interface="%s.%d" % (intf, vlan))
network = create_Network_from_NodeGroupInterface(interface)
net_name = "%s-%s" % (interface.nodegroup.name, interface.interface)
net_name = net_name.replace('.', '-')
definition = {
'name': net_name,
'description': (
"Auto created when creating interface %s on cluster %s" % (
interface.name, interface.nodegroup.name)),
'ip': "%s" % interface.network.ip,
'netmask': "%s" % interface.network.netmask,
'vlan_tag': vlan,
}
network_obj = Network.objects.get(id=network.id)
self.assertAttributes(network_obj, definition)
def test_skips_creation_if_network_already_exists(self):
nodegroup = factory.make_NodeGroup()
interface = factory.make_NodeGroupInterface(nodegroup)
create_Network_from_NodeGroupInterface(interface)
maaslog = self.patch(forms_module, 'maaslog')
self.assertIsNone(create_Network_from_NodeGroupInterface(interface))
self.assertEqual(
1, maaslog.warning.call_count,
"maaslog.warning hasn't been called")
self.assertThat(
maaslog.warning.call_args[0][0],
Contains("Failed to create Network"))
|