~online-accounts/gnome-control-center-signon/trunk

Viewing all changes in revision 142.

  • Committer: Tarmac
  • Author(s): Alberto Mardegan
  • Date: 2013-03-22 14:41:26 UTC
  • mfrom: (141.1.4 lp1122520)
  • Revision ID: tarmac-20130322144126-5t65b3n2w8gzxufi
Don't crash when cancelling the authentication or disposing the plugin

This fixes a couple of crashes which would occur:

1) when cancelling an ongoing authentication by pressing the "Cancel" button: this is fixed by tracking the state of the asynchronous operations and delaying the emission of the "finished" signal until they have all completed.

2) when going back to the System Settings: this operation would destroy the plugin, but the asynchronous operations would still continue and the callbacks would be invoked later on an invalid pointer to "self" (see also https://bugzilla.gnome.org/show_bug.cgi?id=696369). This is fixed by guarding the "self" pointer with a weak GObject pointer. Fixes: https://bugs.launchpad.net/bugs/1122520.

Approved by David King, PS Jenkins bot.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: