~openstreetmap/josm/trunk : changes

~openstreetmap/josm/trunk » Changes from revision 18570

From Revision 18570 to 18551

Rev	Summary	Authors	Date
18570	don't hardcode ID don't hardcode ID	stoecker	5 months ago
18569	Fix #23309: NPE in GeoPropertyIndex$GPLevel.getBounded when ... Fix #23309: NPE in GeoPropertyIndex$GPLevel.getBounded when called by `Territories.getRegionalTaginfoUrls` `Territories.getRegionalTaginfoUrls` uses `Collection.parallelStream` which could cause the following race conditions: * `children` is reinitialized after the `null` check, potentially causing an NPE due to a different `null` check becoming `false` after it was checked. Solution: either synchronize the creation of `children` or have a local variable. * Two threads could generate a child and then generate children of children, creating a split tree hierarchy, only one of which would be kept. Solution: synchronize the creation of the child nodes For both of the new `synchronized` methods, we ''could'' use a safe double-lock idiom if there ends up being performance issues. This probably won't be the case. Profiling JOSM start to end with Mesa County, CO (+ validations) did not show that the modified methods were "hot". This additionally fixes some lint issues and converts some package-private methods to use `ILatLon` instead of `LatLon`.	taylor.smock	5 months ago
18568	remove TLD from IANA remove TLD from IANA	taylor.smock	5 months ago
18567	remove TLD from IANA remove TLD from IANA	taylor.smock	5 months ago
18566	fix #23310: TagChecker: Correct "peek" to "peak" fix #23310: TagChecker: Correct "peek" to "peak" Patch provided by hhtznr	GerdP	5 months ago
18565	combine two loops (remove sonar warning) combine two loops (remove sonar warning)	stoecker	5 months ago
18564	See #18866: Remove Potlatch2 from the built-in styles See #18866: Remove Potlatch2 from the built-in styles Remove an icon that was missed for the Potlatch2 style.	taylor.smock	5 months ago
18563	Add/Ignore popular tags Add/Ignore popular tags Add * `informal=no` -- this appears to be used for trails that appear to be `informal=yes` but are not. * `highway=trailhead` * Icon drawn by taylor.smock * `amenity=letterbox` * Additionally adds `post:` tags, copied from `addr:` tags * Icon drawn by taylor.smock; a better icon would be much appreciated * `building=stadium` -- added as a checkbox to `leisure=stadium` and the default `building` preset Ignore * `building=no` -- this is already covered in unnecessary.mapcss	taylor.smock	5 months ago
18562	Fix #23235: Revert r18869 Fix #23235: Revert r18869 The URI specification only allows for ascii characters. See https://datatracker.ietf.org/doc/html/rfc3986#section-1.2.1.	taylor.smock	5 months ago
18561	Fix #23057: data layers should be selected next, not non-dat... Fix #23057: data layers should be selected next, not non-data layers (patch by gaben, modified) Modifications are as follows: * Fix test pollution uncovered by change in non-obvious determinate order of tests * Fix code so that `MainLayerManagerTest.testRemoveLayerUnsetsActiveLayer` passes	taylor.smock	5 months ago
18560	remove TLD from IANA remove TLD from IANA	taylor.smock	5 months ago
18559	Fix #16567: Upgrade to JUnit 5 Fix #16567: Upgrade to JUnit 5 JOSMTestRules and JOSMTestFixture can reset the default JOSM profile, which can be unexpected for new contributors. This updates all tests to use JUnit 5 ''and'' the new JUnit 5 annotations. This also renames MapCSSStyleSourceFilterTest to MapCSSStyleSourceFilterPerformanceTest to match the naming convention for performance tests and fixes some lint issues. This was tested by running all tests individually and together.	taylor.smock	5 months ago
18558	Fix #23257: MVTTileTest has an infrequently hit race conditi... Fix #23257: MVTTileTest has an infrequently hit race condition (patch by marcello, modified) The race condition is dependent upon calculation speed; if the layers get loaded prior to the image loading, it is ''possible'' for us to get to the point where we expect the image to be loaded, but it isn't yet. Modifications are as follows: * Reinitialize tileSource and loader before each test, but initialize the cache once and clear that between tests.	taylor.smock	5 months ago
18557	Fix #23256: AbstractPrimitive::putAll not updating values (p... Fix #23256: AbstractPrimitive::putAll not updating values (patch by marcello)	taylor.smock	5 months ago
18556	Fix #23256: AbstractPrimitive::putAll not updating values (p... Fix #23256: AbstractPrimitive::putAll not updating values (patch by marcello, modified) Modifications are as follows: * Unit tests were split out into discrete units for better test feedback in the future.	taylor.smock	5 months ago
18555	See #17858: Add Java 17 as an option for the Java version in... See #17858: Add Java 17 as an option for the Java version in deb packages By depending upon `default-jre` with a version specification, we can avoid hardcoding many specific Java JREs versions via `\|`. Instead, we just indicate that the default-jre must be >= 17 ''or'' the currently installed version must be Java 8 compatible. This will change on 2023-12-31 when Java 8 support is dropped. See #17858 for details. This was verified via the following in an Ubuntu 23.04 container: 1. `curl -O https://josm.openstreetmap.de/apt/pool/universe/j/josm-latest/josm-latest_1.5.svn18887_all.deb` 2. `ar x josm-latest_1.5.svn18887_all.deb control.tar.xz` 3. `tar xf control.tar.xz control` 4. Edit control to match new control 5. `xz --decompress control.tar.xz && tar uvf control.tar control && xz control.tar` 6. `ar r josm-latest_1.5.svn18887_all.deb control.tar.xz` The resulting deb package was then tested against Debian Buster, Bullseye, Bookworm, Trixie, and Sid, along with Ubuntu 18.04, 20.04, 22.04, 23.04, and 23.10 with `podman run -it --rm --volume $(pwd):/mnt ${IMAGE} /usr/bin/bash -c "apt update && apt install -y /mnt/josm-latest_1.5.svn18887_all.deb && josm-latest --version && josm-latest --status-report"`	taylor.smock	5 months ago
18554	See #18866: Remove Potlatch2 from the built-in styles See #18866: Remove Potlatch2 from the built-in styles This fixes the MapRendererPerformanceTest that failed due to depending upon the number of built-in paintstyles.	taylor.smock	5 months ago
18553	See r18885: Fix default hasTagDifferent implementation. See r18885: Fix default hasTagDifferent implementation.	taylor.smock	5 months ago
18552	Fix #18866: Remove Potlatch2 from the built-in styles. It ha... Fix #18866: Remove Potlatch2 from the built-in styles. It has been replaced with wiki:Styles/Potlatch2. Users who have the built-in Potlatch2 style enabled when they upgrade to this revision or later will automatically have wiki:Styles/Potlatch2 added to their style list and enabled.	taylor.smock	5 months ago
18551	Fix #23252: Ignore `line_management=transition\|termination` ... Fix #23252: Ignore `line_management=transition\|termination` in `UnconnectedPowerTest` (patch by gaben, modified) Modifications are as follows: * Lint fixes * Performance enhancements (profiling done with validator and an overpass download of Mesa County, Colorado) * Iterating over an array is much more efficient than using streams. For methods that may be frequently called, using `Arrays.stream` is currently not a good idea. * hasTagDifferent: 2.09 MB -> 0 * hasTag: 125MB -> 0 * hasKey: 879MB -> 0	taylor.smock	5 months ago

Older »