~pali/llvm/polly-trunk

Viewing all changes in revision 3935.

  • Committer: meinersbur
  • Date: 2019-10-17 23:55:35 UTC
  • Revision ID: svn-v4:91177308-0d34-0410-b5e6-96231b3b80d8:polly/trunk:375192
[ScopBuilder] Fix bug 38358 by preserving correct order of ScopStmts.

ScopBuilder::buildEqivClassBlockStmts creates ScopStmts for instruction
groups in basic block and inserts these ScopStmts into Scop::StmtMap,
however, as described in llvm.org/PR38358, comment #5, StmtScops are
inserted into vector ScopStmt[BB] in wrong order.  As a result,
ScopBuilder::buildSchedule creates wrong order sequence node.

Looking closer to code, it's clear there is no equivalent classes with
interleaving isOrderedInstruction(memory access) instructions after
joinOrderedInstructions.  Afterwards, ScopStmts need to be created and
inserted in the original order of memory access instructions, however,
at the moment ScopStmts are inserted in the order of leader instructions
which are probably not memory access instructions.

The fix is simple with a standalone loop scanning
isOrderedInstruction(memory access) instructions in basic block and
inserting elements into LeaderToInstList one by one.  The patch also
removes double reversing operations which are now unnecessary.

New test preserve-equiv-class-order-in-basic_block.ll is also added.

Differential Revision: https://reviews.llvm.org/D68941

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: