~patchwork-devs/patchwork/patchwork

Viewing all changes in revision 1566.

  • Committer: Daniel Axtens
  • Date: 2019-08-22 11:33:00 UTC
  • Revision ID: git-v1:dde885c6c2f5e03388630320bc03a4cbe1040c64
mbox: do not copy Content-Type into exported mbox

Daniel reports a patch + comment combination that breaks in
git am. The patch reports a Content-Type of US-ASCII, while
the comment adds a Ack with UTF-8 characters. The exported
mbox contains both the original Content-Type, and a UTF-8
Content-Type that we set. However, because the US-ASCII one
occurs later, git am honours it instead of ours, and chokes
on the UTF-8 characters.

Strip out any subsequent Content-Type:s. We normalise things
to UTF-8 and should not allow it to be overridden.

Add a test for this, based on the original report.

Reported-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Daniel Axtens <dja@axtens.net>

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: