~percona-dev/percona-xtrabackup/lp528752_test

  • Committer: Alexey Kopytov
  • Date: 2011-02-06 13:34:45 UTC
  • Revision ID: akopytov@gmail.com-20110206133445-taaco31lrflq7hdx
Fix for LP bug #713799: race condition when trying to open an already
                        removed tablespace

Dropping a table during a backup process could result in assertion
failure in xtrabackup.

xtrabackup iterates a data dictionary snapshot taken at the very start
of a backup process when looking for files to copy. Since some tables
may be dropped while backup is in progress, there is a possibility for
some .ibd files to be removed by the time xtrabackup will try to copy
them.

The actual crash occurred as a result of the following chain of calls:
fil_space_get_zip_size() -> fil_space_get_flags() ->
fil_node_prepare_for_io() -> fil_node_open_file() which
eventually led to an assertion failure in fil_node_open_file() when it
was trying to open a nonexistent .ibd.

Fixed by changing fil_node_prepare_for_io() and fil_node_open_file() so
that in case of the 'file not found' error, the error is signaled to
the caller instead of generating an assertion failure.

xtrabackup.c also had to be fixed to actually skip nonexistent file with
a warning message rather than terminate the entire backup process with a
fatal error.
Filename Latest Rev Last Changed Committer Comment Size
..
test 134.1.1 14 years ago Aleksandr Kuzminsky Added the XtraBackup test framework Diff
utils 30.1.2 15 years ago Vadim Tkachenko directory restructure Diff
BUILD.txt 169 13 years ago Vadim Tkachenko fixes to BUILD.txt 658 bytes Diff Download File
COPYING 174.1.1 13 years ago Stewart Smith add COPYING file with GPLv2 license. xtrabackup is 18.6 KB Diff Download File
fix_innodb_for_backup51.patch 202.3.1 13 years ago Alexey Kopytov Updated XtraBackup patches and the build script to 34.7 KB Diff Download File
fix_innodb_for_backup55.patch 215 13 years ago Alexey Kopytov Fix for LP bug #713799: race condition when trying 31 KB Diff Download File
fix_innodb_for_backup_5.1_plugin.patch 215 13 years ago Alexey Kopytov Fix for LP bug #713799: race condition when trying 31.8 KB Diff Download File
fix_innodb_for_backup_percona-server.patch 215 13 years ago Alexey Kopytov Fix for LP bug #713799: race condition when trying 34 KB Diff Download File
File innobackupex-1.5.1 211.1.2 13 years ago Valentine Gostev Added fix for bug 688211 (additional single quotes 87 KB Diff Download File
Makefile 209 13 years ago Alexey Kopytov Manual merge from lp:~percona-dev/percona-xtraback 9.6 KB Diff Download File
tar4ibd_libtar-1.2.11.patch 127 14 years ago kinoyasu tar4ibd supports variable page size and fast_check 15.1 KB Diff Download File
xtrabackup.c 215 13 years ago Alexey Kopytov Fix for LP bug #713799: race condition when trying 165 KB Diff Download File