~ps-jenkins/compiz/latestsnapshot-10.9.10+13.10.20131004-0ubuntu1

cube.cpp, code cleanup:

#include "privates.h", not <privates.h>.
Merged if condition checks.
Declaration of variables, where you need them to improve
the code structure and readability.
Use C++ standard bool for topDir, bottomDir, allCaps and
mCapsPainted[output] (bool true/false instead Bool TRUE/FALSE).
Initialize all of the class member variables in the constructor.
Replaced if (priv->mSky.size () > 0) with if (!priv->mSky.empty ()).
Removed redundant brackets.
Fixed indentation.
Added TODO.

cube.cpp, code speedup:

Do not call optionGetInactiveOpacity () twice, instead save
the value as float inactiveOpacity and use this variable in
the following calculation.
Introduced the variables float halfHsize  = hsize / 2.0; and
float tsSize = 360.0f / size; and used those in following
calculations to not have to recalculate those values multiple
times.
Do not calculate M_PI / sides and 2 * M_PI / sides multiple times
in loops, instead save those values in the GLfloats mps and tmps
and use those values inside the loops.
Use GLdouble mDist2 = 0.5 / mDistance; in the GLdouble clipPlane*
arrays, instead of recalculating this value multiple times.
Use GLfloat oneMinusFStepX = 1.0f - fStepX; and
GLfloat oneMinusFStepY = 1.0f - fStepY; instead of calculating
those values multiple times.
Use float outputWidth = outputPtr->width (); and float outputHeight =
outputPtr->height (); instead of calling the functions multiple
times.
Introduced the GLfloat normInvert = 0.5f * invert; and used this
variable instead of recalculating this value multiple times.
Introduced the GLfloats mSkyWidth and mSkyHeight and used those
in the following loops instead of calling mSkySize.width () and
mSkySize.height () multiple times.
Try to avoid redundant GL_BLEND state changes, because OpenGL
will blindly change the global state, no matter what it currently
is set to and that state change is expensive. So we query and
save the actual blending state in the variable GLboolean
glBlendEnabled = glIsEnabled (GL_BLEND); and just enable it if
it isn't already and just disable it, if it was disabled before.

(LP: #1101422, LP: #1195977)

cube.cpp, other fixes:

Return false in function PrivateCubeScreen::updateGeometry (int, int)
if sides should ever be 0, which should never happen, but should make
Coverity happy.

(LP: #1101541)

Initialize all class member variables in the PrivateCubeScreen::
PrivateCubeScreen (CompScreen *) constructor.
(mTc, mNOutput, mOutput, mOutputMask, mCleared, mCapsPainted)

(LP: #1101575). Fixes: https://bugs.launchpad.net/bugs/1101422, https://bugs.launchpad.net/bugs/1101541, https://bugs.launchpad.net/bugs/1101575.

Approved by Sam Spilsbury, PS Jenkins bot.
Filename Latest Rev Last Changed Committer Comment Size
..
logmessage 2890.4.1 12 years ago Sam Spilsbury Move to a test-driven-development type buildsystem Diff
option 2937 12 years ago smspillaz Makes testing optional, cleans up option test Diff
plugin 2936.1.3 12 years ago Alan Griffiths Tests covering mocking filesystem Diff
pluginclasshandler 2893.4.8 12 years ago Daniel van Vugt Merge with upstream changes (lp:compiz-core). Diff
point 2908.7.1 12 years ago smspillaz Added module and test for CompPoint Diff
privatescreen 2961.6.1 12 years ago Alan Griffiths Baseline: test executable in place Diff
rect 2908.7.2 12 years ago smspillaz Added CompRect tests and module Diff
region 2999.1.1 12 years ago Alan Griffiths Test coverage for CompRegion Diff
servergrab 3221.2.13 12 years ago smspillaz Added missing files Diff
string 2890.4.1 12 years ago Sam Spilsbury Move to a test-driven-development type buildsystem Diff
tests 3465.1.9 11 years ago Daniel van Vugt Move src/test_outputdevices.cpp' => 'src/tests/tes Diff
timer 2890.4.1 12 years ago Sam Spilsbury Move to a test-driven-development type buildsystem Diff
window 2908.9.1 12 years ago smspillaz Added window geometry saver module and tests Diff
wrapsystem 2906.1.1 12 years ago Alan Griffiths Put wrapsystem under test Diff
action.cpp 3718.3.2 11 years ago MC Return stringToModifiers (CompString str) -> stringToModi 12.5 KB Diff Download File
actions.cpp 3718.3.1 11 years ago MC Return action.cpp and actions.cpp cleanup (please see mai 7.1 KB Diff Download File
asyncserverwindow.h 3506.1.32 11 years ago Sam Spilsbury Unrevert 3506.1.22 1.8 KB Diff Download File
atoms.cpp 2895.7.1 12 years ago smspillaz Support _NET_WM_STATE_FOCUSED (LP #904806) +_NET_ 10.4 KB Diff Download File
CMakeLists.txt 3506.1.40 11 years ago Sam Spilsbury Merge lp:compiz 5.7 KB Diff Download File
configurerequestbuffer-impl.h 3506.1.32 11 years ago Sam Spilsbury Unrevert 3506.1.22 3.6 KB Diff Download File
configurerequestbuffer.cpp 3506.1.50 11 years ago Sam Spilsbury Added test for configuring a window with a locked 9.2 KB Diff Download File
event.cpp 3746.1.3 10 years ago Sam Spilsbury Fix failing tests and run all the tests by default 58.5 KB Diff Download File
eventmanagement.h 3382.2.15 11 years ago Sam Spilsbury Forward declare correctly 2.7 KB Diff Download File
eventsource.cpp 3494.2.5 11 years ago Sam Spilsbury We already have the connnection number use the pro 2.3 KB Diff Download File
global.cpp 3494.5.5 11 years ago Sam Spilsbury Fix race conditions in the tests. 1. Have compiz 1.5 KB Diff Download File
icon.cpp 3041.1.1 12 years ago Alan Griffiths Fix CompIcon: deduplication of data, avoid unsuppo 1.5 KB Diff Download File
main.cpp 3617.1.13 11 years ago Sam Spilsbury Get rid of the initialPlugins-set-to-active_plugin 5.6 KB Diff Download File
match.cpp 3513.3.3 11 years ago Daniel van Vugt Finish const'ifying CompMatch, now that CompWindow 13.6 KB Diff Download File
modifierhandler.cpp 3473.3.42 11 years ago MC Return Simplified declaration of int i by moving it into 4.8 KB Diff Download File
option.cpp 3473.3.42 11 years ago MC Return Simplified declaration of int i by moving it into 14.7 KB Diff Download File
output.cpp 3720.2.7 10 years ago MC Return Use static_cast Minor indentation improvements 2.2 KB Diff Download File
outputdevices.cpp 3720.2.5 10 years ago MC Return Minor additional fixes (indentation, brackets, whi 5 KB Diff Download File
outputdevices.h 3720.2.4 11 years ago MC Return Minor additional cleanup 3 KB Diff Download File
outputdevices_x11.cpp 3720.2.7 10 years ago MC Return Use static_cast Minor indentation improvements 4.5 KB Diff Download File
plugin.cpp 3746.1.3 10 years ago Sam Spilsbury Fix failing tests and run all the tests by default 12.5 KB Diff Download File
privateaction.h 3382.2.14 11 years ago Sam Spilsbury Cleanup. Unindent namespaces, simplify interface, 1.9 KB Diff Download File
privateeventsource.h 3494.2.1 11 years ago Sam Spilsbury In order to safely destroy a Glib::Source you ne 1.7 KB Diff Download File
privateiosource.h 3494.2.1 11 years ago Sam Spilsbury In order to safely destroy a Glib::Source you ne 1.9 KB Diff Download File
privatematch.h 2308 15 years ago Danny Baumann Whitespace fixes. 2.2 KB Diff Download File
privateoption.h 2951 12 years ago smspillaz Revert things accidentally pushed to lp:compiz-cor 2 KB Diff Download File
privatescreen.h 3692.1.1 11 years ago stevenhooke11 at gmail startup notification: show busy cursor when applic 29.6 KB Diff Download File
privatesignalsource.h 2930.2.3 12 years ago smspillaz Added a new signals source to safely dispatch sign 1.6 KB Diff Download File
privatestackdebugger.h 3237.2.9 11 years ago Daniel van Vugt Rebase on latest upstream lp:compiz 2.7 KB Diff Download File
privatewindow.h 3753.8.4 10 years ago Sam Spilsbury Merge lp:compiz 10.8 KB Diff Download File
propertywriter.cpp 2908.5.1 12 years ago Alan Griffiths Remove annoying and excessive include dependencies 5.3 KB Diff Download File
screen.cpp 3674.2.2 11 years ago Sam Spilsbury Merge lp:compiz 121 KB Diff Download File
serverwindow.h 3506.1.32 11 years ago Sam Spilsbury Unrevert 3506.1.22 Empty Diff Download File
session.cpp 3753.10.1 10 years ago MC Return src/session.cpp cleanup (please see main commit me 10.6 KB Diff Download File
signalsource.cpp 3494.2.1 11 years ago Sam Spilsbury In order to safely destroy a Glib::Source you ne 2.2 KB Diff Download File
size.cpp 2376 14 years ago Dennis kasprzyk Changed unsigned int to int to fix warnings 1.4 KB Diff Download File
stackdebugger.cpp 3446.2.7 11 years ago MC Return Also initialize the member variable bool mTimeoutR 13.8 KB Diff Download File
syncserverwindow.h 3506.1.32 11 years ago Sam Spilsbury Unrevert 3506.1.22 1.6 KB Diff Download File
window.cpp 3766 10 years ago Tarmac Bias the current viewport in addWindowSizeChanges. 171 KB Diff Download File
windowgeometry.cpp 3513.3.2 11 years ago Daniel van Vugt Merge latest trunk 4.8 KB Diff Download File