~push-gopher/golang/tip

Viewing all changes in revision 17348.

  • Committer: Push Gopher
  • Author(s): Andrew Gerrand
  • Date: 2013-07-22 08:41:32 UTC
  • Revision ID: push-gopher@niemeyer.net-20130722084132-p3ng8ffevdabt141
[release-branch.go1.1] time: prevent a panic from leaving the timer mutex held

««« CL 10373047 / 974a69ed9fcf
time: prevent a panic from leaving the timer mutex held

When deleting a timer, a panic due to nil deref
would leave a lock held, possibly leading to a deadlock
in a defer. Instead return false on a nil timer.

Fixes issue 5745.

R=golang-dev, daniel.morsing, dvyukov, rsc, iant
CC=golang-dev
https://codereview.appspot.com/10373047

Committer: Russ Cox <rsc@golang.org>
»»»

Update issue 5928

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/11666046
HG=17348:2de1a6879076

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: