| 806
|
|
|
Kevin Anderson |
2 years ago
|
 |
|
| 805
|
|
|
Kevin Anderson |
2 years ago
|
|
|
| 804
|
|
|
Kevin Anderson |
2 years ago
|
|
|
| 803
|
|
|
Naman Priyadarshi |
2 years ago
|
|
|
| 802
|
|
|
Adam R. Jensen |
2 years ago
|
|
|
| 801
|
|
|
Somasree Majumder |
2 years ago
|
|
|
| 800
|
|
|
Somasree Majumder |
2 years ago
|
|
|
| 799
|
|
|
Saurabh Aneja |
2 years ago
|
|
|
| 798
|
|
|
Jack Kelly |
2 years ago
|
|
|
| 797
|
|
ENH: infinite sheds (#717)
* WIP: ENH: infinite sheds
* DOC: add infinite_sheds to api.rst, docstrings form sky_angle
* ENH: functions for infinite sheds
* add _to_radians and is_rad to convert only if necessary
* prefix all functions with get_
* add get_f_sky_pv, get_poa_sky_pv, get_ground_angle_tangent,
get_f_gnd_pv, get_f_gnd_pv, get_poa_gnd_pv, etc.
* update API ui
Signed-off-by: Mark Mikofski <bwana.marko@yahoo.com>
* ENH: clean up docstrings, add 4-quad arctan2, add api docs, more get_irradiance
* DOC: fix latex math, use psi_t for top, psi_b for bottom
* STY: don't use get_* for standard functions
* ENH: create class methods to get irradiance, FIXME: front/back poa not defined
* TST: add infinite_sheads test, add infinite_sheds to pvlib-api
* TST: ground illumination test
* TST: coerce df to float, replace div/0 with nan
* TST: set atol to 1e-6 to compare to CSV
* TST: test for shade line
* TST: fix diffuse fraction NaN and Inf, consolidate front+back = 1 test
* TST: add tests for sky angle, psi_top
* ENH: STY: fix stickler, ignore binary operator breaks
* get_irradiance, output ordered dict or dataframe
* finish updating get_poa_global_bifacial to transpose beam and diffuse
for each side separately
* add fixmes for ground illumination and ground view factor
* ENH: BUG: DOC: change "ground-illumination" to "unshaded-ground-fraction"
- use tan(zenith) in solar projection math latex
- implement gcr_prime and ground-sky-angles calculations
- add stub for ground-diffuse view factor
Signed-off-by: Mark Mikofski <bwana.marko@yahoo.com>
* ENH: BUG: calculate angles and VF from ground between panels to sky
- calculate ground-sky angles to previous and next rows, assuming height
is nonzero
- calculate limits on ground where it can see the sky
- calculate the view factor as a function of z on the ground to the sky
- fix places where it still says degrees, bad, no!
- add fixme for pv-sky view factor, still has wrong formula
- add tests for angles from point z on the ground to tops of current
row, and limits of previous and next rows
- add a script to make the plot of ground-sky view factor versus z
* ENH: BUG: remove gcr_prime from vf calc, not used
- add comments, change names x->z
- add TODO's to limit number of rows, and set row-type: 'first', 'last',
or 'middle'
* BUG: fix view factors formulas
- was difference of angles, should be difference of cosines
- also add TODO's to return VF versus point x on panel, and don't use
averages
* STY: shorten line in test_infinite_sheds for sum of angles at z1 limit
* DOC: update module docstring with process from Marion, et al.
- change calc_fx_sky to calc_fz_sky since z is for ground and x is for
pv surface
- add docstring to calc_fz_sky and for ground_sky_diffuse_view_factor
* BUG: revert changes to ground and sky to pv surface view factors
* ENH: integrate Fgnd-pv and Fsky-z
* change _bigz() to just return bigz
* create a test figure of integrated vslue
* fix references
* update infinite sheds
- integrate vf_gnd_sky and apply to poa_ground_diffuse
- new vf_ground_sky function
- fix iam.ashrae and total_irrad
- some cleanup, comment out old bifacialvf stuff
- add height, pitch, and npoints args where needed
Signed-off-by: Mark Mikofski <bwana.marko@yahoo.com>
* remove discretized angles for fgndsky
* don't discretize z
* remove maxp, bigz, zuni, and psi_zuni from calc_fgndpv_zsky and just use
the integrated value
* add more detail re: infinite sheds to module docstring
* change f_gnd_sky to f_gnd_beam everywhere
* derive how integrated vf_gnd_sky is applied to diffuse reflected light,
cite eqn (2) in Marion's paper
* clarify what next, prev mean
* add ascii sketches to clarify angles to top & bottom of prev or next
rows and for current row
* clarify what z0 and z1 limits mean
* clean up outputs for get_irradiance
- and InfiniteSheds.get_irradiance
* consolidate solar projection tests
* also compare phi and tan_phi
* use fraction of pvsurface fx
* add test for vf_ground_sky
* be quiet stickler
* TODO inserts, docstring edits
* re-organize
* create test files, move two functions to utils
* adjust test paths
* fix testing
* adjustments to sky_angle_tangent
* adjustments to get tests to run
* move shade_line to shading.shaded_fraction
* remove shade_line from infinite_sheds
* remove functions that have moved to utils, shading
* move several functions to private
* move more functions to private
* update test_utils.py
* linting
* tilt to surface_tilt, docstring work
* consolidate some functions, docstring work
* sky diffuse view factors
* finish editing get_irradiance and supporting functions
* rework public functions
* formatting
* remove old test file
* add tests for sky_angle functions, remove diffuse_ratio
* more tests, fix error in _sky_angle
* more tests and docstring work
* stickler
* remove old test file, test fixes
* test fixes
* remove axis from linspace usage
* documentation
* docstrings
* height = 0 and surface_tilt = 0 cases
* vectorize _vf_ground_sky
* overhaul ground to sky view factors, add function to utils
* lint, handle floats
* improve test fixture, remove unused
* loop over rotations in _vf_ground_sky_integ, test get_irradiance_poa
* more tests
* lint
* complete coverage
* progress on testing get_irradiance
* more testing
* whoops
* merge upstream
* remove local test hack
* correction to unshaded_ground_fraction
* move pvfactors tests
* additional testing
* add max_zenith to unshaded_ground_fraction
* docstring work
* use shading function, extend shading.shaded_fraction
* documentation
* clarifications, consistent argument order
* fix errors
* use numeric instead of array-like
* docstring sanding
* more docstring work, reorder arguments for consistency
* edits from review
* fix tests
* fix test
* remove max_rows from public
* move shaded_fraction from shading.py to infinite_sheds private
* move shading_fraction
* repair test, stickler
* remove axis_azimuth
* redo tests without axis_azimuth, few corrections
* trailing spaces
* behind the array criteria, return names
* changes from review
* diffuse fraction when ghi is 0
* clean up
* Apply suggestions from code review
Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>
* changes solar_zenith, solar_azimuth names
* Update pvlib/bifacial/infinite_sheds.py
Co-authored-by: Mark Mikofski <bwana.marko@yahoo.com>
* DOI directive in infinite_sheds.get_irradiance
* change back to solar_zenith, solar_azimuth
* rename in test_utils
* OrderedDict to dict
* create bifacial.rst
* Update docs/sphinx/source/user_guide/bifacial.rst
Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>
* remove OrderedDict
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Co-authored-by: Kevin Anderson <57452607+kanderso-nrel@users.noreply.github.com>
|
Mark Mikofski |
2 years ago
|
|
|
| 796
|
|
|
Cliff Hansen |
2 years ago
|
|
|
| 795
|
|
|
Adam R. Jensen |
2 years ago
|
|
|
| 794
|
|
|
Kevin Anderson |
2 years ago
|
|
|
| 793
|
|
|
Cliff Hansen |
2 years ago
|
|
|
| 792
|
|
|
Kevin Anderson |
2 years ago
|
|
|
| 791
|
|
|
Cliff Hansen |
2 years ago
|
|
|
| 790
|
|
|
Kevin Anderson |
2 years ago
|
|
|
| 789
|
|
|
Kevin Anderson |
2 years ago
|
|
|
| 788
|
|
|
Johann Lo |
2 years ago
|
|
|
| 787
|
|
|
Adam R. Jensen |
2 years ago
|
|
|
collapse all