~registry/kmod/master : changes

~registry/kmod/master » Changes from revision 1313

From Revision 1173 to 1154

Rev	Summary	Authors	Tags	Date
1173	build: Stop using dolt build: Stop using dolt This does regress "make -12" from 0.7s to 0.9s on my Coffee Lake machine, but even on slower hardware this will not amount to a noticable slowdown. On the other hand using dolt can create problems for people doing cross-compilation, e.g. Yocto has two hacks just for dolt in kmod: https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-kernel/kmod/kmod.inc?id=a17abae00785c76cfffe5381a22fb2c86b982e82 (Lucas: remove leftover entry in Makefile and reformat commit message)	Adrian Bunk		5 years ago
1172	Link against libcrypto, not all of openssl Link against libcrypto, not all of openssl In the previous build setup, libkmod.so would link to not just libcrypto.so, but also libssl.so: $ readelf -d /lib/libkmod.so \| grep NEEDED 0x0000000000000001 (NEEDED) Shared library: [liblzma.so.5] 0x0000000000000001 (NEEDED) Shared library: [libz.so.1] 0x0000000000000001 (NEEDED) Shared library: [libssl.so.1.1] 0x0000000000000001 (NEEDED) Shared library: [libcrypto.so.1.1] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] We don't need any symbols from libssl, though. This patch ensures that we pass 'libcrypto' to pkgconfig rather than 'openssl', getting only the library that we need: $ readelf -d ./libkmod/.libs/libkmod.so.2.3.4 \| grep NEEDED 0x0000000000000001 (NEEDED) Shared library: [liblzma.so.5] 0x0000000000000001 (NEEDED) Shared library: [libz.so.1] 0x0000000000000001 (NEEDED) Shared library: [libcrypto.so.1.1] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6]	Dave Reisner		5 years ago
1171	kmod 26 kmod 26	Lucas De Marchi	v26	5 years ago
1170	build: fix make distcheck build: fix make distcheck Make sure to add the dummy.pkcs7 file to the dist files. While at it, also change the distcheck flags to include --with-openssl.	Lucas De Marchi		5 years ago
1169	testsuite: mkosi: update files testsuite: mkosi: update files - Add openssl - Disable python (quick hack to avoid more dependencies) - Update Fedora to 29	Lucas De Marchi		5 years ago
1168	build: check openssl version build: check openssl version	Lucas De Marchi		5 years ago
1167	build: add openssl to CI deps build: add openssl to CI deps Travis-ci is at most on Ubuntu 16.04, that doesn't have openssl >= 1.1, so disable openssl there. Semaphore 2.0 was also missing a call to update the package database.	Lucas De Marchi		5 years ago
1166	build: enable openssl by default build: enable openssl by default Like with other features, let's enable it for developers.	Lucas De Marchi		5 years ago
1165	testsuite: fix modinfo test without openssl testsuite: fix modinfo test without openssl	Lucas De Marchi		5 years ago
1164	libkmod-signature: implement pkcs7 parsing with openssl libkmod-signature: implement pkcs7 parsing with openssl The patch adds data fetching from the PKCS#7 certificate using openssl library (which is used by scripts/sign-file.c in the linux kernel to sign modules). In general the certificate can contain many signatures, but since kmod (modinfo) supports only one signature at the moment, only first one is taken. With the current sign-file.c certificate doesn't contain signer key's fingerprint, so "serial number" is used for the key id. Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>	Yauheni Kaliuta		5 years ago
1163	testsuite: add modinfo pkcs7 signature test testsuite: add modinfo pkcs7 signature test Use the same approach to generate the signed module, like in the old signature test: just append the pregenerated binary signature to the module (the signature check will fail). In case of need of generating correct signature, from the linux kernel makefiles (certs/Makefile) it could be like: $ openssl req -new -nodes -utf8 -sha256 -days 36500 -batch -x509 -config ./x509.genkey -outform PEM -out signing_key.pem -keyout signing_key.pem $ /lib/modules/$(uname -r)/build/scripts/extract-cert signing_key.pem signing_key.x509 $ /lib/modules/$(uname -r)/build/scripts/sign-file sha256 signing_key.pem signing_key.x509 module.ko where x509.genkey is: ``` [ req ] default_bits = 4096 distinguished_name = req_distinguished_name prompt = no string_mask = utf8only x509_extensions = myexts [ req_distinguished_name ] CN = Build time autogenerated kernel key [ myexts ] basicConstraints=critical,CA:FALSE keyUsage=digitalSignature subjectKeyIdentifier=hash authorityKeyIdentifier=keyid ``` Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>	Yauheni Kaliuta		5 years ago
1162	man: Fix typo man: Fix typo	Daniel Kahn Gillmor		5 years ago
1161	testsuite: factor out fd related parameters to a structure testsuite: factor out fd related parameters to a structure This is a more abstract implementation of "file descriptor comparation". With the current implementation the code is full of conditions based on the descriptor type. It makes sense to initialize the parameters once based on the descriptor type. stdout and stderr are handled in almost the same way, but for monitor descriptor branch, based on the type check is necessary in some cases. Since epoll's context now contains pointers to the structures, so no direct manipulations there. Most of the patch is just replacing direct buffer manipulations with the structures' ones. Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>	Yauheni Kaliuta		5 years ago
1160	testsuite: track number of descriptors instead of their stat... testsuite: track number of descriptors instead of their state use the number of tracked descriptors to determine the end of the loop. This is a preparation for more abstract descriptor comparation implementation where checking of the descriptor state may be more expensive than just checking of the local variables. Signed-off-by: Yauheni Kaliuta <yauheni.kaliuta@redhat.com>	Yauheni Kaliuta		5 years ago
1159	Add semaphoreci 2.0 configuration Add semaphoreci 2.0 configuration Add another CI as alternative to travis-ci. Test on gcc 6, 7 and 8 on Ubuntu 18.04. Not sure if this is the best way to define the yml file, but it works. The old badge doesn't work. It will be added back later.	Lucas De Marchi		5 years ago
1158	testsuite: move --show-exports test to use regex testsuite: move --show-exports test to use regex This allows it to pass if the kernel is configured with CONFIG_MODVERSIONS.	Lucas De Marchi		5 years ago
1157	testsuite: add support for testing output against regex testsuite: add support for testing output against regex Allow to test outputs when they don't match exactly, but should follow some regex patterns. This can be used when the info we are printing is randomized or depends on kernel configuration.	Lucas De Marchi		5 years ago
1156	testsuite: split out function to compare outputs exactly testsuite: split out function to compare outputs exactly Move functionality to compare the exact output to a separate function and allocate one buffer per output/match pair. This will allow us to extend this to allow other types of comparisons. Since now we are using heap-allocated buffer, keep the buffer allocation to the caller, so we don't have to allocate and free it on every invocation. It also avoids the different comparison functions to have to deal with it.	Lucas De Marchi		5 years ago
1155	depmod: shut up gcc insufficinet buffer warning depmod: shut up gcc insufficinet buffer warning In a couple of places depmod concatenates the module directory and filename with snprintf. This can technically overflow creating an unterminated string if module directory name is long. Use openat instead as is done elsewhere in depmod. This avoids the snprintf, the extra buffer on stack, and the gcc warning. It may even fix a corner case when the module direcotry name is just under PATH_MAX. [ Lucas: fix up coding style and closing fd on error path ] Signed-off-by: Michal Suchanek <msuchanek@suse.de>	Michal Suchanek		5 years ago
1154	depmod: prevent module dependency files corruption due to pa... depmod: prevent module dependency files corruption due to parallel invocation. Depmod does not use unique filename for temporary files. There is no guarantee the user does not attempt to run mutiple depmod processes in parallel. If that happens a temporary file might be created by depmod(1st), truncated by depmod(2nd), and renamed to final name by depmod(1st) resulting in corrupted file seen by user. Due to missing mkstempat() this is more complex than it should be. Adding PID and timestamp to the filename should be reasonably reliable. Adding O_EXCL as mkstemp does fails creating the file rather than corrupting existing file. Signed-off-by: Michal Suchanek <msuchanek@suse.de>	Michal Suchanek		5 years ago