- Committer: Lucas De Marchi
- Date: 2024-04-30 17:33:52 UTC
- Revision ID: git-v1:90b271fbd2b9708a8fa79b7e98d90c7919e7ed73
libkmod: clear file->memory if map fails
On mmap failure file->memory is set to -1, which we'll happily pass down
to munmap later on.
More importantly, since we do a NULL check in kmod_file_load_contents()
we will exit the function without (re)attempting the load again.
Since we ignore the return code for the load function(s), one can end up
calling kmod_elf_get_memory() and feed that -1 into init_module.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
On mmap failure file->memory is set to -1, which we'll happily pass down
to munmap later on.
More importantly, since we do a NULL check in kmod_file_load_contents()
we will exit the function without (re)attempting the load again.
Since we ignore the return code for the load function(s), one can end up
calling kmod_elf_get_memory() and feed that -1 into init_module.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 .. |
|||||||
libkmod
|
2 | 12 years ago | Lucas De Marchi | Rename libabc to libkmod |
|
||
|
m4
|
1 | 12 years ago | Lucas De Marchi | Import skeleton from libabc |
|
||
|
man
|
439 | 12 years ago | Lucas De Marchi | rename doc dir to man |
|
||
|
shared
|
919 | 10 years ago | Lucas De Marchi | Move macro.h to shared directory It's not really |
|
||
|
shell-completion
|
815 | 11 years ago | Lucas De Marchi | shell-completion: Add initial completion for kmod |
|
||
|
testsuite
|
495 | 12 years ago | Lucas De Marchi | testsuite: add skeleton |
|
||
|
tools
|
163 | 12 years ago | Lucas De Marchi | Merge branch 'use-mmap' Conflicts: libkmod/libkm |
|
||
.gitignore |
1328 | 5 months ago | Lucas De Marchi | build: Ignore directories commonly used for out-of | 324 bytes |
|
|
autogen.sh |
1316 | 8 months ago | Lucas De Marchi | Drop python bindings Python bindings are not well | 1.7 KB |
|
|
|
CODING-STYLE |
971 | 9 years ago | Lucas De Marchi | CODING-STYLE: add include order | 2.3 KB |
|
|
|
configure.ac |
1326 | 7 months ago | Lucas De Marchi | Install kmod.pc in ${datadir}/pkgconfig The data | 11.3 KB |
|
|
|
COPYING |
928 | 10 years ago | Lucas De Marchi | Clarify what licences apply where This doesn't ch | 25.8 KB |
|
|
|
Makefile.am |
1326 | 7 months ago | Lucas De Marchi | Install kmod.pc in ${datadir}/pkgconfig The data | 13.5 KB |
|
|
|
NEWS |
1324 | 7 months ago | Lucas De Marchi | kmod 32 | 31.4 KB |
|
|
|
README.md |
1316 | 8 months ago | Lucas De Marchi | Drop python bindings Python bindings are not well | 3.6 KB |
|
|
|
TODO |
1142 | 6 years ago | Lucas De Marchi | libkmod-module: check for NULL before accessing po | 2.1 KB |
|
|