← Back to branch summary

~rharding/juju-gui/charm-details-1172050

« back to all changes in this revision

Viewing changes to app/store/env/python.js

  • Committer: Brad Crittenden
  • Date: 2013-04-19 17:43:27 UTC
  • mfrom: (563.4.4 update-config)
  • Revision ID: bac@canonical.com-20130419174327-rs79f3tqaoi0k7cw
Fix config update.

The call to set_config was not passing the proper parameters resulting in
the callback not happening.  A test has been added to ensure the two
optional parameters are passed properly to ensure this doesn't
happen again.

R=jeff.pihach, teknico
CC=
https://codereview.appspot.com/8702045

Show diffs side-by-side

added added

removed removed

Lines of Context:
app/store/env/python.js
349
349
     * @return {undefined} Sends a message to the server only.
350
350
     */
351
351
    set_config: function(service, config, data, callback) {
 
352
      if ((Y.Lang.isValue(config) && Y.Lang.isValue(data)) ||
 
353
          (!Y.Lang.isValue(config) && !Y.Lang.isValue(data))) {
 
354
        throw 'Exactly one of config and data must be provided';
 
355
      }
352
356
      this._send_rpc({
353
357
        op: 'set_config',
354
358
        service_name: service,