-
Committer:
Rick Harding
-
Author(s):
Richard Harding
-
Date:
2013-08-28 12:09:47 UTC
-
mfrom:
(984.1.10 more-state-issues)
-
Revision ID:
rick.harding@canonical.com-20130828120947-hwriqt5vre7owxq3
Fixes state issues with browser/service view
- Fixes #1217449 & #1217450
- viewmode controls widget now clear the events to the DOM it binds with a
custom destroy event helper.
- Since it's not cleaning them up, we can not clean them in tests manually.
- Update the app.js triggers on the viewmode control events to build the
entire url and send that along to the navigate call.
- Make sure we destroy controls when we're done with the app managing them
(while the gui service views are available)
- The initState needs to clear old views so that when we re-init no old views
are holding events that no longer apply. Share the code now since it's used in
multiple places.
- _getStateUrl was improperly updating the _oldState to aid testing. Remove
that and fix tests.
- In some cases when hidden, we might have no subapp._sidebar but the
_oldState says there's been no state change.
- Update tests around initState, viewmode controls widget, etc.
R=jeff.pihach, frankban
CC=
https://codereview.appspot.com/13242046