~robru/friends/refresh-fixup

Viewing all changes in revision 14.

  • Committer: Robert Bruce Park
  • Date: 2012-10-19 01:06:05 UTC
  • Revision ID: robert.park@canonical.com-20121019010605-66maduywe8icl564
Drop extraneous instance attribute from Authentication class.

This commit also does some minor cleanups, and introduces some new
debugging statements that may prove helpful in tracking down any
future hangs we discover.

Authentication._authenticating turned out to be redundant, I've
dropped it in favor of testing for the presence of self._reply
directly. Authentication.login sees that self._reply isn't populated
yet, so it blocks, and then the callback populates that value and
stops the lock, allowing login() to return that value.

expand all expand all

Show diffs side-by-side

added added

removed removed

Lines of Context: