416
|
|
|
William Reade |
11 years ago
|
|
|
415
|
|
|
William Reade |
11 years ago
|
|
|
414
|
|
|
Roger Peppe |
11 years ago
|
|
|
413
|
|
|
Roger Peppe |
11 years ago
|
|
|
412
|
|
|
William Reade |
11 years ago
|
|
|
411
|
|
handle breaking relations
EDIT: many API choices have been supplanted by those made in the followup:
* https://codereview.appspot.com/6461084
It would probably be sensible to focus on logic for this branch, and handle API discussion in the other; I hope/expect to merge the followup very soon after merging this one.
This involved several changes, which are all interrelated to a greater or lesser degree. To wit:
* RelationState needs to have some concept of brokenness. * RelationUnit needs to be able to Depart a relation (distinct from Killing the Join Pinger, because we may not be actively joined when we need to depart, and it would just be crazy to join the relation only to depart again). * We need a BrokenHookQueue for sending necessary departeds and finally a broken. * RelationContext needs to be more careful with cached settings (this became apparent when considering the BHQ, which has no access to state, but was a pre-existing problem (because a normal HQ would, on startup, send a bunch of empty-settings departed hooks, each of which would nuke any cached member settings in the affected RelationContext)). Accomplished with UpdateMembers and DelMember in place of SetMembers. * Relationer itself needs to care about all the above, to a greater or lesser extent.
After some deliberation, I'm pretty sure that all these changes make more sense together than they do separately, and the branch isn't *that* big, so I'm hoping it will pass muster.
R=TheMue, niemeyer CC= https://codereview.appspot.com/6459067
|
William Reade |
11 years ago
|
|
|
410
|
|
|
Roger Peppe |
11 years ago
|
|
|
409
|
|
|
Roger Peppe |
11 years ago
|
|
|
408
|
|
|
Roger Peppe |
11 years ago
|
|
|
407
|
|
|
Roger Peppe |
11 years ago
|
|
|
406
|
|
|
Roger Peppe |
11 years ago
|
|
|
405
|
|
|
Roger Peppe |
11 years ago
|
|
|
404
|
|
|
Roger Peppe |
11 years ago
|
|
|
403
|
|
|
Roger Peppe |
11 years ago
|
|
|
402
|
|
|
Dave Cheney |
11 years ago
|
|
|
401
|
|
|
Aram Hăvărneanu |
11 years ago
|
|
|
400
|
|
|
Aram Hăvărneanu |
11 years ago
|
|
|
399
|
|
|
Aram Hăvărneanu |
11 years ago
|
|
|
398
|
|
|
Aram Hăvărneanu |
11 years ago
|
|
|
397
|
|
|
Aram Hăvărneanu |
11 years ago
|
|
|