~rogpeppe/juju-core/256-more-status : changes

~rogpeppe/juju-core/256-more-status » Changes from revision 1059

From Revision 1041 to 1022

Rev	Summary	Authors	Date
1041	log: fix data race on log.Target log: fix data race on log.Target Many of our test cases set the value of log.Target, then reset it during the test/suite teardown. This has always been racy, but we've worked around it. We're now at the point that it can't be hidden anymore. In this case it is the mgo connection retry logic inside the state tests, but it will always be something. This proposal makes the setting and getting of log.Target() (actually, log.target.logger) thread safe, and introduces a new nilLogger to make the logic inside each of the logging methods. There is probably also a race on log.Debug, so a similar proposal will be needed as a followup. Also, as witnessed by the duplication of logic that sets and resets the log.Target, try to push as much of the log target slight of hand into testing.LoggingSuite. R=jameinel, dimitern, rog, fwereade, thumper CC= https://codereview.appspot.com/7524046	Dave Cheney	11 years ago
1040	Add SetServiceConstraints to API Add SetServiceConstraints to API This also involved moving the Constraints struct into its own package in order to break an import cycle. R=dfc, bac, dimitern, fwereade CC= https://codereview.appspot.com/7600044	Benji York	11 years ago
1039	worker/uniter: disable broken test worker/uniter: disable broken test The disabled test fails >80% of the time on my machine. (this fix pre-LGTM'd by fwereade, so submitting immediately) R= CC= https://codereview.appspot.com/7929043	Roger Peppe	11 years ago
1038	state: hook up StateWatcher to allWatcher state: hook up StateWatcher to allWatcher You never know, the GUI might start working now. R=dimitern, fwereade CC= https://codereview.appspot.com/7663048	Roger Peppe	11 years ago
1037	Annotation documents and Environment Entity Annotation documents and Environment Entity Annotations were moved to separate documents in order to prevent the act of setting an annotation from affecting watchers on the entities. Annotations are stored, one document per entity, in a separate collection which are removed when the entities are removed. In addition, an environment-level Entity was created in order to allow storing annotations on the environment, and potentially for expansion in the future. R=matthew.scott, dimitern, fwereade, rog CC=roger.peppe https://codereview.appspot.com/7598043	Francesco Banconi	11 years ago
1036	state: implement allWatcherStateBacking state: implement allWatcherStateBacking This completes the initial implementation of StateWatcher - in the next branch, we'll change the API to use it. R=dfc, dimitern, TheMue CC= https://codereview.appspot.com/7650048	Roger Peppe	11 years ago
1035	store: support querying stats before/after a date store: support querying stats before/after a date R=dimitern, jameinel CC= https://codereview.appspot.com/7653045	Gustavo Niemeyer	11 years ago
1034	store: add support for json stats formatting store: add support for json stats formatting Also properly factor out the formatting logic on the way to that. R=dimitern, jameinel CC= https://codereview.appspot.com/7760045	Gustavo Niemeyer	11 years ago
1033	environs: StartInstance accepts constraints environs: StartInstance accepts constraints ...and in ec2 honours them. R= CC= https://codereview.appspot.com/7735045	William Reade	11 years ago
1032	Revert revno 1031 due to test failure. Revert revno 1031 due to test failure. R=fwereade CC= https://codereview.appspot.com/7719050	Nicola Larosa	11 years ago
1031	Support 'add-relation' in API. Support 'add-relation' in API. R=dimitern, bac CC= https://codereview.appspot.com/7763048	Nicola Larosa	11 years ago
1030	state: upgrade charm for services/units state: upgrade charm for services/units This introduces the following changes: - Service.SetCharm now performs validation on the configuration when changing the charm to ensure what's about to be set is compatible with the current service's charm. Also introduces multiple settings per service (one for each unique charm URL), and uses reference counting to manage these and clean them up. - Unit.SetCharmURL does more sanity checks before changing the unit's charm and also maintains the reference counts of service settings. Fixes LP bug #1063621. This CL was reverted before in r943, now reintroduced and made to work with current trunk. R=fwereade, rog CC= https://codereview.appspot.com/7497047	Dimiter Naydenov	11 years ago
1029	environs: send bootstrap constraints in cloudinit environs: send bootstrap constraints in cloudinit This closes the circuit, and causes the bootstrap constraints to be set as the initial environment constraints in state. R=jameinel, thumper, dimitern CC= https://codereview.appspot.com/7712046	William Reade	11 years ago
1028	environs/ec2: constrained bootstrap instance environs/ec2: constrained bootstrap instance The constraints passed into juju bootstrap are now used to determine the instance type that will be launched. R=dfc, thumper, dimitern CC= https://codereview.appspot.com/7754046	William Reade	11 years ago
1027	rpc: fix race in test rpc: fix race in test We were sometimes closing the listener before it got a chance to listen... R=dfc, jameinel CC= https://codereview.appspot.com/7919043	Roger Peppe	11 years ago
1026	environs/ec2: instance-type logic and data environs/ec2: instance-type logic and data Not hooked up to anything else yet, no change in functionality. R=dimitern, jameinel, dfc, thumper CC= https://codereview.appspot.com/7693048	William Reade	11 years ago
1025	Move uploading tools out of environs.Bootstrap. Move uploading tools out of environs.Bootstrap. The actual code to upload the tools was identical for ec2 and openstack. This logic has been moved into UploadTools in environs/tools.go. The uploadTools bool parameter to Bootstrap has been removed. The call-sites that were now uploding tools before get simpler, and those that were, or perhaps were got a few extra lines of code. The tools selection criteria hasn't changed and I've tried to keep the change as isolated as possible. Tools selection is about to change soon anyway with the constraints work that is landing soon. R=fwereade, dimitern, dfc CC= https://codereview.appspot.com/7627044	Tim Penhey	11 years ago
1024	environs/openstack/local_test: No localLive Tests environs/openstack/local_test: No localLive Tests Tests that are local-only are meant to exist on localServerSuite, not on localLiveSuite. localLiveSuite is only supposed to have the tests that LiveSuite runs against a real provisioner, only running them against the local provisioner. This makes it clearer when you see tests running that there should be a LiveSuite.Foo for every localLiveSuite.Foo. TestBootstrapFailsWhenPublicIPError was the only one doing it incorrectly. The other change is because the code was ordered as: type localLiveSuite struct {} type localServerSuite struct {} func (... localLiveSuite) ... func (... localServerSuite)... This changes it to be: type localLiveSuite struct {} func (... localLiveSuite) ... type localServerSuite struct {} func (... localServerSuite)... localLiveSuite and localServerSuite are close enough in name, that it was hard to see the function right there and figure out why it wasn't getting called. This just moved the localServerSuite definition so that it was next to its methods. R=dimitern, rog CC= https://codereview.appspot.com/7613047	John A Meinel	11 years ago
1023	Add destroy-relation to API. Add destroy-relation to API. R=dimitern, fwereade, dfc CC= https://codereview.appspot.com/7610046	Brad Crittenden	11 years ago
1022	Add category list to charms Add category list to charms Added category list to charms to support charmworld, which will display charm categories. While most charms will have only one, some will fit into multiple categories, such as Apache, which is both a web server and a proxy. There will be an official list of categories, but supplying an unofficial category is a lint error, not a syntax error, so this branch does not address that. The order of the values is not significant, so in Python terms categories are a set, not a list, but since none of JSON, BSON and Go has direct support for sets, a list is used. This branch also adds tests to ensure that Meta objects can be roundtripped via BSON. R=dfc, fwereade, jameinel CC= https://codereview.appspot.com/7762043	Aaron Bentley	11 years ago

Older »