1046
|
|
|
Tim Penhey |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1045
|
|
|
Martin Packman |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1044
|
|
|
John A Meinel |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1043
|
|
|
Francesco Banconi |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1042
|
|
|
Ian Booth |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1041
|
|
log: fix data race on log.Target
Many of our test cases set the value of log.Target, then reset it during the test/suite teardown. This has always been racy, but we've worked around it. We're now at the point that it can't be hidden anymore. In this case it is the mgo connection retry logic inside the state tests, but it will always be something.
This proposal makes the setting and getting of log.Target() (actually, log.target.logger) thread safe, and introduces a new nilLogger to make the logic inside each of the logging methods.
There is probably also a race on log.Debug, so a similar proposal will be needed as a followup.
Also, as witnessed by the duplication of logic that sets and resets the log.Target, try to push as much of the log target slight of hand into testing.LoggingSuite.
R=jameinel, dimitern, rog, fwereade, thumper CC= https://codereview.appspot.com/7524046
|
Dave Cheney |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1040
|
|
|
Benji York |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1039
|
|
|
Roger Peppe |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1038
|
|
|
Roger Peppe |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1037
|
|
|
Francesco Banconi |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1036
|
|
|
Roger Peppe |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1035
|
|
|
Gustavo Niemeyer |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1034
|
|
|
Gustavo Niemeyer |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1033
|
|
|
William Reade |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1032
|
|
|
Nicola Larosa |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1031
|
|
|
Nicola Larosa |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1030
|
|
|
Dimiter Naydenov |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1029
|
|
|
William Reade |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1028
|
|
|
William Reade |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|
1027
|
|
|
Roger Peppe |
11 years ago
|
![Diff](/static/images/ico_diff.gif) |
|