- Committer: Tarmac
- Date: 2013-09-10 01:39:09 UTC
- mfrom: (1665.6.6 009-reboot-cycle)
- Revision ID: tarmac-20130910013909-my6ntoz4amn95mm8
[r=natefinch] fix local provider upgrade loop
Fix for https://bugs.launchpad.net/juju-core/+bug/1214676
upgrade-juju in local environment causes bootstrap machine agent to restart continuously
This is a problem with the creation of the upstart script for the local provider. It is hard-coded against the tools version that exists when you bootstrap the environment. The rest of the code goes through the upgrade correctly, which updates the symlink at .juju/local/tools/machine-0 ... but the upstart script wasn't referencing that symlink, so it doesn't use the new tools after we restarted... causing it to use the old version and think it needs to upgrade again.
To fix this, I simply called agent/tools/ChangeAgentTools to create the symlink during local provider's bootstrap, and make sure we use the symlink as the tools dir in the upstart script.
https://codereview.appspot.com/13595043/
Fix for https://bugs.launchpad.net/juju-core/+bug/1214676
upgrade-juju in local environment causes bootstrap machine agent to restart continuously
This is a problem with the creation of the upstart script for the local provider. It is hard-coded against the tools version that exists when you bootstrap the environment. The rest of the code goes through the upgrade correctly, which updates the symlink at .juju/local/tools/machine-0 ... but the upstart script wasn't referencing that symlink, so it doesn't use the new tools after we restarted... causing it to use the old version and think it needs to upgrade again.
To fix this, I simply called agent/tools/ChangeAgentTools to create the symlink during local provider's bootstrap, and make sure we use the symlink as the tools dir in the upstart script.
https://codereview.appspot.com/13595043/
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
hooks
|
894.2.2 | 11 years ago | Dimiter Naydenov | Changes after review - renamed charm/hook/ to char |
|
||
bundle.go |
1206.2.1 | 11 years ago | Martin Packman | Add copyright statement at the top of all go files | 5.7 KB |
|
|
|
bundle_test.go |
1657.1.6 | 10 years ago | Roger Peppe | gocheck imports - a-d | 7.6 KB |
|
|
|
charm.go |
1206.2.1 | 11 years ago | Martin Packman | Add copyright statement at the top of all go files | 1 KB |
|
|
|
charm_test.go |
1657.1.6 | 10 years ago | Roger Peppe | gocheck imports - a-d | 2.3 KB |
|
|
|
config.go |
1723.1.1 | 10 years ago | Frank Mueller | charm: reverted branch | 6.6 KB |
|
|
|
config_test.go |
1723.1.1 | 10 years ago | Frank Mueller | charm: reverted branch | 11.2 KB |
|
|
|
dir.go |
1408.1.1 | 10 years ago | John Arbash Meinel | Start changing the imports of the middle level fil | 5.2 KB |
|
|
|
dir_test.go |
1657.1.6 | 10 years ago | Roger Peppe | gocheck imports - a-d | 7.2 KB |
|
|
|
export_test.go |
1754.2.1 | 10 years ago | John Arbash Meinel | Instead of writing little wrapper functions in exp | 266 bytes |
|
|
|
meta.go |
1659.1.1 | 10 years ago | Dimiter Naydenov | Moved IsImplicit() and ImplementedBy() from state/ | 9.6 KB |
|
|
|
meta_test.go |
1657.1.6 | 10 years ago | Roger Peppe | gocheck imports - a-d | 15.4 KB |
|
|
|
repo.go |
1408.1.1 | 10 years ago | John Arbash Meinel | Start changing the imports of the middle level fil | 9.7 KB |
|
|
|
repo_test.go |
1657.1.6 | 10 years ago | Roger Peppe | gocheck imports - a-d | 17.1 KB |
|
|
|
url.go |
1408.1.1 | 10 years ago | John Arbash Meinel | Start changing the imports of the middle level fil | 6.6 KB |
|
|
|
url_test.go |
1657.1.6 | 10 years ago | Roger Peppe | gocheck imports - a-d | 7.5 KB |
|
|