- Committer: Dimiter Naydenov
- Date: 2013-02-15 17:56:00 UTC
- mfrom: (896.1.5 bug-864164-executable-hooks)
- Revision ID: dimiter.naydenov@canonical.com-20130215175600-38m7rr1blhdk2ie2
charm: Fix bug #864164 - non-exec hooks
Changed ExpandTo() and BundleTo() to set
executable permissions while processing
charm hook files. In the case of BundleTo(),
as mentioned in the bug, a warning is issued
to the log about this, while in ExpandTo()
it happens silently.
Permissions of hooks are set executable by owner.
Added tests and a testing charm with all hooks
defined.
R=fwereade, rog
CC=
https://codereview.appspot.com/7305096
Changed ExpandTo() and BundleTo() to set
executable permissions while processing
charm hook files. In the case of BundleTo(),
as mentioned in the bug, a warning is issued
to the log about this, while in ExpandTo()
it happens silently.
Permissions of hooks are set executable by owner.
Added tests and a testing charm with all hooks
defined.
R=fwereade, rog
CC=
https://codereview.appspot.com/7305096
| Filename | Latest Rev | Last Changed | Committer | Comment | Size | ||
|---|---|---|---|---|---|---|---|
 ..
|
|||||||
builddb
|
580.4.2 | 12 years ago | Gustavo Niemeyer | Moved builddb to cmd/. Now that environs packs to |
|
||
|
charmd
|
894.1.1 | 11 years ago | Dave Cheney | undo charm store removal, rev 886 |
|
||
|
charmload
|
894.1.1 | 11 years ago | Dave Cheney | undo charm store removal, rev 886 |
|
||
|
juju
|
37.3.14 | 12 years ago | William Reade | hefty rearrangement, few actual changes |
|
||
|
jujuc
|
91.1.6 | 12 years ago | William Reade | move to jujuc/server |
|
||
|
jujud
|
50.1.2 | 12 years ago | William Reade | untested sketch of jujud command |
|
||
cmd.go |
659.1.2 | 12 years ago | Roger Peppe | fix some log messages | 3.5 KB |
|
|
|
cmd_test.go |
478.1.1 | 12 years ago | Dave Cheney | add ctx.Stdin | 3.1 KB |
|
|
|
filevar.go |
709.1.1 | 11 years ago | Dave Cheney | gofmt | 567 bytes |
|
|
|
filevar_test.go |
709.1.1 | 11 years ago | Dave Cheney | gofmt | 1.3 KB |
|
|
|
logging.go |
255 | 12 years ago | Gustavo Niemeyer | launchpad.net/juju-core/juju => launchpad.net/juju | 1 KB |
|
|
|
logging_test.go |
255 | 12 years ago | Gustavo Niemeyer | launchpad.net/juju-core/juju => launchpad.net/juju | 2.4 KB |
|
|
|
output.go |
355.1.2 | 12 years ago | William Reade | address review | 4.2 KB |
|
|
|
output_test.go |
709.1.1 | 11 years ago | Dave Cheney | gofmt | 3.1 KB |
|
|
|
supercommand.go |
794.6.2 | 11 years ago | William Reade | whoops, fix purpose | 3.1 KB |
|
|
|
supercommand_test.go |
794.6.2 | 11 years ago | William Reade | whoops, fix purpose | 3.2 KB |
|
|
|
util_test.go |
478.1.1 | 12 years ago | Dave Cheney | add ctx.Stdin | 1.6 KB |
|
|